From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 839B242FB2; Tue, 1 Aug 2023 15:24:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17DD540F16; Tue, 1 Aug 2023 15:24:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 42FFA40A89 for ; Tue, 1 Aug 2023 15:24:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690896274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cqOuqV+QN0HR8GYJu9NiMtehSSc71xz4XymHdVTL/tI=; b=ERFD99tY/92zXpKXRdhZRjQpIXl/yhSzmK7pWdhPf17NeMSj7J6KOacfOfMUfxHgg+jw5i HxPkjhis0PNRVohD80jK7XEtNR4nhRc1GMJUNj7lnJL/KnVby1GO17Eh3IVu9FpO73Tbky VPrz+Tqjr4qJyI+DBZkL7H6pFRCaVeg= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-AChVr62rNWqEO4imvgoYAA-1; Tue, 01 Aug 2023 09:24:33 -0400 X-MC-Unique: AChVr62rNWqEO4imvgoYAA-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2684179bdddso3575266a91.0 for ; Tue, 01 Aug 2023 06:24:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690896272; x=1691501072; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cqOuqV+QN0HR8GYJu9NiMtehSSc71xz4XymHdVTL/tI=; b=cUxrtPn5vKY7tnoEfyA7x445pb4Vo/Dq0AR+2ftwGsHMUABtrHA2hfxOzoZE+pJm75 lcByA7MD6Z13bKuHL0PHLC7yUVWK98dBfbX/sG4PrTzBh6mihGlOxM0HaOAI4/y5f3DO xZpXhn/PlAsQ+L1U+WpaauDTCjpuNnuvzEcR3UqjEumJl6DRi5HhIQagKpc/T/iMHXYr 3zkSycbkOZ6oT5p6t1Aetm3Gx326l/JQ7PPspkaFjT5jwHDK9gNhb0oq7i5z6B065AOR VavYQHT4Mq/x/0QyZDAWu+8YLUYfA+jtsKKL4ieHnFUnRdT6FCyuzfKKQyUNDsOS/mFM Z+zw== X-Gm-Message-State: ABy/qLYUl8HdQNI4MljQ3t6fe7Ac1bKa0Nov18PT3AnWcaT5waoZn5s3 1453sqQQeMIT+0qsIbT8pcxwCVZ+A/gXQW4RfelLHKSVsOujq9GYj9YRUCWLzcPvAjGmo0A/hgQ J76Vy44YyjuNESYt1P4A= X-Received: by 2002:a17:90a:de91:b0:263:68b0:8ca5 with SMTP id n17-20020a17090ade9100b0026368b08ca5mr10745508pjv.43.1690896272392; Tue, 01 Aug 2023 06:24:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlGzYTK5vByJ1Sr/sXQJhpLPrT78Z+I6PgJwqtV7hDTzXUPKw3C5XlvLVP/85Rd9KdXrDUF3ntAkD4dBODucm0o= X-Received: by 2002:a17:90a:de91:b0:263:68b0:8ca5 with SMTP id n17-20020a17090ade9100b0026368b08ca5mr10745491pjv.43.1690896272127; Tue, 01 Aug 2023 06:24:32 -0700 (PDT) MIME-Version: 1.0 References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230801131549.323733-1-bruce.richardson@intel.com> In-Reply-To: <20230801131549.323733-1-bruce.richardson@intel.com> From: David Marchand Date: Tue, 1 Aug 2023 15:24:19 +0200 Message-ID: Subject: Re: [PATCH v4] build: update DPDK to use C11 standard To: Bruce Richardson Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Tyler Retzlaff , Thomas Monjalon , Ali Alnubani , Raslan Darawsheh X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 1, 2023 at 3:16=E2=80=AFPM Bruce Richardson wrote: > > As previously announced, DPDK 23.11 will require a C11 supporting > compiler and will use the C11 standard in all builds. > > Forcing use of the C standard, rather than the standard with > GNU extensions, means that some posix definitions which are not in > the C standard are unavailable by default. We fix this by ensuring > the correct defines or cflags are passed to the components that > need them. > > Signed-off-by: Bruce Richardson > Acked-by: Morten Br=C3=B8rup > Acked-by: Tyler Retzlaff > --- > V4: > * pass cflags to the structure and definition checks in mlx* drivers > to ensure posix definitions - as well as C-standard ones - are > available. With this v4, mlx4 builds fine in my Ubuntu 20.04.6 container. However, I think the mlx4dv.h includes are probably faulty: as this header is using off_t, it should include sys/types.h in the first place. https://github.com/linux-rdma/rdma-core/blob/master/providers/mlx4/mlx4dv.h= #L36 This had been fixed in the mlx5 header in some rdma-core change in the past: https://github.com/linux-rdma/rdma-core/commit/d2389b34ccc5 --=20 David Marchand