From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18B97A00C2; Wed, 5 Oct 2022 21:36:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A802240DFB; Wed, 5 Oct 2022 21:36:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 190FC40DDC for ; Wed, 5 Oct 2022 21:36:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664998612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9qOvllGbtBRPCDjg5hOhK/S2fa6mB4IP97nXY3vLpyk=; b=TYiiofgOyp9HjGw0O3+veztFaSQw8TlaxO4KQ9LVwI6PDhTvBm8y0FVs40eBWTnC2li1xz 2Zuf+Vqp/x4j72rJ96uygYuZL2LX3FE2j48/5g1exxG4JSYDHAWq4xQ1M7MtDLVq2FawvX 2GQFlHSkYoFZMFWmq/qWykAmgZV2LNM= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-591-Z9bWbUJgM-C709sz-K89Pw-1; Wed, 05 Oct 2022 15:36:51 -0400 X-MC-Unique: Z9bWbUJgM-C709sz-K89Pw-1 Received: by mail-pj1-f69.google.com with SMTP id z9-20020a17090a468900b00202fdb32ba1so1362437pjf.1 for ; Wed, 05 Oct 2022 12:36:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=9qOvllGbtBRPCDjg5hOhK/S2fa6mB4IP97nXY3vLpyk=; b=7TcH6TI+piqmWbutpDj0ACFngbkBpPMc+xrttdEa1KLSiyo7gSNmL5VoiY8/07j1Sx cxe4PKBG4i1T3kr8sGYp28CHavWRgfHwIWuCl6YeVQ4YTY8QkP1eGgUAfvuQj0pJwvQw +9uT1MZkaNXFgxUKhUppa/XiJAp1vpNccR6Iopn21NGR1h/x6Pif+7vUqu7y4iqbqqgP buk1xgB1LTmjNUTkmPnG/kN+/amOYmjf7xN1sIeaYujOsB+c65cqWNvDtj13hbEw1ih3 hJbjsNj5CibXNLfsLp8qYsmd6W9mNzxoA173ow1YUPDe0un+53MfmoKq1IGTftEBIuKp O8kw== X-Gm-Message-State: ACrzQf3vLL58CMYxpHzLINLn8rk7dUFr9h8jRCEFjXJ+r0kMKKuz+YD4 nlcV2STwvUfBnBfrY19/HBjiDlxVZBYalXA8CS9SST2/jXNUNRcZtcfRje9/0MzzZ5JmoO9mKHH M1oQFsXioVm5dpJEkWys= X-Received: by 2002:a17:90a:428e:b0:205:d5fe:e0b3 with SMTP id p14-20020a17090a428e00b00205d5fee0b3mr1307656pjg.33.1664998610267; Wed, 05 Oct 2022 12:36:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6NFSPWVCDRchx8t74+FUamuUyHNsKTwjdeoApeoBel3hcyrfcukiORqbY7rn63qP85wmFFzUldE4X/2QGKM2c= X-Received: by 2002:a17:90a:428e:b0:205:d5fe:e0b3 with SMTP id p14-20020a17090a428e00b00205d5fee0b3mr1307574pjg.33.1664998609026; Wed, 05 Oct 2022 12:36:49 -0700 (PDT) MIME-Version: 1.0 References: <20221004080026.180919-1-david.marchand@redhat.com> In-Reply-To: <20221004080026.180919-1-david.marchand@redhat.com> From: David Marchand Date: Wed, 5 Oct 2022 21:36:37 +0200 Message-ID: Subject: Re: [PATCH] raw/skeleton: remove useless check To: David Marchand Cc: dev@dpdk.org, Sachin Saxena , Hemant Agrawal X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 4, 2022 at 10:00 AM David Marchand wrote: > > As reported by Coverity, this check is pointless since dev is already > dereferenced earlier. Besides, dev is passed by the rawdev layer and > can't be NULL. > > Note: the issue was probably present before the incriminated commit. > It is unclear why Coverity would start complaining about this now. > > Coverity issue: 380991 > Fixes: 8f1d23ece06a ("eal: deprecate RTE_FUNC_PTR_* macros") > > Signed-off-by: David Marchand Acked-by: Hemant Agrawal Applied, thanks. -- David Marchand