From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2FCD5A0542;
Wed, 5 Oct 2022 17:28:49 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1245540694;
Wed, 5 Oct 2022 17:28:49 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 9614C40143
for <dev@dpdk.org>; Wed, 5 Oct 2022 17:28:47 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1664983727;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=rUr28k3rjabIfJqcTNmKiEdcNakct9GaEsBh+pi+zM0=;
b=c757Txv8+5EijiQXGujSMLLeoYbgl0Z3b2P7mAA8Ci/IuobQSwnIN3/ygkcs7S5ICfff/M
ZYe6iaYwj2+H4fcXVgCLxO+s9oeWe/bA15z/f7EWdypB0UBYTtELhZff0ce7TaaxaeyAcm
hCsIAV3hlxckwFGbHm4VnSaF+3kYmeY=
Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com
[209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
us-mta-665-5lBPgEWfNpiOX3bE2menpw-1; Wed, 05 Oct 2022 11:28:46 -0400
X-MC-Unique: 5lBPgEWfNpiOX3bE2menpw-1
Received: by mail-pg1-f197.google.com with SMTP id
h186-20020a636cc3000000b0045a1966a975so336691pgc.5
for <dev@dpdk.org>; Wed, 05 Oct 2022 08:28:45 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date;
bh=rUr28k3rjabIfJqcTNmKiEdcNakct9GaEsBh+pi+zM0=;
b=Bfr6AAUTe5YWWzW7NeTbe9gyGbwZebi7+Ww5cMDLs8RY6WgESpVHA5enIRJ4HuQSLL
2KiMZHHqN+vjwvjirvMC0/MtVnk9pDqJMEe9dWpuMoCCrsYkwc5ezFULPFb3aC0LjyEk
/MV8Z6Gb1vEEXGuU1mf/XFf60EzVyBNsc+eW8kdue3kU+PBubhARaMZny80n8gNWeSH8
lrNzdyCf5WwrURhnNrGZ9Vo/I7e6GxY17TitUgY2PGRuCIslzwJ8GiiYXSkDCilXPEED
pnEyk8e3yKqjjRD9VokPUq1tUtBvvm5CghQmE1voDR4B7zb86dQT9VIOM50K0/485fl3
bjnw==
X-Gm-Message-State: ACrzQf19anfKw4ITgSIx90Hq+NjUcOsXunSGVrD0N01w8Yt/iw/4dKiN
LlOg3NBL4NR1Oit34ghLFhlP3G1afpLsKxslWem/22zmIa4BPjHReHwB5E2ceqe945esQ8rMq3/
Qoabw9FmsM3khJWMDlCI=
X-Received: by 2002:a17:902:7786:b0:178:48c0:a083 with SMTP id
o6-20020a170902778600b0017848c0a083mr32918332pll.125.1664983725019;
Wed, 05 Oct 2022 08:28:45 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM65c0gZO2I4fDeht73tTy3b9Xgm0sTqG7D3zNLR3xYxFWJCjkw4ptRerQHzGxm9AqnJY8XEyXhfxv8Epu9hBm8=
X-Received: by 2002:a17:902:7786:b0:178:48c0:a083 with SMTP id
o6-20020a170902778600b0017848c0a083mr32918310pll.125.1664983724706; Wed, 05
Oct 2022 08:28:44 -0700 (PDT)
MIME-Version: 1.0
References: <20221005152347.330954-1-ktraynor@redhat.com>
In-Reply-To: <20221005152347.330954-1-ktraynor@redhat.com>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 5 Oct 2022 17:28:33 +0200
Message-ID: <CAJFAV8z07BehM_8pktvDMZvR9eKxBQO4rAmBF3cUr5L8yuFBhA@mail.gmail.com>
Subject: Re: [PATCH] examples/l2fwd-cat: fix build
To: Kevin Traynor <ktraynor@redhat.com>
Cc: dev@dpdk.org, Tomasz Kantecki <tomasz.kantecki@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Wed, Oct 5, 2022 at 5:24 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> <ctype.h> and <errno.h> need to be included for the build
> since they were removed from <rte_common.h>.
>
> ../examples/l2fwd-cat/cat.c: In function =E2=80=98parse_set=E2=80=99:
> ../examples/l2fwd-cat/cat.c:66:16:
> warning: implicit declaration of function =E2=80=98isblank=E2=80=99
> [-Wimplicit-function-declaration]
> 66 | while (isblank(*str))
> | ^~~~~~~
> ../examples/l2fwd-cat/cat.c:18:1:
> note: include =E2=80=98<ctype.h>=E2=80=99 or provide a declaration of =E2=
=80=98isblank=E2=80=99
> 17 | #include "cat.h"
> +++ |+#include <ctype.h>
> 18 |
> ../examples/l2fwd-cat/cat.c:70:15:
> warning: implicit declaration of function =E2=80=98isdigit=E2=80=99
> [-Wimplicit-function-declaration]
> 70 | if ((!isdigit(*str) && *str !=3D '(') || *str =3D=3D '\0'=
)
> | ^~~~~~~
> ../examples/l2fwd-cat/cat.c:70:15:
> note: include =E2=80=98<ctype.h>=E2=80=99 or provide a declaration of =E2=
=80=98isdigit=E2=80=99
> ../examples/l2fwd-cat/cat.c:75:17:
> error: =E2=80=98errno=E2=80=99 undeclared (first use in this function)
> 75 | errno =3D 0;
> | ^~~~~
> ../examples/l2fwd-cat/cat.c:18:1:
> note: =E2=80=98errno=E2=80=99 is defined in header =E2=80=98<errno.h>=E2=
=80=99;
> did you forget to =E2=80=98#include <errno.h>=E2=80=99?
> 17 | #include "cat.h"
> +++ |+#include <errno.h>
>
> Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public header"=
)
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--=20
David Marchand