From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH 2/2] test/lcore: fix build with MSVC
Date: Wed, 11 Jun 2025 10:46:39 +0200 [thread overview]
Message-ID: <CAJFAV8z0AvkMf_JoGprpKDfyz08zN4Qz7RUbhH3fmbu_MUG3RA@mail.gmail.com> (raw)
In-Reply-To: <20250610083643.8466-2-david.marchand@redhat.com>
On Tue, Jun 10, 2025 at 10:37 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> MSVC warns about atomic qualifier:
> ../app/test/test_per_lcore.c(101): error C2220: the following warning is
> treated as an error
> ../app/test/test_per_lcore.c(101): warning C4090: 'function': different
> '_Atomic' qualifiers
>
> Fixes: 7c37826c2b87 ("test/lcore: fix race in per-lcore test")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> app/test/test_per_lcore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_per_lcore.c b/app/test/test_per_lcore.c
> index 9c72f0fa21..e0674b0e70 100644
> --- a/app/test/test_per_lcore.c
> +++ b/app/test/test_per_lcore.c
> @@ -98,7 +98,7 @@ test_per_lcore(void)
> }
>
> /* test if it could do remote launch twice at the same time or not */
> - ret = rte_eal_mp_remote_launch(test_per_lcore_delay, &wait, SKIP_MAIN);
> + ret = rte_eal_mp_remote_launch(test_per_lcore_delay, RTE_PTR_UNQUAL(&wait), SKIP_MAIN);
> if (ret < 0) {
> printf("It fails to do remote launch but it should able to do\n");
> return -1;
Series applied.
--
David Marchand
next prev parent reply other threads:[~2025-06-11 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 8:36 [PATCH 1/2] ci: treat warning as error for MSVC builds in GHA David Marchand
2025-06-10 8:36 ` [PATCH 2/2] test/lcore: fix build with MSVC David Marchand
2025-06-11 8:46 ` David Marchand [this message]
2025-06-12 12:54 ` [PATCH 1/2] ci: treat warning as error for MSVC builds in GHA Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8z0AvkMf_JoGprpKDfyz08zN4Qz7RUbhH3fmbu_MUG3RA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).