From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 560C545B60; Thu, 17 Oct 2024 18:48:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCA364025F; Thu, 17 Oct 2024 18:48:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 385884021E for ; Thu, 17 Oct 2024 18:48:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729183688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=flAcqPbdpBmxLSdMCfRp74rj8NhdCQxu2/J2bnYPgME=; b=DY+nuIVHlBEMbM79JNpSQEeqa0rJKrExivAwXsKUahIetDZWSmwU5obBP45RvEe9PrmqpN bZa9IW++dQUqEOa/kDjX4Go+ptNSnfyMatZlTKIbk6V7cSrP9B7cHdPGTI+nWIfGbl4vgb rMSZrY80w045dbQCGdGayIXvGGXDqk4= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-UUiH9jXIMdOiqrtLKjSsaQ-1; Thu, 17 Oct 2024 12:48:07 -0400 X-MC-Unique: UUiH9jXIMdOiqrtLKjSsaQ-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-539f5f33333so1072267e87.1 for ; Thu, 17 Oct 2024 09:48:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729183686; x=1729788486; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=flAcqPbdpBmxLSdMCfRp74rj8NhdCQxu2/J2bnYPgME=; b=B7+1bgc6NQlTx+XOk3oJlTzPJOoL1QrI3NPaukDrb99zA5tSgdJji+pZlWgr72b/aU eFnJ0wBSqC3UaSG/SVzMKfzDQPZpa+e8FhRaHwVkG5bCvm0CbRp3MZKWvgVQTVpjM3jW nOf6uXQb0995Juw06+Q2SLav2E6gBfF0nYxYA22TkxNuUorbmjq0pjFa+pIdnXFFJnHx SkY4i3CAxB7f1Qr1v1yEdnlgMEmv5QVTJgO9mtTdahSkQcyP5o8MmWiPDe6JdzYon+av NJL0nGoHYv0+QmLuvGxBU9DB51hZlui0u5q2AKG0vaKBaDY/iUPzhqF3wUaAvxWOGM6q sMbg== X-Gm-Message-State: AOJu0YxHSZTNPWrrqzMR+R1m0PyEEdFuI1U22OePAjI5MzL7WzBwUTfQ VKiMv59loJP3VfByCkRCNKuDf6drmKm4mvq9zc8NGe/rTDnqwUIpKNYy+nX+PuNPCtKTwaHK4Kl c7T2iJS2/umwhF+lJ7pYEfqAX5O4Xmvk+ljJR14QpInZbXgSViyt7aLMw2lYak3o6O+LBObqpqc 12Cp0YZn1UPoANVlU= X-Received: by 2002:a05:6512:ad3:b0:539:d428:fbdd with SMTP id 2adb3069b0e04-539e574b00emr10212158e87.53.1729183685887; Thu, 17 Oct 2024 09:48:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVwCMlPAQOij7Qw1bYPC7NQoXO7+o9APy7sv0MrKC7n0zzaL1QhnpVJ8nuNYz61gslcGSJMRNIWi28mXqciTs= X-Received: by 2002:a05:6512:ad3:b0:539:d428:fbdd with SMTP id 2adb3069b0e04-539e574b00emr10212136e87.53.1729183685435; Thu, 17 Oct 2024 09:48:05 -0700 (PDT) MIME-Version: 1.0 References: <20200814173441.23086-1-stephen@networkplumber.org> <20241016202343.190653-1-stephen@networkplumber.org> <20241016202343.190653-6-stephen@networkplumber.org> In-Reply-To: <20241016202343.190653-6-stephen@networkplumber.org> From: David Marchand Date: Thu, 17 Oct 2024 18:47:54 +0200 Message-ID: Subject: Re: [PATCH v26 05/15] eal: do not duplicate rte_init_alert() messages To: Stephen Hemminger Cc: dev@dpdk.org, Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Wed, Oct 16, 2024 at 10:24=E2=80=AFPM Stephen Hemminger wrote: > > The message already goes through logging, and does not need > to be printed on stderr. Message level should be ALERT > to match function name. > > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff > Acked-by: Morten Br=C3=B8rup > Acked-by: Bruce Richardson > Acked-by: Chengwen Feng > --- > lib/eal/freebsd/eal.c | 3 +-- > lib/eal/linux/eal.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c > index d3b40e81d8..7b974608e4 100644 > --- a/lib/eal/freebsd/eal.c > +++ b/lib/eal/freebsd/eal.c > @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) > > static void rte_eal_init_alert(const char *msg) > { > - fprintf(stderr, "EAL: FATAL: %s\n", msg); > - EAL_LOG(ERR, "%s", msg); > + EAL_LOG(ALERT, "%s", msg); > } > > /* Launch threads, called at application init(). */ > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c > index 40d750ed0d..c53a051405 100644 > --- a/lib/eal/linux/eal.c > +++ b/lib/eal/linux/eal.c > @@ -830,8 +830,7 @@ rte_eal_iopl_init(void) > > static void rte_eal_init_alert(const char *msg) > { > - fprintf(stderr, "EAL: FATAL: %s\n", msg); > - EAL_LOG(ERR, "%s", msg); > + EAL_LOG(ALERT, "%s", msg); > } > > /* Any reason why Windows was not changed? I can add the missing bit when applying. --=20 David Marchand