From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 267E0A317C for ; Thu, 17 Oct 2019 17:07:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B81D1E880; Thu, 17 Oct 2019 17:07:00 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id DC1B31E565 for ; Thu, 17 Oct 2019 17:06:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571324818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hTgN01QKTvwnuZL48z6EYrlFFPS6G3l5nYZ9aAMVEeA=; b=G/Z08dU0IJ2n6jxlkNuPE2xUgI4q43UAd77FsahBZrW+M34pDiAS2Nre0BHt+pfNcsHJW/ ZD1DV8G0G0aPMHhD3rmf0cgIwbZhiVcwow+RY1cEFgzrNUw2nX/+fQ/2YFtj+yw2sPYx7R FEl3Ztzd18L0mZQrP4K3g8wtK1Ejojs= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-yr197clNNOuO8cYFfiNavQ-1; Thu, 17 Oct 2019 11:06:56 -0400 Received: by mail-vs1-f72.google.com with SMTP id v17so547030vsp.7 for ; Thu, 17 Oct 2019 08:06:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wnk9PvJmCCPD0IohZcOh8VzPuqSwV4W6KbN3fKDXoNg=; b=cepvggBI7f5kERJ4RDD9W/h/8cEZwAnhKgAS7sZC9q3nQb/fNCJrjIHRkaoBpnvxXN P57CpDUPsYWiIE+2hlzYhOECyaK4ydnFOJ1IhznSSZgzj697zt7ZfUHbErcE5lU7YvIK BimFG71CJCdx3GnsZteVYLl1hCcDub0+LfuvapCQ9C5DDEuGWkUN1wbf74POGLITYYBZ 3qR+oejWLPOx8y8bips7exgL7HAE0Hl6lwySSYimCVbmwfKETsw0G47/JJuqcpB3Xk7Z dnYXE6nMVKtFlcA9+pJ5mMptwnGvx2z17PAvu1IEQBOKWMhSJOL3jy7MttTfnfzk8JBQ NhtQ== X-Gm-Message-State: APjAAAXjE0EYZCnAIpYJOGLuzJnujJR59mLjd8xk+mEAMo9PpV0lC/Mu P1Hyf8zYJY2sDhPBRV981t2DtZu6WXL72HjpMdaS95wtmWNYOXqvTUtYpXx6qSAE/036HBGwv8v emfdYrBfLC23miaPjg7s= X-Received: by 2002:ab0:628f:: with SMTP id z15mr2483665uao.126.1571324815663; Thu, 17 Oct 2019 08:06:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqzlUrsWbNmVkqPpTlwP4emnFYyMe0MePTt8PVsOTrBQoVELnV7G9ASZwcZ5LXYXdMsK6xnuhED84L7Y2uod72I= X-Received: by 2002:ab0:628f:: with SMTP id z15mr2483625uao.126.1571324815154; Thu, 17 Oct 2019 08:06:55 -0700 (PDT) MIME-Version: 1.0 References: <1561911676-37718-1-git-send-email-gavin.hu@arm.com> <1569562904-43950-1-git-send-email-gavin.hu@arm.com> <1569562904-43950-2-git-send-email-gavin.hu@arm.com> In-Reply-To: <1569562904-43950-2-git-send-email-gavin.hu@arm.com> From: David Marchand Date: Thu, 17 Oct 2019 17:06:43 +0200 Message-ID: To: Gavin Hu Cc: dev , nd , Thomas Monjalon , Stephen Hemminger , Hemant Agrawal , Jerin Jacob Kollanukkaran , Pavan Nikhilesh , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , Phil Yang , Steve Capper , dpdk stable X-MC-Unique: yr197clNNOuO8cYFfiNavQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v7 1/7] bus/fslmc: fix the conflicting dmb function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 27, 2019 at 7:42 AM Gavin Hu wrote: > > There are two definitions conflicting each other, for more > details, refer to [1]. > > include/rte_atomic_64.h:19: error: "dmb" redefined [-Werror] > drivers/bus/fslmc/mc/fsl_mc_sys.h:36: note: this is the location of the > previous definition > #define dmb() {__asm__ __volatile__("" : : : "memory"); } Interesting, this means that we have a leftover macro from the arm header that can pollute the namespace. Anyway, this driver is not using the memory barrier api from the EAL. How about simply fixing with? #define __iormb() rte_io_rmb() #define __iowmb() rte_io_wmb() > > The fix is to include the spinlock.h file before the other header files, > this is inline with the coding style[2] about the "header includes". > The fix changes the function to take the argument for arm to be > meaningful. > > [1] http://inbox.dpdk.org/users/VI1PR08MB537631AB25F41B8880DCCA988FDF0@i > VI1PR08MB5376.eurprd08.prod.outlook.com/T/#u This url is broken, there is a trailing i on the first line. > [2] https://doc.dpdk.org/guides/contributing/coding_style.html > > Fixes: 3af733ba8da8 ("bus/fslmc: introduce MC object functions") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Phil Yang --=20 David Marchand