From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 557C5A0A02; Thu, 14 Jan 2021 09:33:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97256140FE5; Thu, 14 Jan 2021 09:32:59 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 0F433140FDF for ; Thu, 14 Jan 2021 09:32:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610613177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vu2XHu78k/LU8wn0QKCB/r3Befmqs0U8mGoATqwy9dA=; b=CUqihl/tpPX4oLxpEUsZStlWAQimGq9FLFvZKYwcDJd8qohEyB0/guFJoOAtjORMh8KvMw WR1nJ0K+tBIxrlZLimP61Zc12VGCJ2TCoCHcvp3zs+08CSsrO7GvDm62KGnV/hXY28uZ/T JIkGiO/HwgmhvcntjDG46tRq2eWPq2E= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-75--JToZVRWPyOLTxlVH3_UMQ-1; Thu, 14 Jan 2021 03:32:55 -0500 X-MC-Unique: -JToZVRWPyOLTxlVH3_UMQ-1 Received: by mail-vk1-f200.google.com with SMTP id h63so2063423vkh.8 for ; Thu, 14 Jan 2021 00:32:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vu2XHu78k/LU8wn0QKCB/r3Befmqs0U8mGoATqwy9dA=; b=i0kWXvsUeAGvHBg/fg50FVQ6z8DmTWWeT/CcxSfim9gdtCrJEG0f86Mtq1psqxIRZh WgOuK1wT5JOrnlZaRBlWtrtOOOMNN7bkufJ7ko1bFV90aN/j+obNwq6IaD9lCAMNdmvs +mr/kKdMFQBr7vcK2+TXrT99bAMhx0xnMkfzsw9/EZ1vaXj0xFNsdIFAkQK6hrSdUB2h nZMdr1XqqHJDqho0Jzlq6wRmZt36WhvG7OigRP3FNCMJ4Xy9Gs3t3X/ySlqStJV793we 4UKaKF8ulTb3EkhsRKcgpBJyHVKoqinAazbj2dg/D+AQR0LsyKURJO974dA6O88yiJOx 3Mlg== X-Gm-Message-State: AOAM5319HXcW/7nXrWHriBetGotPFmUaFV1vCGpxfBME9lE1cB+th9Lx A6Fa6p46wKpqwXoqTK/RJdfM26pAgpY0YjK2t2KGj8sr4SLvy5Uh5BYNmd3hQpOyAT9FbWoz4/w WIzxVhhZVSG05kwDcPsc= X-Received: by 2002:ab0:43a1:: with SMTP id l30mr4857526ual.126.1610613175277; Thu, 14 Jan 2021 00:32:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJz4MX5lOWWThdfuRw1oTUzrXMHAKLIOSo33TurbyJbQAyOZW+em+TlQ7i4UNPMNNEEKSngM4j+jXLMNTODoCVI= X-Received: by 2002:ab0:43a1:: with SMTP id l30mr4857519ual.126.1610613175038; Thu, 14 Jan 2021 00:32:55 -0800 (PST) MIME-Version: 1.0 References: <1610555333-18961-1-git-send-email-michaelba@nvidia.com> <1610555333-18961-2-git-send-email-michaelba@nvidia.com> In-Reply-To: <1610555333-18961-2-git-send-email-michaelba@nvidia.com> From: David Marchand Date: Thu, 14 Jan 2021 09:32:44 +0100 Message-ID: To: Michael Baum Cc: dev , Matan Azrad , Raslan Darawsheh , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix device detach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 13, 2021 at 5:29 PM Michael Baum wrote: > > When mlx4 device is probed, 2 different ethdev ports may be created for > the 2 physical ports of the device. > > Wrongly, when the device is removed, the created ports are not released. > > Close and release the ethdev ports in remove process. > Missing a reference to bug 488. > Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") Odd that it never worked, but if Matan acked, I guess this is ok. > Cc: stable@dpdk.org > > Reported-by: David Marchand > Signed-off-by: Michael Baum > Acked-by: Matan Azrad -- David Marchand