From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE2D4A034C; Thu, 28 Jul 2022 21:46:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D45740151; Thu, 28 Jul 2022 21:46:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7A2ED4014F for ; Thu, 28 Jul 2022 21:46:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659037569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D2G7HeGgaZLydSOwClRQllvvPNlZM9kUtuf/N+A0x3U=; b=iWY/ZSmOU9KRLQ4rUulQ7nrdw4jcyz/bTErUbCGNc8WxbW9XpD2um3j24BL/FY6V1y1Elo f42Iyo8AxpognJFURp+f4OPXpF//YxxUuvVkoattx7ugJSjIxOL6o0u6CkdkKiI3C2W7jY Gf6ktqlBcBqE3R25eC/x+V/Ctbdlawk= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-454-Wa2ua9VTPu2GUPPWXotYOA-1; Thu, 28 Jul 2022 15:46:07 -0400 X-MC-Unique: Wa2ua9VTPu2GUPPWXotYOA-1 Received: by mail-lj1-f199.google.com with SMTP id h21-20020a2e9ed5000000b0025d516572f4so538997ljk.12 for ; Thu, 28 Jul 2022 12:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D2G7HeGgaZLydSOwClRQllvvPNlZM9kUtuf/N+A0x3U=; b=vmTg+XTt2A4uo6gMF/Pyfgrj2zf49wesNqBs19ohTgN76n6p073xFoEpkeer3MV5JI W4tVdx1a1V7aYISpw9ug9yLXVLmOe+K//+52SUk/6LKBPfoCJEBuPYJebf347SKh+W0Q f9S8vxGGJRT7CkGBvGs+h99lpl3HYS2du8itLrFv0fDW8b9gsve8Wli0DkvqQqtQTUTK FnRzVuO0jzLUOqRliy1pyOaP2S5cKCZ7fR5SUWTQSCQ//xplXdYx0wVjc1HhjbWlWTG4 jr+BNKzlsNP6B099aN5oGEs8aRUUSEFS8HepV0qaRlQYnEmJSUppGhxIbZ1zLmZp4QzE C9eA== X-Gm-Message-State: ACgBeo3Zz4/cDYINMh2t3PcLUfG9PFC354xzPpTw584apk6JegJEJMLQ UQGXxEEkauGxiHQRtsYOmzZR42k/huGApOlf0UNHkg0LeQJCqiIg5nJYgh8ip6Dj8GceKXxgEGq r29Qo+/IBu+FBA0NoavA= X-Received: by 2002:a19:ad08:0:b0:48a:d333:c736 with SMTP id t8-20020a19ad08000000b0048ad333c736mr93807lfc.575.1659037566342; Thu, 28 Jul 2022 12:46:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uaEcTGksOMmyrwFUD3iwldLegM8LJHMf3+xE5zIXiwY8cKW0sTSleN6dAF7j3kx67fqEieDE+vIHL6mSR6qsU= X-Received: by 2002:a19:ad08:0:b0:48a:d333:c736 with SMTP id t8-20020a19ad08000000b0048ad333c736mr93798lfc.575.1659037566030; Thu, 28 Jul 2022 12:46:06 -0700 (PDT) MIME-Version: 1.0 References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220728152640.547725-1-david.marchand@redhat.com> <20220728152640.547725-26-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 28 Jul 2022 21:45:55 +0200 Message-ID: Subject: Re: [RFC v3 25/26] dev: provide Bus specific information To: Bruce Richardson Cc: dev , Aman Singh , Yuying Zhang , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 28, 2022 at 7:03 PM Bruce Richardson wrote: > > On Thu, Jul 28, 2022 at 05:26:39PM +0200, David Marchand wrote: > > For diagnostic, it may be useful to provide a description of the device > > with Bus specific information like, for PCI, the vendor and device ID. > > > > Signed-off-by: David Marchand > > --- > Good idea. The idea came from OVS, which provides some PCI specific info in the port status. https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L3655 https://github.com/openvswitch/ovs/blob/master/lib/netdev-dpdk.c#L3690 This is a pretty dumb API (returning a simple string). Maybe something more flexible like returning some TLV-ish structure or a map of strings (like OVS smap) would be better... The function name could be more generic rte_dev_info(), in this case. -- David Marchand