From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7ED1D428CD; Tue, 4 Apr 2023 15:16:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49DF540EF0; Tue, 4 Apr 2023 15:16:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A443D40A7E for ; Tue, 4 Apr 2023 15:16:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680614163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rlgz8AYGLoYC6bXxdpkopAFRuqUWq+JMhHC3FqeS0o8=; b=Yh3xFtnEUiSS5uvK86HY+ZrzA2uKQ9FNt9ff77Q5YFvibsjdNCT3OSv+TyvXz88iwfR+Ag 5qeYUIBTRVUq3whuiA/vEj20Y6z0DfqeMvjndlvDYueI+gMVYESb4656WN8mnENWilZr4c x9waq0blBBnSb96CervyRcZ3WsLtpyw= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-zkruSGsgOHi5TCq8VBoiPw-1; Tue, 04 Apr 2023 09:16:01 -0400 X-MC-Unique: zkruSGsgOHi5TCq8VBoiPw-1 Received: by mail-pf1-f200.google.com with SMTP id i192-20020a6287c9000000b0062a43acb7faso14542520pfe.8 for ; Tue, 04 Apr 2023 06:16:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680614160; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rlgz8AYGLoYC6bXxdpkopAFRuqUWq+JMhHC3FqeS0o8=; b=n3IYQg0kmcx5TosBQ3HZt4Bqdwmlc/8a6pe70TLHptLSaKoEOz5DIct6E1ky2xcg1X D0PeKLCKIbvjYQGbPpkZ1X3sefd0WeNi0WSZDTyQXadyRwRyYppl0mqRDWwda7+mskWd PVx5Sunb88u/AU4yCjlksfi+JieiDFsLmWHf7tLGCdIJxJebIdJQapXtUe5dbMN+lDKU Lu4E2M79iaeJ6RsfWCXHf0RooVlQ6Fa3//xg7LJrAh9rfvmTWMrDa1rKatv2KPPMIv0J yemyc6KI+ct1DlbvLw/+eO6CAIPs5PiHqyoDKinwlO8Q8sudrK5dTsupCIYNhuishkst E/pQ== X-Gm-Message-State: AAQBX9f7Il9THH/24cZ3fBGtH3gCWgohhlPkbXHSqTodYx3ysF7Q18Ed ViwJDhkOs/9F+sq0hjQcCjuDl7TmibsOyG6fg6F/oBnNleix0vBz9+vh74G3s6lyRiz0CKCDFDG MjZwn/leRwaVBEFHVMac= X-Received: by 2002:a05:6a00:1893:b0:62e:154e:d6be with SMTP id x19-20020a056a00189300b0062e154ed6bemr1265343pfh.5.1680614160186; Tue, 04 Apr 2023 06:16:00 -0700 (PDT) X-Google-Smtp-Source: AKy350YCHoG1/FWsDZZ557W0OisNcxGHkRGptmruE+DkPh6zA6AXLWhRumP9Uj94M7dpzNRsVUeyVB4JFjgY0nLuR1M= X-Received: by 2002:a05:6a00:1893:b0:62e:154e:d6be with SMTP id x19-20020a056a00189300b0062e154ed6bemr1265332pfh.5.1680614159851; Tue, 04 Apr 2023 06:15:59 -0700 (PDT) MIME-Version: 1.0 References: <20230329091658.1599349-1-leyi.rong@intel.com> In-Reply-To: <20230329091658.1599349-1-leyi.rong@intel.com> From: David Marchand Date: Tue, 4 Apr 2023 15:15:46 +0200 Message-ID: Subject: Re: [PATCH] eal/x86: remove redundant round to improve performance To: Leyi Rong Cc: mb@smartsharesystems.com, bruce.richardson@intel.com, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 29, 2023 at 11:17=E2=80=AFAM Leyi Rong wr= ote: > > In rte_memcpy_aligned(), one redundant round is taken in the 64 bytes > block copy loops if the size is a multiple of 64. So, let the catch-up > copy the last 64 bytes in this case. Fixes: f5472703c0bd ("eal: optimize aligned memcpy on x86") > > Suggested-by: Morten Br=C3=B8rup > Signed-off-by: Leyi Rong Reviewed-by: David Marchand --=20 David Marchand