From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E9F343034; Fri, 11 Aug 2023 15:40:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 220A942D55; Fri, 11 Aug 2023 15:40:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3A5B640E03 for ; Fri, 11 Aug 2023 15:40:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691761245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1qopgx8jOMqKNhv7jfr8+uaswKwNyXcOq/ImXqeVGi8=; b=jK6l66PYs9Wcbp7vSHVNcBu5tiYR+vUHrroL4WAqBjDnul+tzm+siYp6agtXta7x8Z+gHP VGds4XD4KcRnMpqR9azlGh2nSTuGvypp3LFoh6k2HsnZaUYjrmQfsDbdypAEiIOV9gG8c5 jZgQU5iCQpHGvcSghtlI+/qAXcCuUuY= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-297-Up_uk7MyMLScegfCaqjtug-1; Fri, 11 Aug 2023 09:40:40 -0400 X-MC-Unique: Up_uk7MyMLScegfCaqjtug-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4fe3a1e0329so2108741e87.3 for ; Fri, 11 Aug 2023 06:40:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691761239; x=1692366039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1qopgx8jOMqKNhv7jfr8+uaswKwNyXcOq/ImXqeVGi8=; b=GMCGtp1dkaYgczvnz8oRzkm0h2hKZDwwGvDnqO1fFiKcSTzwKdO46VxH7ucftjFbYP NAeWFuNlPUR55tQbO3OEPY6evHcrsNCuwWjvn6OrguWd2AtnEGyWcJZLQUTomzbPfNo1 6oGsoKvKqQYhuw2xeWKRPXC6+T/K3bawdaoErES1yDJa5C9kyBbkCvZoXjUF7zPaIrzZ e5g6KFfc7LX1NFGIoJQAz5ZTmhUxl7XmoR5Gkn3zYVfC0kqTI5iFZlBlExVBFGvsriFU pBmm85jXVCFStiXwWo/sV0Bb1ff9Nnc9L6PbHuyvqxLWy5zV/PzsCYmeHIUxcTosTF76 nZag== X-Gm-Message-State: AOJu0Yxb9QUN39q2UeunJIxIYdNVFPGv93GC2v3hupb9Gpv6GzZcYMSV m9rhvcOSUFdbFCToP+cr0i+GVSXI1CqEyTLIYKZKIjATF5xvHH4kw9rCxiRdTsWdMxXfR+StvR1 38WtDCdz+LpdVKxOrIjg= X-Received: by 2002:a19:6554:0:b0:4f8:77f1:299a with SMTP id c20-20020a196554000000b004f877f1299amr1212094lfj.42.1691761239401; Fri, 11 Aug 2023 06:40:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwTYnE8n+kD2tYk/OO5ZZrb2OT+GQnva6NhiDA9NNeKUvzppOAR284NQMDaDrnlFFYBMCsx8CT6i3hmSP1WI0= X-Received: by 2002:a19:6554:0:b0:4f8:77f1:299a with SMTP id c20-20020a196554000000b004f877f1299amr1212085lfj.42.1691761239074; Fri, 11 Aug 2023 06:40:39 -0700 (PDT) MIME-Version: 1.0 References: <20230811123833.3114791-1-ciara.power@intel.com> In-Reply-To: <20230811123833.3114791-1-ciara.power@intel.com> From: David Marchand Date: Fri, 11 Aug 2023 15:40:26 +0200 Message-ID: Subject: Re: [PATCH] common/qat: enable gen4 c devices To: Ciara Power Cc: dev@dpdk.org, arkadiuszx.kusztal@intel.com, Kai Ji X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Ciara, On Fri, Aug 11, 2023 at 2:38=E2=80=AFPM Ciara Power = wrote: > > This commit enables QAT 2.0c devices in the > Intel QuickAssist Technology PMD. It is hard to make a link between the commit title "gen 4 c devices", the table below "402xxx" and the release notes "QAT 2.0c". Can you use a single designation of this new device? > > Signed-off-by: Ciara Power > --- > doc/guides/cryptodevs/qat.rst | 4 ++++ > doc/guides/rel_notes/release_23_11.rst | 3 +++ > drivers/common/qat/qat_device.c | 4 ++++ > 3 files changed, 11 insertions(+) > > diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rs= t > index afdfb0bd22..fc5a212d00 100644 > --- a/doc/guides/cryptodevs/qat.rst > +++ b/doc/guides/cryptodevs/qat.rst > @@ -457,6 +457,10 @@ to see the full table) > +-----+-----+-----+-----+----------+---------------+---------------+-= -----------+--------+------+--------+--------+ > | Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx | = 4xxx | 4942 | 2 | 4943 | 16 | > +-----+-----+-----+-----+----------+---------------+---------------+-= -----------+--------+------+--------+--------+ > + | Yes | Yes | Yes | 4 | 402xxx | linux/6.4+ | qat_402xxx | = 4xxx | 4944 | 2 | 4945 | 16 | > + +-----+-----+-----+-----+----------+---------------+---------------+-= -----------+--------+------+--------+--------+ > + | Yes | No | No | 4 | 402xxx | IDZ/ N/A | qat_402xxx | = 4xxx | 4944 | 2 | 4945 | 16 | > + +-----+-----+-----+-----+----------+---------------+---------------+-= -----------+--------+------+--------+--------+ Is there such a kernel module named qat_402xxx upstream? I can only find qat_4xxx. > > * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only wi= th IDZ driver version 4.9.0+ > > diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_note= s/release_23_11.rst > index 4411bb32c1..3bdd51a4a5 100644 > --- a/doc/guides/rel_notes/release_23_11.rst > +++ b/doc/guides/rel_notes/release_23_11.rst > @@ -72,6 +72,9 @@ New Features > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > +* **Added support for QAT 2.0c devices to Intel QuickAssist Technology P= MD.** > + > + * QAT 2.0c (4944) devices are now enabled for QAT. Missing an empty line. > > Removed Items > ------------- > diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_dev= ice.c > index 2675f0d9d1..cbf1e6a988 100644 > --- a/drivers/common/qat/qat_device.c > +++ b/drivers/common/qat/qat_device.c > @@ -50,6 +50,9 @@ static const struct rte_pci_id pci_id_qat_map[] =3D { > { > RTE_PCI_DEVICE(0x8086, 0x4943), > }, > + { > + RTE_PCI_DEVICE(0x8086, 0x4945), > + }, > {.device_id =3D 0}, > }; > > @@ -202,6 +205,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_de= v, > break; > case 0x4941: > case 0x4943: > + case 0x4945: > qat_dev_gen =3D QAT_GEN4; > break; > default: > -- > 2.25.1 > --=20 David Marchand