From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69366A0A05; Wed, 20 Jan 2021 16:05:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51ACE140DA1; Wed, 20 Jan 2021 16:05:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 5351C140D3A for ; Wed, 20 Jan 2021 16:05:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611155156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mTNqGLfHsJYCqrChN0rg/uGYM7nzg8qe1FNe7C1hcGc=; b=F8Y0Pl9tuVNX+bRVcNwZjCEMycg/V1m4KYlcLKOWmR9kEw6rel5NVRsneYZ9cMCl/9CnPf 1WrDiH2JW+uXNFc3jJk/pB/V2OUFv9QfaendySliT5Lv/AJBSXQMRbLFxJh5QYMKU/SCJ/ BLW2SVVP7joEjcxsmTR/WfzAUIVhZQU= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-549-5cK9AWxtNgG0ho6-SD0ZVQ-1; Wed, 20 Jan 2021 10:05:54 -0500 X-MC-Unique: 5cK9AWxtNgG0ho6-SD0ZVQ-1 Received: by mail-vs1-f71.google.com with SMTP id q15so2979032vsk.7 for ; Wed, 20 Jan 2021 07:05:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mTNqGLfHsJYCqrChN0rg/uGYM7nzg8qe1FNe7C1hcGc=; b=fx+FQzYd8ElnavZOqwilj6RE7JvGqWo+dXGUdK4Vw8x62IC5AKYxsu6O33Y3HSJ7JD UH+8WFTuxr12gkL593zHJL2UTJ0N5A/ZKeCeXk+TP38XgHk0eIT/sT76GdqHuGLkQJtg hzbCNk0SgMDzNXeGG1ouRuHRlNmSQZ/715CTowi8UXY4+cR0T3xyyMsAl6apw8FAOVn7 5s+2yTaoa3Xu67PBXKZ6WwibNU4kIy+AxziYyO5ps/t0nMZbH9ME/dTDS7hPlVfib59B xHFOqQ3ntoKV8/eA9pFdGF/MbJ1Wz9LWMJRexwEqElePpk7i+TunxMCdkrjN1S+pO0lO XV7A== X-Gm-Message-State: AOAM530Ef19Aq60zTszj4RuNXI4VVGBiPjEttERkViS3cckK9wGkbDkm 4YooiHlOEszQKtOsEmGOEPcbQkz7a8/mIQMV0NzaeAH/x0DZkNdmoFKuagl+SP9a2L+GHHp8pkY zh9uMo+B8345K2OMxGW4= X-Received: by 2002:a05:6102:21cd:: with SMTP id r13mr6689380vsg.5.1611155153757; Wed, 20 Jan 2021 07:05:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJzsi/EOGDoWDFfw5141Gzm6wKIjJDuixtg3LO3prt67T7g8W5su2zUYWvYZcDXQ7nYQMF8ag+zvslCYtXm2RlI= X-Received: by 2002:a05:6102:21cd:: with SMTP id r13mr6689355vsg.5.1611155153564; Wed, 20 Jan 2021 07:05:53 -0800 (PST) MIME-Version: 1.0 References: <20210114110606.21142-1-bruce.richardson@intel.com> <9b696a65-2012-7ae8-d840-1515f8bf140b@intel.com> <20210115115905.GB1487@bricha3-MOBL.ger.corp.intel.com> <4629518.ttYPrCFMyY@thomas> <20210115145541.GC1487@bricha3-MOBL.ger.corp.intel.com> <20210115145908.GD1487@bricha3-MOBL.ger.corp.intel.com> <20210120143444.GE1406@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20210120143444.GE1406@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Wed, 20 Jan 2021 16:05:42 +0100 Message-ID: To: Bruce Richardson Cc: Thomas Monjalon , Ferruh Yigit , dev , Andrew Rybchenko , Yipeng Wang , Sameh Gobriel , Konstantin Ananyev , Bernard Iremonger , Vladimir Medvedkin , Ori Kam , Honnappa Nagarahalli , Olivier Matz , Cristian Dumitrescu , Adrien Mazarguil Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 20, 2021 at 3:34 PM Bruce Richardson wrote: > On Fri, Jan 15, 2021 at 02:59:08PM +0000, Bruce Richardson wrote: > > On Fri, Jan 15, 2021 at 02:55:41PM +0000, Bruce Richardson wrote: > > > On Fri, Jan 15, 2021 at 03:09:25PM +0100, Thomas Monjalon wrote: > > > I'm honestly fine either way on this (as with directory where > > > implementation lives) - main thing is to have the checking done, rather > > > than ignored. > > > > > And I (obviously) forgot to mention that the existing script is not currently > > integrated into existing build or build-test scripts. I haven't looked into > > how complex this would be, but it would require investigation time. > > I do plan to look into re-using the script and other options around this > area - hopefully in RC2 timeframe. However, to make the patchset rework a > little easier, perhaps the small header fixes could be picked up for ahead > of any rework? I'll merge those fixes hopefully tomorrow. -- David Marchand