From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10960A04FD; Fri, 29 Jul 2022 13:14:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E19B44069C; Fri, 29 Jul 2022 13:14:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 26BC640151 for ; Fri, 29 Jul 2022 13:14:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659093244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wZ+QqqS5H1Ch78op1Yu1TVviXPLpQ1lpQ0LLkDk0J+s=; b=XGnlD+QFQ/SyKh36XqtbbbA/DqR9hdZUGBNEv3nrU6i8goNn1G5PjTDBuxsZ0TZuD5S/FS R+IXvA1YGiJYfevdLs4ZOaXeKgTcrOJ+/PRR/OTl6iC3Te9d3kYavwGdv+/p598cXwUaK0 UJznWFCTLz5vQ7t5xzWY2IhccoMbmIc= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-444-uu3iBKqwP8-zd3H7SNkBQA-1; Fri, 29 Jul 2022 07:14:03 -0400 X-MC-Unique: uu3iBKqwP8-zd3H7SNkBQA-1 Received: by mail-lf1-f71.google.com with SMTP id e10-20020a19674a000000b0047f8d95f43cso1564659lfj.0 for ; Fri, 29 Jul 2022 04:14:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wZ+QqqS5H1Ch78op1Yu1TVviXPLpQ1lpQ0LLkDk0J+s=; b=U9Gfga1foWQgjYZBkM/KbTCKAWehv14a5E0O861Cky+cYV8seeI68U+4u3ZOsmhX/O f/QqNGiVW2tNtI7wA2x4kntnDkohrCEgWtPhg+hxCJPyQyF/bw587c2IIBZpb/11AdxA xJGthiG534aFMSPV14ufSK4u6y++4XV/+lps8L36zfD04kXvsn+6gwEKEzgZt3xS6+AU g1Ty8yW6DYSQmvdqhoI4y7XAypPyCdxrZRtUw2OO4vcpH3DpVEn87WU0f4D+xBOOG4AH iKiszJ4fgTnds8oK1n8L07nOKbP/fd4I04yH5Msix6T3JtbzxYFzg9iE56UpYiflfMVu LM9g== X-Gm-Message-State: AJIora9bPqvwICoWEmJIUQ+hTVcHOe3t0Gtjg+i84bUpE4WKIZhFWgcg 2fwnx3K8UVlnsBiUaUgVlakWw+dfF1C9Ulppgqs7E3iITEMDSIudLJfDBnC/39Bzmj4dJaoFRgn MB8cXGQh8ETBK2xRO77A= X-Received: by 2002:a2e:5746:0:b0:25e:2da3:e244 with SMTP id r6-20020a2e5746000000b0025e2da3e244mr1046824ljd.297.1659093241824; Fri, 29 Jul 2022 04:14:01 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tNMMTWEO9WGX96NYk2h294iF5eMVkT1yhEgtFCHNZUKCVlSvt/FWsvRAm90/OHwxCcor0/jAVcrVOiDHjb2io= X-Received: by 2002:a2e:5746:0:b0:25e:2da3:e244 with SMTP id r6-20020a2e5746000000b0025e2da3e244mr1046805ljd.297.1659093241375; Fri, 29 Jul 2022 04:14:01 -0700 (PDT) MIME-Version: 1.0 References: <20220729095400.774303-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 29 Jul 2022 13:13:49 +0200 Message-ID: Subject: Re: [PATCH] app/test: invoke all telemetry commands To: Bruce Richardson Cc: dev , Chengwen Feng , Aaron Conole , Michael Santana , Ciara Power Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 29, 2022 at 12:20 PM Bruce Richardson wrote: > > +if not is_windows and dpdk_conf.has('RTE_LIB_TELEMETRY') > > + test_args = [dpdk_test] > > + test_args += test_no_huge_args > > + if get_option('default_library') == 'shared' > > + foreach drv:dpdk_drivers > > + test_args += ['-d', drv.full_path().split('.a')[0] + '.so'] > > + endforeach > > Rather than looping for each driver and building a huge cmdline, we should > just be able to pass in the path to the drivers directory, and have DPDK > auto-load all .so files there. Passing in "meson.project_build_root() + > '/drivers'" should probably work. If we want a more correct way to get the > drivers build directory, we can call meson.current_build_dir() when > processing the drivers and save off that value to be reused here. I copied this loop from an existing block added with 207b1c813f39 ("test: fix build without ring PMD"). On the need for this loop at the time... I think it was to avoid loading non .so stuff from a build directory. And you probably handled this with 49b536fc3060 ("eal: load only shared libs from driver plugin directories"). I'll try your suggestion and, if it works, I'll update the other existing test. -- David Marchand