From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCA5AA0A02; Wed, 24 Mar 2021 14:41:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4D6E4067B; Wed, 24 Mar 2021 14:41:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 731684014F for ; Wed, 24 Mar 2021 14:41:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616593315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PEYpXGzwZFldX6LSB/pWnq0GnJgg2tw0TFrTk8WdZp0=; b=hJNzGaGjvwwBvl/XruPg7GAN2qvVpHQ+C+MdytqtKKH87zfDJFfHZqwd84vG8aXR/iZswg ta7yI5CDQ5nqbJId4AkwiILRjF6TAbZ9x6XWQG54Fg+TCwfYODn88SW+VOWPuulvp/xExW 4bQSFIIA2xpoWVo5RUDSFmRwGAF3D0Y= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-486-D-I35nP8NKKHZQ4aRj_Y8A-1; Wed, 24 Mar 2021 09:41:52 -0400 X-MC-Unique: D-I35nP8NKKHZQ4aRj_Y8A-1 Received: by mail-vk1-f197.google.com with SMTP id q15so181508vkd.1 for ; Wed, 24 Mar 2021 06:41:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PEYpXGzwZFldX6LSB/pWnq0GnJgg2tw0TFrTk8WdZp0=; b=J4wY4CQyE9sXNsHDkvhsbXpl3hRinflHvkiDenKkUxVVpmMo8vdqq42txuuns3ncll eJPb/8eJU+cjLXcxuqpLBzU0rA31UDMu7vDMuXzTzmRjoJOmGwbpnFc+uXt+W9V6yqgN /I/Ys+Y3QK7PDig6j8YPqrrE4uOSfDHEFmE+75kT6/xCpj6KDM8dBynhS90d79U7HASS 8GJhyncHWiULY3YpqqBZChP3IEuCIX66KCEJJ6snd0wO7Z6lrs12wHrWh2DdAv5zPWod xDrsrTI3VcSV9crYSzY7CpX0kwOdgJmDIad6Q5X2vlsuuQjIT8VO0G3CPZYR00HTkQAX xKPA== X-Gm-Message-State: AOAM533N9UkzyK5HD6rv3z1OZfbJTpRTwh7tOhKvljbAr0Wr5dQ3asZY l6/w+4lBDyJq/MobUwjyYDgw8NlIawocby87UMyPzP0uVax1dtuitw1N/hQbVnToLFilR+XFviz 2CKBejeTJec1kBfoWQnA= X-Received: by 2002:ac5:ccc4:: with SMTP id j4mr1960870vkn.18.1616593311955; Wed, 24 Mar 2021 06:41:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzT4S8zqB/nQQg5tDM8myWrecv+6GBKTU1jUKWIFbnQ9F/+I4TWjbAxiv9Q8mhv3qrAM0EB+0hQr60dXGTYDDc= X-Received: by 2002:ac5:ccc4:: with SMTP id j4mr1960849vkn.18.1616593311723; Wed, 24 Mar 2021 06:41:51 -0700 (PDT) MIME-Version: 1.0 References: <20210309233116.1934666-1-thomas@monjalon.net> <7775971.yr5XXRrMVS@thomas> <18618477.ONbPRNMBfW@thomas> In-Reply-To: <18618477.ONbPRNMBfW@thomas> From: David Marchand Date: Wed, 24 Mar 2021 14:41:40 +0100 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson , Andrew Rybchenko , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 07/11] eal: add log level help X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 23, 2021 at 7:42 PM Thomas Monjalon wrote: > > > The need for the end-user in the help is different of a debug dump. > > > > The result of rte_log_list_types is a list in link-time order. > > At least it is worth sorting alphabetically for users. > > Yes sorting could be nice. > > > What about default log levels? > > No strong opinion. The default is more or less always the same. "more or less" yes. Looking at your patch that only cares about listing logtypes. Ok, let's leave it at that, with a sorted list. I'll try to revisit this later, as finding/restoring default loglevel during a debugging session is a pain. -- David Marchand