From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2707845600; Fri, 12 Jul 2024 09:57:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED636402AE; Fri, 12 Jul 2024 09:57:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7D1804027F for ; Fri, 12 Jul 2024 09:57:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720771055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QHBx7G/k5UDFQ6HHC/WWR8ufbWgFHeJyd8grhJ8Ws7s=; b=Ymv7pgp8yQZ0oeX32CB+Lw9ak+LWvpA6fSVIG0yqGtcA89Sr/i0QNmFz6IijhHUuEEjg6i H0McsgE2FqnXHKBw0lFNhTcfrnrhCzFweXVDk26klLpqwbWwp/DGqz+pOg/rWtbpg2kXQI 7sPz1iThVXatvGbzo1NXmraRA1DJ6bE= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-t8FZrfFnOeuPBU3HvmmEbA-1; Fri, 12 Jul 2024 03:57:33 -0400 X-MC-Unique: t8FZrfFnOeuPBU3HvmmEbA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2ee8eaccb7aso16200681fa.2 for ; Fri, 12 Jul 2024 00:57:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720771052; x=1721375852; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QHBx7G/k5UDFQ6HHC/WWR8ufbWgFHeJyd8grhJ8Ws7s=; b=v3gzspkFlja2ebV0/vWCX++JYwn18sia58w/aCC8Uq2eOVoKe/F8/VGUuvfgvODAxm EnUE1+8CkLIN6qU/3dpCRxN5yPf8QmzBvEbbew/EGvh2+owIrokXAwgTfZbtRy9ktOD8 vdrmoQU2u6QnNL2iHWm+V3XVh1xI4JRCm47dJkMbXCY2B2rrd2L59EHmBiaZgkQZYGII UMVYAeVVixSJ6bGFILFL0bJbSVNhR7UbcCbtejCuupQLEMb8GtfA6tPHkaqrXt61Jf8G HO+wkHFYzQ2G3+K8Bb9JYl++pgSlFYRwKru9PCems+I8Oz60Fg4QvcrHRx6pxl4KuR+g YAqA== X-Gm-Message-State: AOJu0YwqCTl+6AWSjY3ECb/bfhojRjKYdAJ5p1u7JDmsizteI91yUjuI ueJLHoWg9lwxqpNsQCo6DPLzaimwdTyEycnnbr/YU93dMxiP7UkbBukLqG7ra1jC8G2llVJmvR0 QKUyx//jAXJBKYMw2cdLWz6+DJEcHrti6dZ6pwXx/dgIKAlBMk6EbjlFcj97PzUmBnWECxuMW4I yZzfOOt1wFzjxmCYI= X-Received: by 2002:a2e:9b89:0:b0:2ee:81eb:6bd6 with SMTP id 38308e7fff4ca-2eeb30fd3ebmr62057611fa.23.1720771052259; Fri, 12 Jul 2024 00:57:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExwkq6Su5/EUGv+xCLKjeP9LQHVySxdChztqhjvxZDfHCh4lAjBEYhCK6wNmCvkNMfCwCcQ3gAwFGyqnhJcNg= X-Received: by 2002:a2e:9b89:0:b0:2ee:81eb:6bd6 with SMTP id 38308e7fff4ca-2eeb30fd3ebmr62057491fa.23.1720771051957; Fri, 12 Jul 2024 00:57:31 -0700 (PDT) MIME-Version: 1.0 References: <20240711124436.2383232-1-schalla@marvell.com> In-Reply-To: From: David Marchand Date: Fri, 12 Jul 2024 09:57:20 +0200 Message-ID: Subject: Re: [EXTERNAL] Re: [PATCH v2] net/virtio_user: fix issue with converting cq descriptor IOVA address to VA To: Srujana Challa Cc: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "chenbox@nvidia.com" , Jerin Jacob , Nithin Kumar Dabilpuram , Vamsi Krishna Attunuru X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 11, 2024 at 7:46=E2=80=AFPM Srujana Challa wrote: > > > +963,8 @@ virtio_user_handle_ctrl_msg_split(struct virtio_user_dev *d= ev, > > struct vring *vri > > > (struct virtio_pmd_ctrl *)hdr, dlen, > > > nb_dlen); > > > > > > /* Update status */ > > > - *(virtio_net_ctrl_ack *)virtio_user_iova2virt(vring- > > >desc[idx_status].addr) =3D status; > > > + *(virtio_net_ctrl_ack *) > > > + virtio_user_iova2virt(vring->desc[idx_status].addr, > > > + use_va) =3D status; > > > > Afaics, no need for reindenting. > It crossed 100 line boundary actually. Ah indeed, it is crossed with "use_va". But it won't be the case when passing dev. So please don't touch original indent after applying my suggestion. --=20 David Marchand