From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 042F943B7D; Tue, 5 Mar 2024 11:15:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3A884026B; Tue, 5 Mar 2024 11:15:03 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A33574014F for <dev@dpdk.org>; Tue, 5 Mar 2024 11:15:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709633701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E3tCKH8Qq5SrvYAGf4X9naFlXz/4jy2SQ3NHCe+Ru04=; b=VLiYOC7IdaUf5ggZAk4QUHOAisfhjJ+B5+QiOsOo331AJ2PyLPop+6vHPfXaFW1AUamoHD vY0Kw1Ct+P099BIZYE8gjbzGsJ4KSW5b71asNVrIvXqf4S4Kqfda0MAisOdwpueAZg1guM o78sBEeAP3V5XFITIQel9UZQtcAgCuc= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-258-lFlQtgZGMj-34MXtIYNLDA-1; Tue, 05 Mar 2024 05:14:59 -0500 X-MC-Unique: lFlQtgZGMj-34MXtIYNLDA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5132be4b24aso2353713e87.1 for <dev@dpdk.org>; Tue, 05 Mar 2024 02:14:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709633698; x=1710238498; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E3tCKH8Qq5SrvYAGf4X9naFlXz/4jy2SQ3NHCe+Ru04=; b=hhTDf+jylda37IAwTSzhwPYZvDMzIfdCPMns+7pJVTgx6NSg6dvPKc2B1PHaFrU+dK SKG40f8G0VGH/Z/7nJR96BgFcZ09U5je4/S9w9TmCIV5e+pk25v0Mxo8ACZ3wqNk8BY0 rsEkrOL5mWt6N56VVgU7IAzG6kSnaFfREVIkbFDXH6wfpMb3BjG/oAR+wqhqkMrdm64h HtH8uDmwIgVrK27rxF3axRiWPqXBj69/qazjZ/eA6cQ131YZZD5ksuuOJpBaBNw7j8a0 4EHkrUDsxh2zlarTNgn8hL7GsJykgRILA5jkEmkyn6jI7esI/Heg9Em9R79b4z5RK1XD fBUA== X-Gm-Message-State: AOJu0YylnsAtgZvIIzIS9aqHyng0iP0l8TQuaJErsUOzlwH+xrBFdEih 63kvOf3Qy8LmMH9e1qJxj38gzaNXOStSoag33NBgkfnl/jHRemG3tWA106HF/Pg2fasDosCqT3s +llmNCPqcu1uAiiSVufFsQLQCA9D9MF+Mvm1/itQKhid9MwesLoAxK/WtFko6/6wSY7HswgyL8m nL+G/1LangIElBPKM= X-Received: by 2002:a05:6512:4002:b0:513:19ce:cbde with SMTP id br2-20020a056512400200b0051319cecbdemr603119lfb.22.1709633698312; Tue, 05 Mar 2024 02:14:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYeKBqmjPcaYc8gQv9uVgV9/tbwIneejNhpstFrXvtO7i0K1UDcO6s50O4hZgfoiKP7zvhKKMUYAqkPuya824= X-Received: by 2002:a05:6512:4002:b0:513:19ce:cbde with SMTP id br2-20020a056512400200b0051319cecbdemr603106lfb.22.1709633698015; Tue, 05 Mar 2024 02:14:58 -0800 (PST) MIME-Version: 1.0 References: <20240304184508.89956-1-stephen@networkplumber.org> In-Reply-To: <20240304184508.89956-1-stephen@networkplumber.org> From: David Marchand <david.marchand@redhat.com> Date: Tue, 5 Mar 2024 11:14:45 +0100 Message-ID: <CAJFAV8z3978uVSukPu2koomqJ0Sjgh0_6UcUx+TvtZ1RNRe6Cw@mail.gmail.com> Subject: Re: [PATCH] hash: make gfni stubs inline To: Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>, Yipeng Wang <yipeng1.wang@intel.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, Mar 4, 2024 at 7:45=E2=80=AFPM Stephen Hemminger <stephen@networkplumber.org> wrote: > > This reverts commit 07d836e5929d18ad6640ebae90dd2f81a2cafb71. > > Tyler found build issues with MSVC and the thash gfni stubs. > The problem would be link errors from missing symbols. Trying to understand this link error. Does it come from the fact that rte_thash_gfni/rte_thash_gfni_bulk declarations are hidden under RTE_THASH_GFNI_DEFINED in rte_thash_gfni.h? If so, why not always expose those two symbols unconditionnally and link with the stub only when ! RTE_THASH_GFNI_DEFINED. --=20 David Marchand