From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 599B3A0530; Wed, 12 Feb 2020 10:39:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E90C2BE9; Wed, 12 Feb 2020 10:39:37 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id EF6B1262E for ; Wed, 12 Feb 2020 10:39:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581500375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dFGmKXwba7rGUG5c0vTn+77M3MO6gI6OPVBp+NxRFp4=; b=O8kVXBcDH8wszU7GIQPyT0xp9u0udPFefPDvz856sSN+QJBTjk3RM99DeYe/Ov9vQ4jxV8 CZ7Mal3wX8EiWz5pqH/wgLI+PlIqjAHu6oKxzOSvYQj0AhPrhHNk7n8gK+Xzr6hDMBK+QQ kZXNCJLB8OBQDTiHmCglrg7JnNJJfow= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-X102oWehNK-SdCt8r87U5g-1; Wed, 12 Feb 2020 04:39:33 -0500 Received: by mail-vs1-f72.google.com with SMTP id g12so129823vsb.11 for ; Wed, 12 Feb 2020 01:39:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q96fPveJUineUV6ChIe4yp2w5ZqDWB6b7ljaGwBzyZs=; b=rQVVxi8wbTSFdaXjQQJ8x3BSFghppv2D66UvmQnKsdSJ5dNENwoUuDToTnRz7SlRwk NDTn4UdPkam6izMzu2SXtxXS60Eo9x5wJvkEeLIOqRJqS0X0hWySHvwQmUOBSlzfXK+s G2QWp773LD+UyktuK6iDOojsoBDO1ZI/cCg3ZE4Bld5QwhRz0W2eJ4A5sDzPBA14Iw2M t+lTRwItO0rwvncuZNuG/KNU4mRrpJGddPAVz5v8bjStxeA4wriXxTp49pwWVKFEgUth 4ls6ohFcKQ/3m3GJaaMx7EzpVxdvorNZob0Xrn9A7z6oKVu1/kqjRZds6wbRTp1YDEi9 yhnQ== X-Gm-Message-State: APjAAAUEBgZx0FRjVrUXaETEDOtwMQnNr7MtI40eIFfr9Y1Wax28lPQt 8BfdSOeb401QYIVJu7ZbZ6BTFeWP05+ChbiUVw3wV9UNTuWKkA3CInr5eee+85D7uajwWrs5w59 knyRKqGPQoUSL+Qwhnb8= X-Received: by 2002:a67:905:: with SMTP id 5mr11814504vsj.105.1581500372996; Wed, 12 Feb 2020 01:39:32 -0800 (PST) X-Google-Smtp-Source: APXvYqz2SeDmOTeM01H9qjtXFJP5fcKdrWvFyc3y9SN1rj2wxz/R4nZaBC5Gp7H/3hLDrhI0GBJl/cLue7HZe1V1fXc= X-Received: by 2002:a67:905:: with SMTP id 5mr11814493vsj.105.1581500372655; Wed, 12 Feb 2020 01:39:32 -0800 (PST) MIME-Version: 1.0 References: <20200211235724.2970097-1-thomas@monjalon.net> <20200211235724.2970097-2-thomas@monjalon.net> In-Reply-To: <20200211235724.2970097-2-thomas@monjalon.net> From: David Marchand Date: Wed, 12 Feb 2020 10:39:21 +0100 Message-ID: To: Thomas Monjalon Cc: dev X-MC-Unique: X102oWehNK-SdCt8r87U5g-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] config: deduplicate options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 12, 2020 at 12:57 AM Thomas Monjalon wrot= e: > > Some config options are overwritten with the same value > as the one inherited from its template parent. > Such duplicates which have no meaningful comments are removed. > > Signed-off-by: Thomas Monjalon > --- > config/common_armv8a_linux | 2 -- > config/common_linux | 6 ------ > config/defconfig_arm-armv7a-linuxapp-gcc | 9 --------- > config/defconfig_arm64-octeontx2-linuxapp-gcc | 4 ---- > config/defconfig_arm64-stingray-linuxapp-gcc | 2 -- > config/defconfig_arm64-thunderx-linuxapp-gcc | 1 - > 6 files changed, 24 deletions(-) > > diff --git a/config/common_armv8a_linux b/config/common_armv8a_linux > index 433e66c7d8..020f8f006c 100644 > --- a/config/common_armv8a_linux > +++ b/config/common_armv8a_linux > @@ -41,5 +41,3 @@ CONFIG_RTE_LIBRTE_PMD_IOAT_RAWDEV=3Dn > # NXP PFE PMD Driver > # > CONFIG_RTE_LIBRTE_PFE_PMD=3Dy > - > -CONFIG_RTE_SCHED_VECTOR=3Dn > diff --git a/config/common_linux b/config/common_linux > index 583efadc7d..816810671a 100644 > --- a/config/common_linux > +++ b/config/common_linux > @@ -66,9 +66,3 @@ CONFIG_RTE_LIBRTE_HINIC_PMD=3Dy > # Hisilicon HNS3 PMD driver > # > CONFIG_RTE_LIBRTE_HNS3_PMD=3Dy > - > -# > -# Compile PMD for Intel FPGA raw device > -# To compile, CONFIG_RTE_EAL_VFIO should be enabled. > -# > -CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=3Dn > diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_= arm-armv7a-linuxapp-gcc > index 6ac7f47e47..9ecc2a526c 100644 > --- a/config/defconfig_arm-armv7a-linuxapp-gcc > +++ b/config/defconfig_arm-armv7a-linuxapp-gcc > @@ -30,14 +30,7 @@ CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=3Dn > # KNI is not supported on 32-bit > CONFIG_RTE_LIBRTE_KNI=3Dn > > -# PCI is usually not used on ARM > -CONFIG_RTE_EAL_IGB_UIO=3Dn > - > -# fails to compile on ARM > -CONFIG_RTE_SCHED_VECTOR=3Dn > - > # cannot use those on ARM > -CONFIG_RTE_KNI_KMOD=3Dn > CONFIG_RTE_LIBRTE_ARK_PMD=3Dn > CONFIG_RTE_LIBRTE_EM_PMD=3Dn > CONFIG_RTE_LIBRTE_IGB_PMD=3Dn > @@ -47,9 +40,7 @@ CONFIG_RTE_LIBRTE_ENIC_PMD=3Dn > CONFIG_RTE_LIBRTE_FM10K_PMD=3Dn > CONFIG_RTE_LIBRTE_I40E_PMD=3Dn > CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dn > -CONFIG_RTE_LIBRTE_MLX4_PMD=3Dn > CONFIG_RTE_LIBRTE_VMXNET3_PMD=3Dn > -CONFIG_RTE_LIBRTE_BNX2X_PMD=3Dn > CONFIG_RTE_LIBRTE_QEDE_PMD=3Dn > CONFIG_RTE_LIBRTE_SFC_EFX_PMD=3Dn > CONFIG_RTE_LIBRTE_AVP_PMD=3Dn > diff --git a/config/defconfig_arm64-octeontx2-linuxapp-gcc b/config/defco= nfig_arm64-octeontx2-linuxapp-gcc > index 7687dbec8d..7cfb81872c 100644 > --- a/config/defconfig_arm64-octeontx2-linuxapp-gcc > +++ b/config/defconfig_arm64-octeontx2-linuxapp-gcc > @@ -6,7 +6,6 @@ > > CONFIG_RTE_MACHINE=3D"octeontx2" > > -CONFIG_RTE_CACHE_LINE_SIZE=3D128 > CONFIG_RTE_MAX_NUMA_NODES=3D1 > CONFIG_RTE_MAX_LCORE=3D24 > CONFIG_RTE_ARM_FEATURE_ATOMICS=3Dy > @@ -15,8 +14,5 @@ CONFIG_RTE_ARM_FEATURE_ATOMICS=3Dy > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=3Dn > CONFIG_RTE_LIBRTE_VHOST_NUMA=3Dn > > -# Recommend to use VFIO as co-processors needs SMMU/IOMMU > -CONFIG_RTE_EAL_IGB_UIO=3Dn > - > # Max supported NIX LFs > CONFIG_RTE_MAX_VFIO_GROUPS=3D128 > diff --git a/config/defconfig_arm64-stingray-linuxapp-gcc b/config/defcon= fig_arm64-stingray-linuxapp-gcc > index 7b33aa7afb..2a6f6cee28 100644 > --- a/config/defconfig_arm64-stingray-linuxapp-gcc > +++ b/config/defconfig_arm64-stingray-linuxapp-gcc > @@ -5,7 +5,6 @@ > #include "defconfig_arm64-armv8a-linux-gcc" > > # Broadcom - Stingray > -CONFIG_RTE_MACHINE=3D"armv8a" > CONFIG_RTE_ARCH_ARM_TUNE=3D"cortex-a72" > > # Doesn't support NUMA > @@ -13,4 +12,3 @@ CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=3Dn > CONFIG_RTE_LIBRTE_VHOST_NUMA=3Dn > > CONFIG_RTE_EAL_IGB_UIO=3Dy > -CONFIG_RTE_KNI_KMOD=3Dn > diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defcon= fig_arm64-thunderx-linuxapp-gcc > index a52f066510..946906b67a 100644 > --- a/config/defconfig_arm64-thunderx-linuxapp-gcc > +++ b/config/defconfig_arm64-thunderx-linuxapp-gcc > @@ -6,7 +6,6 @@ > > CONFIG_RTE_MACHINE=3D"thunderx" > > -CONFIG_RTE_CACHE_LINE_SIZE=3D128 > CONFIG_RTE_USE_C11_MEM_MODEL=3Dn > CONFIG_RTE_MAX_NUMA_NODES=3D2 > CONFIG_RTE_MAX_LCORE=3D96 > -- > 2.25.0 > We have some duplications (RTE_SCHED_VECTOR and RTE_EAL_IGB_UIO) on the meson side, but this patch lgtm. Acked-by: David Marchand --=20 David Marchand