From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F686429E9; Tue, 25 Apr 2023 11:10:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC5B6410EA; Tue, 25 Apr 2023 11:10:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 47688410DD for ; Tue, 25 Apr 2023 11:10:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682413843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/xNHvkC7qXuswMVtVN6RVR+sdVzzuPa2n7QTu48/Fwg=; b=NRO57qj8sYX/kNCzwASTIKS8d1jAj2/Jl4rraaraSYlhkCkYAdDbY2qI0+ULO6YneQDsrf kb0pK4sU29iCBczu8RN/lA1O9vRfr0p0KKw3HLD5G0WiI1x0qADiDxPwArzGVAzcQl/Ta7 TRjr2r1FMoBUyyMBdtIRiWkGFeT/6SM= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-149-WIdjrWcmO2mWXTCFQ10YhQ-1; Tue, 25 Apr 2023 05:10:42 -0400 X-MC-Unique: WIdjrWcmO2mWXTCFQ10YhQ-1 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-1a697b1a71aso62579285ad.1 for ; Tue, 25 Apr 2023 02:10:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682413841; x=1685005841; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/xNHvkC7qXuswMVtVN6RVR+sdVzzuPa2n7QTu48/Fwg=; b=iLtupEIErOowAGL291YuJQsLoCJ2kjBGF5Pdd2VZtLSwq+ReoilSvwMVrbT689CDTM 7JrH2lAKD5CQxnXQL89h67kAZfBzCgAvsvPwGKHh/jJUFR8+kBf7kbwemvoMEyHNL3XM eVdewcEQAe5TD68IjiiR1/WOzvnMa/P7oqK6ULQaqWTHKYKvSgT77ydkXqKR+DPayBzr ZDi9QcHBBYjCBGj4b//wT6yojPFMzAcgR4aUGyumXrVmWCebk5EHk2NgDbwIosDnUlze bONQkbG7/JEO0zXWIqoMhcDngcNdaZfB2E/ImS+wK/TeQ994Ny9o3AgmL9Rh4BIh8Xto cjXQ== X-Gm-Message-State: AAQBX9f8Ia141FBJ9IoAZNdiCVBXIgaSeckqxck3xfdF+Uf08CAcxcm6 pXLnACZ06JG5bgHyOIqjqKf8Gj/AUN3M7QhaI/9T/XYGkSO8UcxT3kv6Wo8i53ir3sDvfOqU1ya xmuKLdTku25wv+pHG200= X-Received: by 2002:a17:902:c78a:b0:19c:d309:4612 with SMTP id w10-20020a170902c78a00b0019cd3094612mr14637065pla.6.1682413841375; Tue, 25 Apr 2023 02:10:41 -0700 (PDT) X-Google-Smtp-Source: AKy350Z69ymZpJ18U5FaIuFyVv1YS2CveuMAJG8Jpe26RqrJaiEAj6Uw2nEddWXFspoEBgjr2zhgg3s/qFzA6gvY5ck= X-Received: by 2002:a17:902:c78a:b0:19c:d309:4612 with SMTP id w10-20020a170902c78a00b0019cd3094612mr14637052pla.6.1682413841138; Tue, 25 Apr 2023 02:10:41 -0700 (PDT) MIME-Version: 1.0 References: <1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com> <1677773902-5167-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1677773902-5167-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Tue, 25 Apr 2023 11:10:30 +0200 Message-ID: Subject: Re: [PATCH v2 00/17] use __atomic operations returning previous value To: Tyler Retzlaff Cc: dev@dpdk.org, Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, bruce.richardson@intel.com, mb@smartsharesystems.com, Ruifeng.Wang@arm.com, maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 2, 2023 at 5:18=E2=80=AFPM Tyler Retzlaff wrote: > > This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with > __atomic_fetch_{add,and,or,sub,xor} intrinsics. The latter omits generat= ion > of code that is only needed if the returned value is actually used. > > Additionally, this change simplifies adapting dpdk to standard atomics > planned for 23.07 since __atomic_fetch_xxx can be trivially replaced with > atomic_fetch_xxx whereas __atomic_xxx_fetch has no standard equivalent. > > > v2: > net/iavf patch had one incorrect change to __atomic_fetch_sub > from __atomic_sub_fetch the new value was assigned to a variable > on the previous line so revert the change from the patch. > > Series-acked-by: Morten Br=C3=B8rup > > Tyler Retzlaff (17): > vhost: use previous value atomic fetch operations > telemetry: use previous value atomic fetch operations > stack: use previous value atomic fetch operations > eal: use previous value atomic fetch operations > distributor: use previous value atomic fetch operations > bbdev: use previous value atomic fetch operations > examples/vhost: use previous value atomic fetch operations > net/virtio: use previous value atomic fetch operations > net/octeontx: use previous value atomic fetch operations > net/mlx5: use previous value atomic fetch operations > net/iavf: use previous value atomic fetch operations > net/cxgbe: use previous value atomic fetch operations > drivers/event: use previous value atomic fetch operations > dma/skeleton: use previous value atomic fetch operations > drivers/common: use previous value atomic fetch operations > app/test: use previous value atomic fetch operations > test-eventdev: use previous value atomic fetch operations > > app/test-eventdev/test_order_common.h | 2 +- > app/test/test_lcores.c | 2 +- > app/test/test_service_cores.c | 4 ++-- > drivers/common/cnxk/roc_nix_inl_dev.c | 2 +- > drivers/common/mlx5/mlx5_common_mr.c | 2 +- > drivers/common/mlx5/mlx5_common_utils.c | 10 +++++----- > drivers/common/mlx5/mlx5_malloc.c | 16 ++++++++-------- > drivers/dma/skeleton/skeleton_dmadev.c | 2 +- > drivers/event/cnxk/cnxk_eventdev_selftest.c | 12 ++++++------ > drivers/event/cnxk/cnxk_tim_worker.h | 6 +++--- > drivers/event/dsw/dsw_event.c | 6 +++--- > drivers/event/octeontx/timvf_worker.h | 6 +++--- > drivers/net/cxgbe/clip_tbl.c | 2 +- > drivers/net/cxgbe/cxgbe_main.c | 12 ++++++------ > drivers/net/cxgbe/l2t.c | 4 ++-- > drivers/net/cxgbe/mps_tcam.c | 2 +- > drivers/net/cxgbe/smt.c | 4 ++-- > drivers/net/iavf/iavf_vchnl.c | 4 ++-- > drivers/net/mlx5/linux/mlx5_verbs.c | 2 +- > drivers/net/mlx5/mlx5_flow.c | 6 +++--- > drivers/net/mlx5/mlx5_flow_dv.c | 4 ++-- > drivers/net/mlx5/mlx5_flow_flex.c | 6 +++--- > drivers/net/mlx5/mlx5_flow_hw.c | 10 +++++----- > drivers/net/mlx5/mlx5_flow_meter.c | 20 ++++++++++--------= -- > drivers/net/mlx5/mlx5_rx.h | 2 +- > drivers/net/octeontx/octeontx_ethdev.c | 2 +- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +- > examples/vhost/main.c | 12 ++++++------ > examples/vhost/virtio_net.c | 4 ++-- > lib/bbdev/rte_bbdev.c | 2 +- > lib/distributor/rte_distributor.c | 2 +- > lib/eal/common/eal_common_trace.c | 8 ++++---- > lib/eal/common/rte_service.c | 8 ++++---- > lib/eal/ppc/include/rte_atomic.h | 16 ++++++++-------- > lib/stack/rte_stack_lf_c11.h | 2 +- > lib/telemetry/telemetry.c | 6 +++--- > lib/vhost/virtio_net.c | 6 +++--- > 37 files changed, 109 insertions(+), 109 deletions(-) The changes are systematic and lgtm. Series applied, thanks Tyler. --=20 David Marchand