From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A24643CA0; Wed, 13 Mar 2024 15:46:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1E10406BC; Wed, 13 Mar 2024 15:46:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D1A6C402B8 for ; Wed, 13 Mar 2024 15:46:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710341177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+JDo99t+z42CrAgE51A+Ndy+hiwnT6wuuMqFEWhUKi0=; b=VZJ3gjBGCyxNvT6PcOCnHHnDHkGRarHTFQB45isV5ZkZgZele1EbxpvnfWRCcEMAZaRhP6 nD6N9lmVjnOC2baNUPR0XyJDf/GvAmlvdv5/nfr3uYAc3CoIIUQy8PoPQfQaC9JcXB5C0f Kwev100HdjO5dJ22NTg/cgLw2nRJy80= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-p1btEX2bMQKkeUcLz62T2A-1; Wed, 13 Mar 2024 10:46:14 -0400 X-MC-Unique: p1btEX2bMQKkeUcLz62T2A-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d2e9f76b2cso40128641fa.1 for ; Wed, 13 Mar 2024 07:46:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710341172; x=1710945972; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+JDo99t+z42CrAgE51A+Ndy+hiwnT6wuuMqFEWhUKi0=; b=NnH69r8IvY7C2XySs3BVUi08/RJvxw6SMLVLqCnIVtKpLdevWZLUu51Ho1kV7gDuJ9 xlwXI2jmClhVFKHdRcqXCYvhN6b9ux1hKU9JuHizy483EsoP1AOWCtQMDQ+P/oufJ56D Ckobnyh/thprE1AnSGkJKSCU/U4kv7p1MRzkecONHmqZ+vR13mQyPTY/4UvtDLA5nj6D IsboifGJU5x1D9M5VTpB/qVxVEKkrqUReg5M2A8Wul9aBseY9fYOrvj7PRJS04SKycqM eeFZf6FIrSPxgs4hDmm2j88PRRdiP8J6BBLZkdym79E3OjMtVfIbRL/bi32i3sERWYx/ gPfg== X-Gm-Message-State: AOJu0YwDXKvNBh/V+CDSrvDDQ9h+r6ZUOqLGfh/ApMlwmmnlUUDO/y05 mYyrSxOQdlp+kxgeL7/ataK676CwmbXlkWlfH9ge+gsOQQYlA3tJC7CbRxEJ6e5f193nT2FwoZs pOHv5n7WJgkJgdLAjEjP6GEamoPyoneDWU3HCnOCDo0HllAQinnxA7sEi7mStblM+sbY8x/T22I uVp9KnoTQePlkKc4g= X-Received: by 2002:a2e:9c10:0:b0:2d2:65b9:b420 with SMTP id s16-20020a2e9c10000000b002d265b9b420mr2414979lji.1.1710341172563; Wed, 13 Mar 2024 07:46:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/PkRTIF6U0a2mEyGHajgejYEBoDPwuJkL90uJJauDP1y0B8o5dHYhAPz9BjbrjXZG+yxVy5CFnNvmsakH7Rc= X-Received: by 2002:a2e:9c10:0:b0:2d2:65b9:b420 with SMTP id s16-20020a2e9c10000000b002d265b9b420mr2414954lji.1.1710341172098; Wed, 13 Mar 2024 07:46:12 -0700 (PDT) MIME-Version: 1.0 References: <20240307103443.609960-1-david.marchand@redhat.com> In-Reply-To: <20240307103443.609960-1-david.marchand@redhat.com> From: David Marchand Date: Wed, 13 Mar 2024 15:45:59 +0100 Message-ID: Subject: Re: [PATCH] vhost: fix vring addr update with vDPA To: David Marchand Cc: dev@dpdk.org, ssimma@nvidia.com, Maxime Coquelin , Chenbo Xia , Eelco Chaudron X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 7, 2024 at 11:35=E2=80=AFAM David Marchand wrote: > > For vDPA devices, vq are not locked once the device has been configured > at runtime. > > On the other hand, we need to hold the vq lock to evaluate vq->access_ok, > invalidate vring addresses and translate them. > > Move vring address update earlier and, when vDPA is configured, skip part= s > which expect lock to be taken. > > Bugzilla ID: 1394 > Fixes: 741dc052eaf9 ("vhost: annotate virtqueue access checks") > > Signed-off-by: David Marchand Applied, thanks. --=20 David Marchand