From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D848EA00BE; Thu, 31 Oct 2019 08:58:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5AD9E1C1EB; Thu, 31 Oct 2019 08:58:45 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 0C4B11C1D7 for ; Thu, 31 Oct 2019 08:58:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572508723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9sfLdUyJmpF3RtuXtvHKaLrIrxOdKab6K4jXCqwZbWM=; b=KEPQ6ky4b4FiJwrihVA1khp13rbFg7yP4cmIeuErctD7p0mu/GI1ums+PCuU/1YtSvgi5i GtqT/bLQ7TeFmUq0h2wDzWtx7T1woOkhVwdfS3lsJLNkivJIHNLRCqdoDF/Yi1VE96OdPF eyWXFtEnEEtrTSVQ1gWL1uo/OdsNpoU= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-82-2KFPXZBONXqmge63tW2Q5w-1; Thu, 31 Oct 2019 03:58:41 -0400 Received: by mail-ua1-f69.google.com with SMTP id n21so402165uaq.14 for ; Thu, 31 Oct 2019 00:58:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iJidq2wDP0OOYTHo/ii12rvCsmmedN8x0odjAGePax0=; b=Czl4l6Au4bE/oWtUHJXgGBzupmCZPvqVtkAxYdwEQ6HFck/COLFI6GvkxfKxV52xUV DJbf2DcbqKx3MhnW9V1SKYq5/ZlmaMfX9H6svqUMNNxvym3bbpYu6wcthafVVTje/Sbw i1EeccXd91T5EbYIBRwD/hYQfPgQemlQQvquPyn7skXQitLa4JrHfyGHHV93zCSoRZLF RpAjt9UpXVao8xUuc+P9aG3QN0ahuIYLWq6kPftLGbwwBRJvjTd4QQ50b3hLxHLVCnVy VW7rLKPBQzBaV9rhouz8jCl0JsoDUltejT5nkUTSFCsls8VLYFQHREXN8jhEQOnPjT0V q3VQ== X-Gm-Message-State: APjAAAXdxWdyIYHYLxzT9EAZ01CWLQhaoOHFmjfPtG+rreyfUixDjpnu m0uF/R0+Nop0naPi7kfp1jLptVxvMX/60BhbZQONOVxC2KOl8SlGvuXaTWw9s7QQWYNLGDuuJ1M 9o81Z56udZD8O0uKXdhw= X-Received: by 2002:a05:6102:d8:: with SMTP id u24mr2064625vsp.180.1572508721196; Thu, 31 Oct 2019 00:58:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUhBvq1rpZ0Rv71UR365klVZEmwRbbuyCmkM+h8kXW8Zzyyk4FFWOIXnBH4ecw8btpz3iSHTMgFmukLObhskI= X-Received: by 2002:a05:6102:d8:: with SMTP id u24mr2064608vsp.180.1572508720906; Thu, 31 Oct 2019 00:58:40 -0700 (PDT) MIME-Version: 1.0 References: <20191017111628.5396-1-reshma.pattan@intel.com> <20191025153808.31753-1-reshma.pattan@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A4E6F3D@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A4E6F3D@irsmsx110.ger.corp.intel.com> From: David Marchand Date: Thu, 31 Oct 2019 08:58:29 +0100 Message-ID: To: "Pattan, Reshma" Cc: "Rao, Nikhil" , dev , dpdk stable , Chas Williams , "Richardson, Bruce" , Stephen Hemminger X-MC-Unique: 2KFPXZBONXqmge63tW2Q5w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/test: fix build when ring PMD is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 29, 2019 at 10:36 AM Pattan, Reshma w= rote: > > > > > -----Original Message----- > > From: David Marchand > > Sent: Sunday, October 27, 2019 8:48 AM > > To: Pattan, Reshma > > Cc: dev ; dpdk stable ; Rao, Nikhil > > ; Chas Williams ; Richardson, Bruc= e > > ; Stephen Hemminger > > > > Subject: Re: [dpdk-stable] [PATCH v3] app/test: fix build when ring PMD= is > > disabled > > > > On Fri, Oct 25, 2019 at 5:38 PM Reshma Pattan > > wrote: > > > > > > 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter uni= t > > > tests are dependent on ring PMD, so compile those tests only when rin= g > > > PMD is enabled else ignore. > > > > > > 2)get rid of make file error which was added by bond unit test for > > > ring PMD disabled case which is not necessary. > > > > > > Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") > > > Fixes: fdeb30fa71 ("test/bitrate: add unit tests for bitrate library"= ) > > > Fixes: 1e3676a06e ("test/latency: add unit tests for latencystats > > > library") > > > Fixes: 46cf97e4bb ("eventdev: add test for eth Tx adapter") > > > Fixes: d23e09e0ef ("app/test: link with ring pmd when needed") > > > > > > CC: stable@dpdk.org > > > CC: Nikhil Rao > > > CC: Chas Williams > > > CC: Bruce Richardson > > > CC: Stephen Hemminger > > > > > > Reported-by: Stephen Hemminger > > > Signed-off-by: Reshma Pattan > > > --- > > > v3: add missing test event_eth_tx_adapter_autotest. > > > > https://travis-ci.com/ovsrobot/dpdk/jobs/249598391 > > > > 79/83 DPDK:fast-tests / event_eth_tx_adapter_autotest FAIL 0.12 s > > (exit status 255 or signal 127 SIGinvalid) > > --- command --- > > DPDK_TEST=3D'event_eth_tx_adapter_autotest' > > /home/travis/build/ovsrobot/dpdk/build/app/test/dpdk-test -l 0-1 --file= - > > prefix=3Devent_eth_tx_adapter_autotest > > --- stdout --- > > EAL: Probing VFIO support... > > APP: HPET is not enabled, using TSC as default timer > > RTE>>event_eth_tx_adapter_autotest > > + ------------------------------------------------------- + + Test Su= ite : tx event eth > > adapter test suite Port 0 MAC: 00 00 00 00 00 00 Port 1 MAC: 00 00 00 0= 0 00 00 > > Failed to find a valid event device, testing with event_sw0 device + -= --------------- > > --------------------------------------- + + Test Suite Summary > > + Tests Total : 5 > > + Tests Skipped : 0 > > + Tests Executed : 0 > > + Tests Unsupported: 0 > > + Tests Passed : 0 > > + Tests Failed : 5 > > + ------------------------------------------------------- + Test Faile= d > > > > Is this something that Nikhil should look into this as maintainer and fix= in separate patch, I am afraid this is not my area of expertise. I agree that someone knowing of this test should be looking at it. My suggestion on adding this test was based on the fact that we were building this code test. But I was expecting that you test this addition. You shall not break the CI :-) Please add this to your checklist for future submissions, or at least check the robot reports. Thanks. --=20 David Marchand