From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B00C24298A; Wed, 19 Apr 2023 16:36:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9719B40E25; Wed, 19 Apr 2023 16:36:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4480840A79 for ; Wed, 19 Apr 2023 16:36:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681914965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nS/im4yVzK+vi+F1SrB2Jd8Nfr44VSa4d3lwzanaNb0=; b=cBc9pEj0PhmEWv3BFqH1m47XDqzMTquhIiQbTxxpE55JmhvjfS5ZvAIjoCmRb9ZZUkaW5B 4z+Twed0yeJJXv9nJDatgbxfTOmQvxPoRvpGvZ+vXB0NbohAEiAg7Qor3ti1av7pwL4wRX 2tEcIwAernAO11NqXGnhEfTZ1i9jnig= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-4sdYT74sO4-kSjYl4_sNNQ-1; Wed, 19 Apr 2023 10:36:04 -0400 X-MC-Unique: 4sdYT74sO4-kSjYl4_sNNQ-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2476a31ef4aso1152193a91.3 for ; Wed, 19 Apr 2023 07:36:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681914964; x=1684506964; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nS/im4yVzK+vi+F1SrB2Jd8Nfr44VSa4d3lwzanaNb0=; b=A8UKkqykQqtcPN9U6Sexg/Ueme87dhbsah5hi6adRSwrMFmMf7N/T1k9f4eRn0eLvv 8nddcaMoertTM9XJO1QfHNDO4V0hQqb4ImOQJf6ilMf30FjbftUUISIha3f5I7KQThiu aAa+GqnAGhpdSXqx0KSqQvg+djRqzaocrKrpFfK7bErB6qwnsoCWbniZy3m3w0EdGGfA segn4PU5lFZI6ItouvbSgrz5+LHSzIvTI1M3Fn/ZYLRlSGbIXv5CC2wLmuyYbI1oEkI/ PJwn/ypjcboKDH26HhBWrrn2F/Wc1+umZuMaCQCk4InDJENh9CiDckHM42rBHJBz/EPx gCOg== X-Gm-Message-State: AAQBX9fPJrTuNW3OXQgVE2JZJ3R2WTRhDcQjk0I872zvnqwImYFIDmox 4AITtC5jqqloIE7o/697hB2w7EDgH0wh1FeLnAZKPNuDCwlqbQ5D4nQe5+XRSsFgJdlJcCS1xdy 4GxBu0yM5SDcMOk6kLCg= X-Received: by 2002:a17:903:11cc:b0:1a6:4541:73c with SMTP id q12-20020a17090311cc00b001a64541073cmr6468059plh.33.1681914963802; Wed, 19 Apr 2023 07:36:03 -0700 (PDT) X-Google-Smtp-Source: AKy350YtmCFSz4KF19H6elKzedWKvv0TplPhddw09zjZ7FG4E92yqLX3kCCO/P/PUoQIbmVzDW1XHuSBP0CCqSDJBec= X-Received: by 2002:a17:903:11cc:b0:1a6:4541:73c with SMTP id q12-20020a17090311cc00b001a64541073cmr6468036plh.33.1681914963530; Wed, 19 Apr 2023 07:36:03 -0700 (PDT) MIME-Version: 1.0 References: <20230331182006.708984-1-luca.boccassi@gmail.com> In-Reply-To: From: David Marchand Date: Wed, 19 Apr 2023 16:35:52 +0200 Message-ID: Subject: Re: 20.11.8 patches review and test To: Luca Boccassi Cc: Kevin Traynor , Ali Alnubani , "stable@dpdk.org" , "dev@dpdk.org" , Abhishek Marathe , "benjamin.walker@intel.com" , David Christensen , Hemant Agrawal , Ian Stokes , Jerin Jacob , John McNamara , Ju-Hyoung Lee , Pei Zhang , "qian.q.xu@intel.com" , Raslan Darawsheh , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Yanghang Liu , "yuan.peng@intel.com" , "zhaoyan.chen@intel.com" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 19, 2023 at 4:30=E2=80=AFPM Luca Boccassi wrote: > > On Wed, 19 Apr 2023 at 15:26, Kevin Traynor wrote: > > > > On 19/04/2023 15:23, Ali Alnubani wrote: > > >> -----Original Message----- > > >> From: Luca Boccassi > > >> Sent: Wednesday, April 19, 2023 5:15 PM > > >> To: David Marchand > > >> Cc: Ali Alnubani ; stable@dpdk.org; dev@dpdk.org= ; > > >> Abhishek Marathe ; > > >> benjamin.walker@intel.com; David Christensen ; > > >> Hemant Agrawal ; Ian Stokes > > >> ; Jerin Jacob ; John McNam= ara > > >> ; Ju-Hyoung Lee ; > > >> Kevin Traynor ; Pei Zhang ; > > >> qian.q.xu@intel.com; Raslan Darawsheh ; NBU- > > >> Contact-Thomas Monjalon (EXTERNAL) ; Yanghang > > >> Liu ; yuan.peng@intel.com; > > >> zhaoyan.chen@intel.com > > >> Subject: Re: 20.11.8 patches review and test > > >> > > >> On Wed, 19 Apr 2023 at 14:25, David Marchand > > >> wrote: > > >>> > > >>> On Wed, Apr 19, 2023 at 3:14=E2=80=AFPM Ali Alnubani wrote: > > >>>>> > > >>>>> I don't think this function prototype is really different in the = 20.11 > > >>>>> stable branch (putting the __rte_internal tag aside). > > >>>>> Can you trigger this issue on the main branch? > > >>>>> > > >>>> > > >>>> The main branch doesn't reproduce on the same environment. > > >>> > > >>> Ok, same for me, I reproduced for 20.11 but not for main. > > >>> > > >>> > > >>> I think I have the reason. > > >>> We filter headers to be processed by doxygen via a name filter: > > >>> > > >>> FILE_PATTERNS =3D rte_*.h \ > > >>> > > >>> But this rte_cryptodev_pmd.h driver header has been renamed as > > >>> cryptodev_pmd.h in 21.11. > > >>> So the issue you reported only affects 20.11. > > >> > > >> I can reproduce in debian testing, after backporting the mentioned > > >> commit from main it seems fine, can you confirm as well that it work= s > > >> in fedora? > > >> > > >> https://github.com/bluca/dpdk- > > >> stable/commit/77f65b61f955fd817b3791049dda3032c459ac59 > > > > > > Now I see a different error: > > > > > > [2/4] Generating doc/api/doxygen with a custom command > > > FAILED: doc/api/html > > > /tmp/dpdk/doc/api/generate_doxygen.sh doc/api/doxy-api.conf doc/api/h= tml /tmp/dpdk/doc/api/doxy-html-custom.sh > > > /tmp/dpdk/lib/librte_vhost/rte_vhost_async.h:49: error: rte_vhost_asy= nc_channel_ops::transfer_data has @param documentation sections but no argu= ments (warning treated as error, aborting now) > > > > See > > https://git.dpdk.org/dpdk-stable/commit/?h=3D21.11&id=3Dadeaf361f0a5bb3= 992756fd4e727dd11ecca0943 > > Thanks, any more errors with > https://github.com/bluca/dpdk-stable/commit/b75ebf643de0204d0092a56fbec63= f0bcd10e89f With those two backports, it works for me. b75ebf643d - (HEAD -> 20.11, bluca/20.11) vhost: fix doxygen warnings (6 minutes ago) 77f65b61f9 - lib: remove empty return types from doxygen comments (23 minutes ago) a75247cbdc - (stable/20.11) crypto/snow3g: fix snow3g enqueue stat increment (24 hours ago) --=20 David Marchand