From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Michael Shamis <michaelsh@marvell.com>,
Liron Himi <lironh@marvell.com>,
Martin Spinler <spinler@cesnet.cz>,
Andre Muezerie <andremue@linux.microsoft.com>
Subject: Re: [PATCH] drivers: allow build with VLAs
Date: Sat, 8 Feb 2025 17:11:20 +0100 [thread overview]
Message-ID: <CAJFAV8z4t91m02poRr6CL6=jNoRWvyGMAChzcz3VHK7rxoqeNA@mail.gmail.com> (raw)
In-Reply-To: <20250208092839.1238770-1-thomas@monjalon.net>
On Sat, Feb 8, 2025 at 10:29 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The drivers nfb, mvpp2 and mvsam use some variable length arrays
> in their code, so the warnings about VLA must be disabled for now,
> until removal for MSVC support, as in some other drivers.
>
> The warnings look like below:
>
> nfb_rx.h:156:16: error:
> ISO C90 forbids variable length array 'packets' [-Werror=vla]
> 156 | struct ndp_packet packets[nb_pkts];
>
> mvpp2/mrvl_flow.c:108:9: error:
> ISO C90 forbids variable length array 'zeros' [-Werror=vla]
> 108 | uint8_t zeros[size];
>
> mvsam/rte_mrvl_pmd.c:865:16: error:
> ISO C90 forbids variable length array 'requests_crp' [-Werror=vla]
> 865 | struct sam_cio_op_params requests_crp[nb_ops];
>
> Fixes: 1bf86800f7da ("build: warn on uses of VLA")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
prev parent reply other threads:[~2025-02-08 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 9:28 Thomas Monjalon
2025-02-08 16:11 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z4t91m02poRr6CL6=jNoRWvyGMAChzcz3VHK7rxoqeNA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=lironh@marvell.com \
--cc=michaelsh@marvell.com \
--cc=spinler@cesnet.cz \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).