From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB567A0093; Mon, 3 Oct 2022 09:17:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCBE840695; Mon, 3 Oct 2022 09:17:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BC77740693 for ; Mon, 3 Oct 2022 09:17:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664781475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cwmm46G59Qoz9G3z42nkIVk9QXaB5J5FPH9X494ZRvs=; b=hum20OnW1N5+uk+smhOQEQtrE0yg42KcDYE9WxfXK0g4OfjwQfzIJyVrgXMK3FItg06vgZ AkMcWESoEvVaNv3Va6wXXqcTg/XYVTK89CD20nspMfYLpQGxeuUloz1kAbCMEt7nR7K+WH Jad6+85IBr4TOO8XA533E1VE6medGpI= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-255-_05ZElp2OCCU0a5uQaijow-1; Mon, 03 Oct 2022 03:17:44 -0400 X-MC-Unique: _05ZElp2OCCU0a5uQaijow-1 Received: by mail-pj1-f71.google.com with SMTP id w9-20020a17090a780900b002093deb1701so3982084pjk.0 for ; Mon, 03 Oct 2022 00:17:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=cwmm46G59Qoz9G3z42nkIVk9QXaB5J5FPH9X494ZRvs=; b=ubebKJRywwteSsSjE4S7wpvDML4EfLw/uPOyCcKr7AB5tNxyYQGf7gwm6KfZCpb5Im woJfcpkXS59jH9U5J4jSk8o3xX+MpySQB+QYMl7oJAjESvOhALm0liYfOVjZD9T/2Ujk AjUaJLkctxKllHS4GzUczIUgSelF9f5xbcw4hO5yLKmkxCaj9GQFRJS0CenPcqGC++yT 12amH04/QxNuNe7PKCoVv7JpHs24ijoVOfDT2eRA7yMaqf8yB3qCUbaEB3xc9LOzC9/y ssyFgs8Ud5PysHPFuRbazIkeDHyI7KQ2+wHkCSAup0igM/IbSqFdyeVBbkpZN0kRmm59 AcTA== X-Gm-Message-State: ACrzQf3AfXl7bWv3FuP2eV0SQI7srEIrEs2eO6XjDbatBQqd1/GJEuNz 9E7msJrSmJ6lC3wVe6Q9nchBEmELZGfrcAgOkA8RefRq0HVpx275qI4DkIS10Wg7VcZRfm+6OUb r9R3wpShecUOX0B4n+/w= X-Received: by 2002:a63:8ac7:0:b0:445:80ef:2b8 with SMTP id y190-20020a638ac7000000b0044580ef02b8mr9065359pgd.120.1664781463785; Mon, 03 Oct 2022 00:17:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM49N8eQzslQcNMp8EVTGTOtuqJh7+H1yrcj187/3wVlwMuha2bDMn1mUMoyUBXC2P9QBAqsmSJLDNGOGsHsseo= X-Received: by 2002:a63:8ac7:0:b0:445:80ef:2b8 with SMTP id y190-20020a638ac7000000b0044580ef02b8mr9065346pgd.120.1664781463553; Mon, 03 Oct 2022 00:17:43 -0700 (PDT) MIME-Version: 1.0 References: <20220929093829.10218-1-bruce.richardson@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D8736D@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8736D@smartserver.smartshare.dk> From: David Marchand Date: Mon, 3 Oct 2022 09:17:31 +0200 Message-ID: Subject: Re: [PATCH] metrics: return error code on initialization failures To: Bruce Richardson Cc: =?UTF-8?Q?Morten_Br=C3=B8rup?= , dev@dpdk.org, thomas@monjalon.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 29, 2022 at 1:16 PM Morten Br=C3=B8rup wrote: > > DPDK libraries should never call rte_exit on failure, so change the > > function return type of rte_metrics_init to "int" to allow returning an > > error code to the application rather than exiting the whole app on init > > failure. > > > > Signed-off-by: Bruce Richardson > Acked-by: Morten Br=C3=B8rup Lgtm too. Added a note in the RN and applied. Thanks Bruce. --=20 David Marchand