From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27A23A0562; Tue, 23 Mar 2021 11:30:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D74D74014D; Tue, 23 Mar 2021 11:30:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 9D6E940143 for ; Tue, 23 Mar 2021 11:30:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616495440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hy6edSbj09+FATeLhENN2RmoUxCuuZV4kA4a8EMKPdo=; b=Q463FeH6fncBpRaKjKDccqNtv18HuBTyzZbXK826b+PRNHKK1+e0q/5vs/Jh8NhPe+uyLd Lloy9jIE7/rJjie53FOM7mWNeYBVyhtHpgK1/YLKaZIKQk62bZ8wDOA22hSufmreOAhBUC tvqPqiU1eFxmJPEkQQycXdoPT1gnCmQ= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-528-RTuRyek_MbmhKFEFJMFy4A-1; Tue, 23 Mar 2021 06:30:38 -0400 X-MC-Unique: RTuRyek_MbmhKFEFJMFy4A-1 Received: by mail-vk1-f198.google.com with SMTP id s69so348423vkd.20 for ; Tue, 23 Mar 2021 03:30:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hy6edSbj09+FATeLhENN2RmoUxCuuZV4kA4a8EMKPdo=; b=Nmc11UNo04veQBgsQNpC36nJhS1H2kB3uJfcwXpCPRgsa9k7w3o6v+8NJ/ydTlspG5 MVZrKDeVk/rwpuuLYgkDRSKjL3BHkCyRxamID49qWE2Gh1cx6cCwluvn/g8vXI+BjLlV supLoxcAYrRN0DfraOYnMSHne+t2jcZfFMohgLIpo+11bTjvs8W9RAe2qpNwvHHPt7VY lvIdRSOjhnva/ahwydzRSX3xOHCvsYff2zJCY4dLQyQlSsyS6uDNwffk+VLW2wu8OiIi rb99PKnRSeh77pw7+OloeWtcVTXuZi3q1qPmoLp2f9mk6OuUV+Xbg1TtpBDhsyd7x8UU rWSg== X-Gm-Message-State: AOAM531Bufh4N/m9yge11eOF7LugerWORcnDRBJQFqDcY4pL3S9Nw1K5 xb5CFXK8rMSQYxXjnMvs7B9Fagsviu0a6eCuksWDtGeMNhEYJFsI5ZqcAQdMxJW4kKidBXE8iou eQdH8nlzkYQceCEWixoM= X-Received: by 2002:ac5:c93a:: with SMTP id u26mr2836627vkl.17.1616495438071; Tue, 23 Mar 2021 03:30:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFz1vsBF+1Z+D5wCj1WXe/H/EK9xeM2oz6y8V5GFC2s6GgTIHBYYo1pCqgprTZ7KNG1Dt1uYsZqZnxGXTMvBk= X-Received: by 2002:ac5:c93a:: with SMTP id u26mr2836612vkl.17.1616495437779; Tue, 23 Mar 2021 03:30:37 -0700 (PDT) MIME-Version: 1.0 References: <20210323090219.126712-1-maxime.coquelin@redhat.com> In-Reply-To: <20210323090219.126712-1-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 23 Mar 2021 11:30:26 +0100 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , Adrian Moreno Zapata , Olivier Matz , Balazs Nemeth Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 0/3] vhost: make virtqueue cache-friendly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 23, 2021 at 10:02 AM Maxime Coquelin wrote: > > As done for Virtio PMD, this series improves cache utilization > of the vhost_virtqueue struct by removing unused field, > make the live-migration cache dynamically allocated at > live-migration setup time and by moving fields > around so that hot fields are on the first cachelines. > > With this series, The struct vhost_virtqueue size goes > from 832B (13 cachelines) down to 320B (5 cachelines). > > With this series and the virtio one, I measure a gain > of up to 8% in IO loop micro-benchmark with packed > ring, and 5% with split ring. > > I don't have a setup at hand to run PVP testing, but > it might be interresting to get the numbers as I > suspect the cache pressure is higher in this test as > in real use-cases. > > Changes in v4: > ============== > - Fix missing changes to boolean (Chenbo) > For the series, Reviewed-by: David Marchand Merci ! -- David Marchand