From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5654DA0093; Mon, 3 Oct 2022 10:07:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E81C240695; Mon, 3 Oct 2022 10:07:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8BC5640693 for ; Mon, 3 Oct 2022 10:07:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664784430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ClEvjfjH/XpZBwNw1iXtm3drPjNOdz/MQlfgOxqjEdc=; b=Tk5zwbzuQn6C09ldPz9gFU2KuB5wRp1Io+XSR0M02NU2UZI5Fms2mEtekX1x/tq3//EkRY 03oL6modU9UTLlrlU9t2YBTyUxt/0cDsfZzswSRyTb5GMrijwt076+SSmRJnXUpcYgDAzg 2+SOnptddGFK0SK+cewgv9iRNTCKWzs= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-380-CrkmeZoiPjSQTxKhUeGXmw-1; Mon, 03 Oct 2022 04:07:09 -0400 X-MC-Unique: CrkmeZoiPjSQTxKhUeGXmw-1 Received: by mail-pg1-f198.google.com with SMTP id q8-20020a632a08000000b0043cab9c7de9so6541654pgq.3 for ; Mon, 03 Oct 2022 01:07:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=ClEvjfjH/XpZBwNw1iXtm3drPjNOdz/MQlfgOxqjEdc=; b=2myI+bb+NEAZiTXav9Daf+prnAEr0x8bNlinvd0G7knp7bjMmGZGXXNSqgBZJfOyoe 5k8E8UVhCBnveoH+UWZ/+XSheDAP4d0Z9GNVLVjW83cYbze8uvJTA04jPetIB/s0Aqv3 Ry+m0yejBy079JQ1L387EV2uSXpCf4XarCSR0k3tvrxkgyc3pybfY1agQl1jCQytlFOa cgffyfPWi2lHJywZCW2G0A5mYOzqEhIF7sO1PP3aRQ9kTZ6YFi6/JsuYmjQyZMQ5DCij CgBy+tYKM+RvDrbXkra+lCBDn4zzQZ62fQ3NsZ+iZRbFN0tt15xDRwd94ZZQBc/yrYM4 j6tw== X-Gm-Message-State: ACrzQf1Pu+2xV6qLqJiZsSO6ZDlXltrL74ER+AWrU8kJzKN/WWspTNmU DjEQ/qcnxfJrETgs8vTZ8Tf/3Xh1yzjf0Lk3sPMjQpVLG19fRcqMo8Xm8ilprUseDZL2yOCWshq pNMAXj+VTYa0bhrtJOoE= X-Received: by 2002:a62:c584:0:b0:558:2095:e5ed with SMTP id j126-20020a62c584000000b005582095e5edmr21362533pfg.64.1664784428192; Mon, 03 Oct 2022 01:07:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6H3keL/LZ4+aEqo83F5uhVhismRsfjroGBPyMnpA5pmgQuNfX+RtGErSDTUn1aSwgBaSyCM/G0YzVDKjwf8pw= X-Received: by 2002:a62:c584:0:b0:558:2095:e5ed with SMTP id j126-20020a62c584000000b005582095e5edmr21362511pfg.64.1664784427928; Mon, 03 Oct 2022 01:07:07 -0700 (PDT) MIME-Version: 1.0 References: <20220708125645.3141464-2-harry.van.haaren@intel.com> <20220906161352.296110-1-mattias.ronnblom@ericsson.com> In-Reply-To: <20220906161352.296110-1-mattias.ronnblom@ericsson.com> From: David Marchand Date: Mon, 3 Oct 2022 10:06:56 +0200 Message-ID: Subject: Re: [PATCH 1/6] service: reduce statistics overhead for parallel services To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Harry Cc: dev@dpdk.org, Honnappa Nagarahalli , =?UTF-8?Q?Morten_Br=C3=B8rup?= , nd X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 6, 2022 at 6:17 PM Mattias R=C3=B6nnblom wrote: > > Move the statistics from the service data structure to the per-lcore > struct. This eliminates contention for the counter cache lines, which > decreases the producer-side statistics overhead for services deployed > across many lcores. > > Prior to this patch, enabling statistics for a service with a > per-service function call latency of 1000 clock cycles deployed across > 16 cores on a Intel Xeon 6230N @ 2,3 GHz would incur a cost of ~10000 > core clock cycles per service call. After this patch, the statistics > overhead is reduce to 22 clock cycles per call. > > Signed-off-by: Mattias R=C3=B6nnblom Re-reading the mail archive, I found that Morten acked the series (replying on patch 4). Mattias, such a series deserved a cover letter. How does this series fit with other patches from Harry? https://patchwork.dpdk.org/project/dpdk/list/?series=3D23959&state=3D* Thanks. --=20 David Marchand