From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62A6BA0A02; Wed, 24 Mar 2021 10:03:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E20D140D06; Wed, 24 Mar 2021 10:03:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D7CDD4014F for ; Wed, 24 Mar 2021 10:03:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616576584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VlXytg2k6LNFuI/CjMljMZvKnjQ1w3MV7cMoFBnv7wU=; b=OW+snOvMgOSAATsSSuce3shnwsRt8h5N50uzYzMvq7oPDHOmwRkKNbNuMHgr8S2XABpa9L POQ2EeS2qEA0vVuAMTnsEp3Qw+yhRIQ6OOEVvsSqtE9kRUMcOKeGYMYrw7raIVAkD2ppaS 3nUAMBVTuRNHcdSEPDa4bxzNQ+mwDGo= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-jeW2exZJPeyy7ta65wsKfw-1; Wed, 24 Mar 2021 05:03:02 -0400 X-MC-Unique: jeW2exZJPeyy7ta65wsKfw-1 Received: by mail-vs1-f71.google.com with SMTP id q1so481417vsa.6 for ; Wed, 24 Mar 2021 02:03:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VlXytg2k6LNFuI/CjMljMZvKnjQ1w3MV7cMoFBnv7wU=; b=L/QdfZVERnnufvtpKeqicJpDtAC6WmK/fYBreAjiRuD26AhiCgSHw3vaY/OaM/cyrT EsANjv6cp80Scv09UDig4Enat+2ETmZ/wFNnjR1DH5EZdubxFC/I34J5Zdodk96phu5+ 3aRr5wgz0nhiurkBQHuyynnKwt4fbjMyax/iYYIcH38JLAo/SsHGBFpYwIhk1aYXlC7J iO8nJ9oeHYIiAJKOYTHI/UALItwkPrsYdV1FcCPapsCdbHSaExy41IDPGmrRdcrwyqsR 7UmkkAkwarVpOr/fyMCAbSiFgaPI78Z2vzWxhjneB9QWOJUMjry2xqj5ATlbQAn4peqy i0yQ== X-Gm-Message-State: AOAM532f+FAVy1cbL9HIXAF4XeyKkliBQp6Z5s5cVd3erVu867EuQb8I cthGuSvOESrwGBGxY8lm7hjYHC0EDjxelXhYnz6K5Vr/Q5k4/BQ0jwZDnsj28P9f4wNhn8FpgW2 MikcTbH6gBwluVkBLRvg= X-Received: by 2002:a05:6102:ed4:: with SMTP id m20mr820620vst.27.1616576581770; Wed, 24 Mar 2021 02:03:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHxWUEcigX1VJcfgXq+A5wLiiwbSvyiIPkCDL+oAuAZ+BJHH3oaVj0iuPeGGCL7Xpi+/3nLUCAfAJvT1rf7GI= X-Received: by 2002:a05:6102:ed4:: with SMTP id m20mr820614vst.27.1616576581507; Wed, 24 Mar 2021 02:03:01 -0700 (PDT) MIME-Version: 1.0 References: <1616048795-16906-1-git-send-email-jizh@linux.microsoft.com> <1616172695-28505-1-git-send-email-jizh@linux.microsoft.com> <20210321040103.0cd5bb77@sovereign> <20210323012337.1e2250b5@sovereign> In-Reply-To: <20210323012337.1e2250b5@sovereign> From: David Marchand Date: Wed, 24 Mar 2021 10:02:50 +0100 Message-ID: To: Dmitry Kozlyuk , "Burakov, Anatoly" Cc: Jie Zhou , dev , Thomas Monjalon , "Yigit, Ferruh" , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v2] app/test-pmd: enable testpmd on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 22, 2021 at 11:23 PM Dmitry Kozlyuk wrote: > > 2021-03-22 21:55 (UTC+0000), Jie Zhou: > > Thank you Dmitry! > > > > Regarding " I can make eal_mem_free() behave as expected at issue 2. Or= should we simple disable this code when where's no multiprocess support (h= ow do we test for it properly, BTW)?". The issue hit when I ran testpmd (wi= th i40e pmd) and at "quit" (which calling into rte_eal_cleanup and reached = this rte_mem_unmap). I can test your patch with my local testpmd (which I w= ill add back the rte_eal_cleanup to exercise the code path), if that is wha= t you are asking about test. > > Thanks, but it really was a question to Anatoly about how to test if > multiprocess is supported. I can send a patch that kind of works, if you > wish, but I wonder if there's a simpler solution. > > Please don't drop Cc so that everyone can see the progress. > When in --in-memory mode, would it be simpler to avoid the cleaning up code entirely? It should (I would not say solve but) avoid your issue on Windows which only supports --in-memory. If this does not help... Anatoly, the floor is yours. --=20 David Marchand