From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72AB8A04C9; Mon, 14 Sep 2020 10:47:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F08BB1C0D0; Mon, 14 Sep 2020 10:47:08 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id D1FC71C0CF for ; Mon, 14 Sep 2020 10:47:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600073227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3BrRK1fC85k2F1dWn6RZcBI/cmBrvZR67rYl+mbHUK0=; b=WXbf0OhsFFolj/2s5JJ3vzXh1ZECgzZ+YtXdgahRCAqqPdLN2n+fiZZCUvZ2TNDVxSyVfE 8bObbhTdltBAc3pMV8pRPbcEJuE3Ow9wzdNME1JO2Phda5MLh1ATvAVGR6L2ukauqq+/1v nRmhH4RG+/VJJQpYP965b3Cuqie8RXo= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-8q2i_5nzOOiGABEyv7iABQ-1; Mon, 14 Sep 2020 04:47:05 -0400 X-MC-Unique: 8q2i_5nzOOiGABEyv7iABQ-1 Received: by mail-vk1-f197.google.com with SMTP id q69so4251926vka.12 for ; Mon, 14 Sep 2020 01:47:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3BrRK1fC85k2F1dWn6RZcBI/cmBrvZR67rYl+mbHUK0=; b=GeXtifqUCQYy6PfwAbK/cQGdFHqkXrvS8gxHO5R/A4qDMAV6td+c0/LxDF3i2UYw4n ms0612ISzj7hHaKAJRUrrme4YaN3WVw+P9mXiUdQ2Txj523Z1kdz6mSt0Z9MgUrWAAEP 88k8wXAMonn44c86ROAiYcqsqKyMwoCEEjDSBu76jDRuo5xKjBv6mnrNDMF1E1BpB3Bl CBBWS6QbSsjVWN8o9dpuRiZmt7CqgLTYUh1LogtNfzVzIuC8CeftDbDmWJcMhj+l+q53 J1RqszOIU2OnnlZokLxcThs1stDLof+gxjgEWihY0jJoUAINEKr7OFHe/rXViBXtdDb5 X/Ww== X-Gm-Message-State: AOAM532VGSXAuZt8t+v4YowZskHoGBwwAi8ZhQlI5ZvNjFolS1vJKKyj hTQDLZwQ7ECOOQKry8vVb4d+55IYLoAyGGjyn9yvNdzb0RKdphA8Q+0AU7SG8VYZp4Z7WcWLjN1 RdFtGlsu4DLOMNDQsaZw= X-Received: by 2002:a67:7795:: with SMTP id s143mr6487676vsc.94.1600073225149; Mon, 14 Sep 2020 01:47:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykkkmeuK/tFXwPE9Ku0YDgMw6Vea7XTamBiOEvsiV6VKbM48si1dIFZkjj4yuCFJJblKzSobY36UV25vgmhA8= X-Received: by 2002:a67:7795:: with SMTP id s143mr6487670vsc.94.1600073224925; Mon, 14 Sep 2020 01:47:04 -0700 (PDT) MIME-Version: 1.0 References: <20200910015525.59124-1-stevex.yang@intel.com> <20200911055811.16474-1-stevex.yang@intel.com> <20200911144539.GC732@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200911144539.GC732@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Mon, 14 Sep 2020 10:46:54 +0200 Message-ID: To: Bruce Richardson , Luca Boccassi , Kevin Traynor Cc: SteveX Yang , dev , Wenzhuo Lu , Beilei Xing , Qiming Yang , Thomas Monjalon , Ciara Power Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 11, 2020 at 4:45 PM Bruce Richardson wrote: > I don't particularly like keeping the old defines around, since they are > inconsistent in naming, but since we didn't announce a deprecation of the > old values perhaps we should add them in. I don't like keeping those either, but we did not announce it and those defines are part of the API (people relying on them to control their own code). So my vote is on putting a deprecation for 21.02... cleaning the code so that it uses $meson_token (example RTE_LIBRTE_BOND_PMD) and adding a compat macro (meson -> make) as you suggested. For the backports... the stable maintainers will be the one impacted :-). -- David Marchand