Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] examples/l2fwd: remove mac-updating option

[David Marchand <david.marchand@redhat.com>]

On Fri, Jun 11, 2021 at 12:28 PM SunChengLian <sunchenglian@loongson.cn> wrote:
>
> The "mac-updating" option can be removed since the associated mac_updating
> variable is set to 1 by default.
>
> Signed-off-by: SunChengLian <sunchenglian@loongson.cn>
> ---
>  examples/l2fwd/main.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c
> index a8fa091842..65b290291d 100644
> --- a/examples/l2fwd/main.c
> +++ b/examples/l2fwd/main.c
> @@ -434,13 +434,11 @@ enum {
>
>         /* first long only option value must be >= 256, so that we won't
>          * conflict with short options */
> -       CMD_LINE_OPT_MAC_UPDATING_NUM = 256,
> -       CMD_LINE_OPT_NO_MAC_UPDATING_NUM,
> +       CMD_LINE_OPT_NO_MAC_UPDATING_NUM=256,

Nit: s/=256/ = 256/

>         CMD_LINE_OPT_PORTMAP_NUM,
>  };
>
>  static const struct option lgopts[] = {
> -       { CMD_LINE_OPT_MAC_UPDATING, no_argument, 0, CMD_LINE_OPT_MAC_UPDATING_NUM},
>         { CMD_LINE_OPT_NO_MAC_UPDATING, no_argument, 0, CMD_LINE_OPT_NO_MAC_UPDATING_NUM},
>         { CMD_LINE_OPT_PORTMAP_CONFIG, 1, 0, CMD_LINE_OPT_PORTMAP_NUM},
>         {NULL, 0, 0, 0}
> @@ -503,10 +501,6 @@ l2fwd_parse_args(int argc, char **argv)
>                         }
>                         break;
>
> -               case CMD_LINE_OPT_MAC_UPDATING_NUM:
> -                       mac_updating = 1;
> -                       break;
> -
>                 case CMD_LINE_OPT_NO_MAC_UPDATING_NUM:
>                         mac_updating = 0;
>                         break;
> --
> 2.25.1
>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand