From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B20BA0C4C; Thu, 17 Jun 2021 11:16:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A9BB4069C; Thu, 17 Jun 2021 11:16:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id C1E014069C for ; Thu, 17 Jun 2021 11:16:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623921396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5VFTNQQ9Eb0jaEWAMu0cwuAdgtx+pi0tcCGSt//npog=; b=f4inoP8f7Zd0wd+OUZSRJJaC94Dj/qj3mP75mw8oaPsH+oPIRYspDVd6nPHO6NXXTnpG0S IVcTGHzuVj9ZBU9R+a08epfToUSEsVZFpCFjryBQkYqVPJE0Qz2N6XU4guZM1i3tLZq6p3 tryc/2txPvaDoW0EawvPZkApV3CJfXE= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-zcvWa977Op23A0aJsLvMJw-1; Thu, 17 Jun 2021 05:16:32 -0400 X-MC-Unique: zcvWa977Op23A0aJsLvMJw-1 Received: by mail-ua1-f69.google.com with SMTP id j9-20020ab060090000b0290256b90cfee7so2369021ual.5 for ; Thu, 17 Jun 2021 02:16:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5VFTNQQ9Eb0jaEWAMu0cwuAdgtx+pi0tcCGSt//npog=; b=n4/hYeR7JTBMqpWPH7rXKhzcN8vfEFU0cVFQVmxjwOBs+L1LrAbLzOC7BvZqRu0llM tzcCJUbbe/8bNXfGH9WV6GN0a+hUob2jasHPRIH5AQiZyHyb8uFMbiojm1GDZNlC4dZ+ 6DxWSJfL3Zv+89dRH+PmfKncPWaMaq/oVUk4KhZXJ8BLippE46jMy6iOOWU4YOcssdCU cuHeJUM8f8X+tP1lmbJlBeeIDsVNQH4pz+e99BAfmTB/wErqHfcgevhu2ZoqFSC0rN28 bJcZJ+ZtvzI8RgFsMxwCuHT6TYKLlJS6Ur5EVH1VzihPkcQUuLbSrg1L1dxcC2CrCFYn DqlQ== X-Gm-Message-State: AOAM531Hn1BXHdLXXQECK3SNDvAitsPhnOzLoC+9YWlIbXtv371Ln+vg 3etJueEOaa92nvJE6lLTAzuOg6Udu6BluovkS9U1QbZfT/g0cUBF4HyJs5IeNFf1s9JjYa2VXtY 0y+wOKaIZ90uJCPV+tus= X-Received: by 2002:a05:6102:67a:: with SMTP id z26mr3518147vsf.10.1623921392225; Thu, 17 Jun 2021 02:16:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxowCGVPuvtupOwC97L0Fjopoe4Mt98R74z6Ge+LRpqh0g6PHZVucQvGTaOQtDyXxfqne7CGfrwo4LBIlX/HUU= X-Received: by 2002:a05:6102:67a:: with SMTP id z26mr3518137vsf.10.1623921392070; Thu, 17 Jun 2021 02:16:32 -0700 (PDT) MIME-Version: 1.0 References: <20210610010159.1813398-1-sunchenglian@loongson.cn> <20210611102741.389045-2-sunchenglian@loongson.cn> In-Reply-To: <20210611102741.389045-2-sunchenglian@loongson.cn> From: David Marchand Date: Thu, 17 Jun 2021 11:16:20 +0200 Message-ID: To: SunChengLian Cc: dev , Bruce Richardson , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] examples/l2fwd: remove mac-updating option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 11, 2021 at 12:28 PM SunChengLian wrote: > > The "mac-updating" option can be removed since the associated mac_updating > variable is set to 1 by default. > > Signed-off-by: SunChengLian > --- > examples/l2fwd/main.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c > index a8fa091842..65b290291d 100644 > --- a/examples/l2fwd/main.c > +++ b/examples/l2fwd/main.c > @@ -434,13 +434,11 @@ enum { > > /* first long only option value must be >= 256, so that we won't > * conflict with short options */ > - CMD_LINE_OPT_MAC_UPDATING_NUM = 256, > - CMD_LINE_OPT_NO_MAC_UPDATING_NUM, > + CMD_LINE_OPT_NO_MAC_UPDATING_NUM=256, Nit: s/=256/ = 256/ > CMD_LINE_OPT_PORTMAP_NUM, > }; > > static const struct option lgopts[] = { > - { CMD_LINE_OPT_MAC_UPDATING, no_argument, 0, CMD_LINE_OPT_MAC_UPDATING_NUM}, > { CMD_LINE_OPT_NO_MAC_UPDATING, no_argument, 0, CMD_LINE_OPT_NO_MAC_UPDATING_NUM}, > { CMD_LINE_OPT_PORTMAP_CONFIG, 1, 0, CMD_LINE_OPT_PORTMAP_NUM}, > {NULL, 0, 0, 0} > @@ -503,10 +501,6 @@ l2fwd_parse_args(int argc, char **argv) > } > break; > > - case CMD_LINE_OPT_MAC_UPDATING_NUM: > - mac_updating = 1; > - break; > - > case CMD_LINE_OPT_NO_MAC_UPDATING_NUM: > mac_updating = 0; > break; > -- > 2.25.1 > Reviewed-by: David Marchand -- David Marchand