From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4DE741E3A; Fri, 10 Mar 2023 10:35:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9586040A81; Fri, 10 Mar 2023 10:35:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A00E340685 for ; Fri, 10 Mar 2023 10:35:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678440913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ugm0rbfJesT0kazERdnPrkWJVOepkrhy57/UULiusng=; b=EH4pvu5W7gFepDEVtFk6RH3Wybh6ie5Fo60BqqZxFeXb8/uRH2wQm48h7aTeS1Nt+UMSnU u+EtlGjm1s6W7+BIElyAAjeSEvYFHhy3ADxx2BAPT2BTcMuhwv0ag3LcoOV8KjsOzoVIRA aJDbOXquxCQztXrnLgkWFwbzUYDjaKM= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428-56gNDXUaNV2KLPIio3rSWg-1; Fri, 10 Mar 2023 04:35:11 -0500 X-MC-Unique: 56gNDXUaNV2KLPIio3rSWg-1 Received: by mail-pj1-f70.google.com with SMTP id gm13-20020a17090b100d00b0023704a72ca5so2160892pjb.4 for ; Fri, 10 Mar 2023 01:35:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678440910; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ugm0rbfJesT0kazERdnPrkWJVOepkrhy57/UULiusng=; b=HrW9ahprxxEms1E8AZl+5mRcAmLqFczmxoXc9mlUJ9Leod78nPQH0k6NpBsJRiIjMV r3jzQ5sHHWdPMla449dhHS/7jCrWHjwouzwvAf0mIrqPl+uXK5KcMebRLUDHUH4TdTjn iymGIZhHP0wtnk5b3rzQeoOxgF/U61JkxwrfGsZxxFj+OD5nvO67IeWCTNprWsVUHKPR QkTzJzZul4+PLF6FpGS9hAC6WS7IrQMhU4GisLhQ6bg1ul7r37Gdc6V7HiF94qQEIPKW 9koO06nd5nlLEa2YR8ZOTezaCsOlZt2loJLaMyVXmVpUQ8yvj43Tbw/zGuD8nYKkZJa/ fQ4w== X-Gm-Message-State: AO0yUKVpBPJNlyqqZXEVOxwXUJxhmfF8V4wDPc3ch8xArmdu/W9cGdAj sKm91dy3olLTjH1HvuttgfhyPIehA+9drOAFT4pifYTJMIgaobAvAH5wOW8EoyWNE09QR58hAWB DzKPn0qirJuvUCxeZvMA= X-Received: by 2002:a63:ac53:0:b0:503:7be2:19a7 with SMTP id z19-20020a63ac53000000b005037be219a7mr8965726pgn.1.1678440910660; Fri, 10 Mar 2023 01:35:10 -0800 (PST) X-Google-Smtp-Source: AK7set/IYbBoJNlzAAGxWeZi+bgVsWwE+h/SG67VU/zYYdsWLCS2y6K5ZQVjkXcZ12a3WlmC03syZ1Ha/5xh3OGI/RQ= X-Received: by 2002:a63:ac53:0:b0:503:7be2:19a7 with SMTP id z19-20020a63ac53000000b005037be219a7mr8965720pgn.1.1678440910311; Fri, 10 Mar 2023 01:35:10 -0800 (PST) MIME-Version: 1.0 References: <20230207001937.875608-1-stephen@networkplumber.org> <20230219231416.22524-1-stephen@networkplumber.org> <20230219231416.22524-3-stephen@networkplumber.org> <20230309132135.7ba6063e@hermes.local> In-Reply-To: <20230309132135.7ba6063e@hermes.local> From: David Marchand Date: Fri, 10 Mar 2023 10:34:59 +0100 Message-ID: Subject: Re: [PATCH v4 2/9] net/ring: build on Windows To: Stephen Hemminger Cc: dev@dpdk.org, Tyler Retzlaff , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 9, 2023 at 10:21=E2=80=AFPM Stephen Hemminger wrote: > > On Thu, 9 Mar 2023 22:10:03 +0100 > David Marchand wrote: > > > > diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_e= th_ring.c > > > index bd5a47dd9017..e8bc9b627102 100644 > > > --- a/drivers/net/ring/rte_eth_ring.c > > > +++ b/drivers/net/ring/rte_eth_ring.c > > > @@ -9,6 +9,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > Is it still needed, since this patch drops use of PATH_MAX? > > Let me submit a version without, I don't run windows just do cross builds= . Good thing you did. So we still need this include for hack on strdup. So the v4 series is enough. If I manage to merge it today..., I'll simply update the commitlog. libtmp_rte_net_ring.a.p" "-Idrivers" "-I..\drivers" "-Idrivers\net\ring" "-I..\drivers\net\ring" "-Ilib\ethdev" "-I..\lib\ethdev" "-I." "-I.." "-Iconfig" "-I..\config" "-Ilib\eal\include" "-I..\lib\eal\include" "-Ilib\eal\windows\include" "-I..\lib\eal\windows\include" "-Ilib\eal\x86\include" "-I..\lib\eal\x86\include" "-Ilib\eal\common" "-I..\lib\eal\common" "-Ilib\eal" "-I..\lib\eal" "-Ilib\kvargs" "-I..\lib\kvargs" "-Ilib\net" "-I..\lib\net" "-Ilib\mbuf" "-I..\lib\mbuf" "-Ilib\mempool" "-I..\lib\mempool" "-Ilib\ring" "-I..\lib\ring" "-Ilib\metrics" "-I..\lib\metrics" "-Ilib\telemetry" "-I..\lib\telemetry" "-Ilib\meter" "-I..\lib\meter" "-Idrivers\bus\pci" "-I..\drivers\bus\pci" "-I..\drivers\bus\pci\windows" "-Ilib\pci" "-I..\lib\pci" "-Idrivers\bus\vdev" "-I..\drivers\bus\vdev" "-IC:\Program Files\Mellanox\MLNX_WinOF2_DevX_SDK\inc" "-Xclang" "-fcolor-diagnostics" "-pipe" "-D_FILE_OFFSET_BITS=3D64" "-Wall" "-Winvalid-pch" "-Wextra" "-Werror" "-O3" "-include" "rte_config.h" "-Wcast-qual" "-Wdeprecated" "-Wformat" "-Wformat-nonliteral" "-Wformat-security" "-Wmissing-declarations" "-Wmissing-prototypes" "-Wnested-externs" "-Wold-style-definition" "-Wpointer-arith" "-Wsign-compare" "-Wstrict-prototypes" "-Wundef" "-Wwrite-strings" "-Wno-address-of-packed-member" "-Wno-missing-field-initializers" "-D_GNU_SOURCE" "-D_WIN32_WINNT=3D0x0A00" "-D_CRT_SECURE_NO_WARNINGS" "-march=3Dnative" "-DALLOW_EXPERIMENTAL_API" "-DALLOW_INTERNAL_API" "-DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.net.ring" -MD -MQ drivers/libtmp_rte_net_ring.a.p/net_ring_rte_eth_ring.c.obj -MF "drivers\libtmp_rte_net_ring.a.p\net_ring_rte_eth_ring.c.obj.d" -o drivers/libtmp_rte_net_ring.a.p/net_ring_rte_eth_ring.c.obj "-c" ../drivers/net/ring/rte_eth_ring.c ../drivers/net/ring/rte_eth_ring.c:564:9: error: 'strdup' is deprecated: The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _strdup. See online help for details. [-Werror,-Wdeprecated-declarations] name =3D strdup(value); ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\string.h:535:20: note: 'strdup' has been explicitly marked deprecated here _Check_return_ _CRT_NONSTDC_DEPRECATE(_strdup) ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:335:50: note: expanded from macro '_CRT_NONSTDC_DEPRECATE' #define _CRT_NONSTDC_DEPRECATE(_NewName) _CRT_DEPRECATE_TEXT( \ ^ C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\vcruntime.h:310:47= : note: expanded from macro '_CRT_DEPRECATE_TEXT' #define _CRT_DEPRECATE_TEXT(_Text) __declspec(deprecated(_Text)) ^ 1 error generated --=20 David Marchand