From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D3CAA04DC; Tue, 20 Oct 2020 09:17:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 456C3BAEE; Tue, 20 Oct 2020 09:17:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 99626BBAE for ; Tue, 20 Oct 2020 09:17:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603178246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DZzkxCW+7yNv6ebEK0T3tumKEQ44hjTaCgvLb94lZ8M=; b=XBt3v6UuXl7c2rdEsebLRx4kPsderQfiGwoZWgryJ5ZSAuNVo7z9gQzfxGj42/BNUdO6DO SSUFKPHrQKgoGS2RcsBlmjborau+YhrhQ6gN0OCPcE1V9P8E38GBMeI7wSK912lGM5pMBK 1kzxVKdsCBp4tJRQLyIOz2B11itX3VI= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-463-rRpGYx5kNfei30sRJNTstg-1; Tue, 20 Oct 2020 03:17:23 -0400 X-MC-Unique: rRpGYx5kNfei30sRJNTstg-1 Received: by mail-vs1-f71.google.com with SMTP id z9so268487vsl.3 for ; Tue, 20 Oct 2020 00:17:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DZzkxCW+7yNv6ebEK0T3tumKEQ44hjTaCgvLb94lZ8M=; b=hPvllxW8O4NNu5y6ca70E3pppCczabyqOPRm6GomRaZu/c1Be0Nw7ZCkCfdHngTpnb p5nOSVrBCNZzCC+kY+U9UxFmHhzaXfBZwM6QdLMTp/mz04xoppfNBCSd+ziRyspjGG1f +u78BKK9Sg9H1HRdyj3YiT4Qs33PjkLh8Bt/HQe3Dj9pxC9aQh65R2f4NI14s11Mh2So F7kmoEN0uCNje2QqA5UyJ1LumyDtwzSPmUdpFcI4Ce5mem9iqgXqv6gyJ+NOAxCdx+25 k3VBZeQSe6K7QdsGob61NN3amSAw4M9PItkpgh02rv8pFJG63k1We6EkRyif8UKqxnlj IGEQ== X-Gm-Message-State: AOAM5338OhDS9hBLwXhA74lgNh8IyS5IXeL4a3WdBDs2bYBIa4WztSz9 JmLXPIwUktM4dhBGhohHcjqeyN/++2XuKtu/XoOKlRTYK7W0i9acfWou8TC8eWvyT+xz+oC2GGG 3EFlRqVN6MCAXu2OEvK0= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr699776vsh.10.1603178243024; Tue, 20 Oct 2020 00:17:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZrUaSxkT5kjZfSQB6h3WX6wDjyOyXT6yxhwHIji7TXlxHPts2WoLgewX6tcjmryJVWngxU2QPSzUOViQuTsc= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr699761vsh.10.1603178242762; Tue, 20 Oct 2020 00:17:22 -0700 (PDT) MIME-Version: 1.0 References: <20200916164429.244847-1-bruce.richardson@intel.com> <20201015150554.950838-1-bruce.richardson@intel.com> <2393931.9fLth6X2y1@thomas> In-Reply-To: <2393931.9fLth6X2y1@thomas> From: David Marchand Date: Tue, 20 Oct 2020 09:17:11 +0200 Message-ID: To: Bruce Richardson Cc: dev , Andrew Rybchenko , "Yigit, Ferruh" , Luca Boccassi , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 0/8] Rework build macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 19, 2020 at 10:27 PM Thomas Monjalon wrote: > > 15/10/2020 17:05, Bruce Richardson: > > Following on from discussion in RFC v1 and v2 of this set, this version > > reworks the automated macros defined by meson to indicate if a > > particular library or driver is enabled in the build. However, while it > > does so, it also maintains compatibility with previous releases to ease the > > transition for any apps using the older macros, which already has to > > contend with a change in DPDK build-system and to switch over to picking up > > the library names from pkg-config. > > > > Advantages of this rework: > > * Much cleaner having standard macros > > * No need for defining the format of macros for each class > > * Shorter macros (for the most part) > > > > Disadvantages: > > * Potentially requires application changes > > * Inconsistency between the auto-defined macros and the other feature-set > > ones. > > > > Bruce Richardson (8): > > app: fix missing dependencies > > examples/l2fwd-crypto: fix missing dependency > > build: add defines for compatibility with make build > > qat: build from common folder > > build: remove library name from version map filename > > devtools/test-null: load all drivers from directory > > build: standardize component names and defines > > build: replace use of old build macros > > Applied, thanks kni compilation is broken, can you have a look? http://mails.dpdk.org/archives/test-report/2020-October/160621.html Thanks. -- David Marchand