From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00AFAA0567; Fri, 13 Mar 2020 14:12:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C6B1D1BF97; Fri, 13 Mar 2020 14:12:46 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id A5B1A2BAA for ; Fri, 13 Mar 2020 14:12:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584105165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IcsuHUD1xE+B76TsysmFCB3WirvDMVyJWkx9UpO0nzA=; b=dDyvcdATqAMI4KsZKbDhyfAl1977+QSYDro/6VIqGaKHDT0jD2pQMmU8Y6qmK4QZPDzPyI 87q9mV2d1W8W5Py3c1w6DWs393TxNrBbNh6goSLV8HzOASgZRIG5RuTv7e++3zT4tkX8By Nj9Ca+XRSkkND/g8Tdwdtn6IqDm5fwg= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-57-HNvTKTPyOxmgRA5ghOtB2Q-1; Fri, 13 Mar 2020 09:12:43 -0400 X-MC-Unique: HNvTKTPyOxmgRA5ghOtB2Q-1 Received: by mail-vk1-f199.google.com with SMTP id g131so3743554vke.2 for ; Fri, 13 Mar 2020 06:12:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0i3cQXor+PxCM7nSyJOPqHJ0T/HGprWPo8b3H50rjXI=; b=WsVu2S7oLDySThHygL5XFAyghEZzXWKtxF2sg+bjVDaJMdYKLlXytuImQafBlKdIOg PI6GClpdV4u+7+c1DXHErRMEfkqEYNnGrIJAdWKj6OrTF/k0QuYgQ0KtW3kq5197Aqz9 TQged79iTIekMSWjOYk/dRLPwAag1b9DNugXfEj2zl7f6q4fjFtRRp+Eomz0WjnMEEuw CURKvH9vqLFl8ek27l9B+U8uCScgrDB9amPij4Z45vKsxS1wcn8kvrZFv01kSeOQC8F8 pGz+xq6Gd2K0RQ0d9Bw6DR94zoljjMUNwKgcVfZtzdfjR7yeDCtXU0OJnsU/kzI3I3Zk /L5Q== X-Gm-Message-State: ANhLgQ0Y14ai909LA1TBOONTTrC/Pau5TcxGMuG/aZA0FmQLPETzjnVC ByEdzEd+f9lnv7Ol0ICDjD36kT6Uzkhr0PrB/OGa8KjKPtqmOLW59yIAbi+Cg2DWom1+Z0F0awZ MR/W6a0T5fZq7kvCq0OU= X-Received: by 2002:ab0:488b:: with SMTP id x11mr8063464uac.86.1584105163173; Fri, 13 Mar 2020 06:12:43 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt57cIxYh7gJadzEN94Sqmmz/Jyf5kBaVS51TspVOpz0CADdiKQLoYwidYfzKfcbSNmBAPYK+zqE75wqZVbJ8s= X-Received: by 2002:ab0:488b:: with SMTP id x11mr8063441uac.86.1584105162790; Fri, 13 Mar 2020 06:12:42 -0700 (PDT) MIME-Version: 1.0 References: <20200227170456.29164-1-ciara.power@intel.com> <78ab395921c74c3293ce6f0c77419d32@intel.com> In-Reply-To: <78ab395921c74c3293ce6f0c77419d32@intel.com> From: David Marchand Date: Fri, 13 Mar 2020 14:12:31 +0100 Message-ID: To: "Power, Ciara" Cc: "dev@dpdk.org" , "Pattan, Reshma" , "stable@dpdk.org" , "Laatz, Kevin" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] telemetry: fix struct reset after value assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 27, 2020 at 6:34 PM Laatz, Kevin wrote: > > > The ep struct is used to track what type of stats are required by the c= lient. > > For PORT_STATS type, it contains the lists of port and metric ids to qu= ery, and > > the number of ids in each list. > > > > The ep struct has values set (num of port and metric ids) when a reques= t for > > port stats values by name is received. However, after this value assign= ment, > > the struct is reset to all 0 values, meaning the number of port and met= ric ids > > required now both show as 0, and the client will not receive the reques= ted > > data in response. To fix this issue, the memset call is now moved above= the > > ep struct value assignment. > > > > Fixes: 4080e46c8078 ("telemetry: support global metrics") > > Cc: reshma.pattan@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Ciara Power > > Reviewed-by: Kevin Laatz Applied, thanks. --=20 David Marchand