From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com [209.85.221.169]) by dpdk.org (Postfix) with ESMTP id 1FA7C235 for ; Thu, 21 Feb 2019 16:50:53 +0100 (CET) Received: by mail-vk1-f169.google.com with SMTP id h128so6981683vkg.11 for ; Thu, 21 Feb 2019 07:50:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lx50OSgnVL62iXX7KcrsEVh8W9t3geJAKqcet58COLA=; b=pc2UFhkGOhAFgFuicGSBQlqr9DrkfxMe1IYFAlorLOM1STJQ4BnNorDuJ4ugowp8Nd dbaLE2FFwOaUyccY6g+C+4tFLUZgP1nRDbG7D46D36PQWGY0iYhQASHMT1uuJWYmhE9w fg3yu2r/qJfAmogLd34i6PZjQgv54KB3RsYqQ07Rnq7JfZ4MQaZHksWY9jQ2q5user50 6ITXL01blkWxmvYp8yltJiNGUy08SkHsMTwX5c7PD9gwL/5j+kUnDlNPXn8IyurHmPuG eQFWwpSSKGZT2m9ezLfeVkjJtHeTD7o9lLR+/qzEw+gZE6QvjRStx+Dy5ItSVEnGSEEq 8Ugw== X-Gm-Message-State: AHQUAubOO6a/hwbhtQ4QFGb9hwEqmO9nIi3Bb47180RclJEjL7RElpvd ffj3BSXwYAlY4xThcmmEc8NuO/Ckfx4sz+hIJYQB5w== X-Google-Smtp-Source: AHgI3IZti8XJJ1f1zvKlpH9BFb0TFpb45lfwxCqUH7vyjSwR+pC1uUgR5q2bBeq7NEl7mFtB6sW8IUXpX4/E6JpyhsU= X-Received: by 2002:a1f:7f10:: with SMTP id o16mr11508996vki.31.1550764253313; Thu, 21 Feb 2019 07:50:53 -0800 (PST) MIME-Version: 1.0 References: <33fcd6e0333f51e6fddb3351495c0ef4931b0c68.1550760032.git.shahafs@mellanox.com> In-Reply-To: <33fcd6e0333f51e6fddb3351495c0ef4931b0c68.1550760032.git.shahafs@mellanox.com> From: David Marchand Date: Thu, 21 Feb 2019 16:50:42 +0100 Message-ID: To: Shahaf Shuler Cc: "Burakov, Anatoly" , Yongseok Koh , Thomas Monjalon , "Yigit, Ferruh" , Neil Horman , Gaetan Rivet , dev@dpdk.org, Kevin Traynor Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 6/6] doc: deprecate VFIO DMA map APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 15:50:54 -0000 On Thu, Feb 21, 2019 at 3:51 PM Shahaf Shuler wrote: > As those have been replaced by rte_bus_dma_map and rte_pci_dma_unmap > APIs. > > Signed-off-by: Shahaf Shuler > --- > doc/guides/prog_guide/env_abstraction_layer.rst | 2 +- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > lib/librte_eal/common/include/rte_vfio.h | 6 ++++-- > 3 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst > b/doc/guides/prog_guide/env_abstraction_layer.rst > index 929d76dba7..6a1ddf8b4a 100644 > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > @@ -282,7 +282,7 @@ The expected workflow is as follows: > - If IOVA table is not specified, IOVA addresses will be assumed to be > unavailable > - Other processes must attach to the memory area before they can use > it > -* Perform DMA mapping with ``rte_vfio_dma_map`` if needed > +* Perform DMA mapping with ``rte_bus_dma_map`` if needed > * Use the memory area in your application > * If memory area is no longer needed, it can be unregistered > - If the area was mapped for DMA, unmapping must be performed before > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 1b4fcb7e64..f7ae0d56fb 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -35,6 +35,10 @@ Deprecation Notices > > + ``rte_eal_devargs_type_count`` > > +* vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs > which > + have been replaced with ``rte_bus_dma_map`` and ``rte_bus_dma_unmap`` > + functions. The due date for the removal targets DPDK 19.08. > + > * pci: Several exposed functions are misnamed. > The following functions are deprecated starting from v17.11 and are > replaced: > > diff --git a/lib/librte_eal/common/include/rte_vfio.h > b/lib/librte_eal/common/include/rte_vfio.h > index 54a0df5726..df139edea2 100644 > --- a/lib/librte_eal/common/include/rte_vfio.h > +++ b/lib/librte_eal/common/include/rte_vfio.h > @@ -190,6 +190,7 @@ int > rte_vfio_clear_group(int vfio_group_fd); > > /** > + * @deprecated > * Map memory region for use with VFIO. > * > * @note Require at least one device to be attached at the time of > @@ -210,11 +211,12 @@ rte_vfio_clear_group(int vfio_group_fd); > * 0 if success. > * -1 on error. > */ > -int > +int __rte_deprecated > rte_vfio_dma_map(uint64_t vaddr, uint64_t iova, uint64_t len); > > > /** > + * @deprecated > * Unmap memory region from VFIO. > * > * @param vaddr > @@ -231,7 +233,7 @@ rte_vfio_dma_map(uint64_t vaddr, uint64_t iova, > uint64_t len); > * -1 on error. > */ > > -int > +int __rte_deprecated > rte_vfio_dma_unmap(uint64_t vaddr, uint64_t iova, uint64_t len); > /** > * Parse IOMMU group number for a device > -- > 2.12.0 > > I don't know users of such apis, but you can't mark rte_vfio_dma_map as deprecated now. There is no stable alternative, rte_bus_dma_map() is experimental. This has been discussed and some patches are in progress about it. Last version: http://patchwork.dpdk.org/patch/50040/ -- David Marchand