From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 776CB41CEC; Mon, 20 Feb 2023 16:02:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12DF64306D; Mon, 20 Feb 2023 16:02:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5FFB343069 for ; Mon, 20 Feb 2023 16:02:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676905344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=seUBCUjNJ7fKj7ecf+ALkaAltbT8RpHVBgmSZs4ly0E=; b=HB/kdYQ4hV4fsHmk7jGtZGYB6DjZx0r2PpRcYtSENXOpOGa+JuTeXzZTsEQJyU21VCcRGK 5mCaVXmyIbkAO7rs44j1AswZ6261kdAR7xRYcSkOSOczZN/aCGSMiihpsclk4F7hQui817 11zh/NIhZomtVlrZKqmwjcdx6TKKJEU= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-640-rHBJ93MyPfCsF6UyRoKDVg-1; Mon, 20 Feb 2023 10:02:23 -0500 X-MC-Unique: rHBJ93MyPfCsF6UyRoKDVg-1 Received: by mail-pf1-f198.google.com with SMTP id d7-20020a056a0010c700b005a8ee90fbc6so809507pfu.4 for ; Mon, 20 Feb 2023 07:02:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676905342; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=seUBCUjNJ7fKj7ecf+ALkaAltbT8RpHVBgmSZs4ly0E=; b=i9PkY0kmHeHOIUr39HSOC1W2lYj30s91MiW72iPm/KFusIy5OyZdmIzdA7So4mGVL0 tPg8Iut6PyLS9wAB/IY07iLkSgPOl8pNkCGBP7NLMiREBwwhSfDGlz//gp/gCbeMJCMd Ivo0jEuOmXiWLHvVypbpSBffepgJk4ER/iBy5DkAumaC2rPjhly4K5Y8hdVpW3Zfxkcy KJojNeL9Tb7aOoFjnmDAvYAaKudtrTHeqPu5QU/2t1AD556oqSR6ozmurj8fN3gp+T+E 5knLKZks6VFsQZJUL6VwgrG6GfFaNSXj3eIne3IphnDvMysuX+sp5y8NHA6n0PIqVBOD SZbA== X-Gm-Message-State: AO0yUKXuB5QnryeEnL7cnz/GMmJFVv/DEb67+GNPxH1lUl53fDmLJMRj 9Suv++39dt9QbqW0FdXl3U4esk7cGqELoE+IkedsQaAb7Key36mQLB6g3YIT2WsEJBO/whgRQhu 3kXwjPcD9B+btn3LdXx8= X-Received: by 2002:a17:902:820c:b0:19b:98ce:48e9 with SMTP id x12-20020a170902820c00b0019b98ce48e9mr64307pln.24.1676905341978; Mon, 20 Feb 2023 07:02:21 -0800 (PST) X-Google-Smtp-Source: AK7set+Z1cvb3Cvj1+qBongxvEZf+IIpstm1QgoXusYQaGgFI8fbTQPkNY5vP3F2a+RUgq8u2MtANKLPrQgqqMy064M= X-Received: by 2002:a17:902:820c:b0:19b:98ce:48e9 with SMTP id x12-20020a170902820c00b0019b98ce48e9mr64300pln.24.1676905341624; Mon, 20 Feb 2023 07:02:21 -0800 (PST) MIME-Version: 1.0 References: <20230124104742.1265439-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 20 Feb 2023 16:02:10 +0100 Message-ID: Subject: Re: [PATCH 0/6] Testpmd code cleanup To: Ferruh Yigit Cc: Robin Jarry , dev@dpdk.org, Aman Singh , Yuying Zhang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Robin, Ferruh, On Tue, Feb 14, 2023 at 7:22 PM Ferruh Yigit wrote: > > On 1/25/2023 1:50 PM, Robin Jarry wrote: > > David Marchand, Jan 24, 2023 at 11:47: > >> Here is a series to reduce code duplication in testpmd. > >> > >> This work started from looking at Robin series on reporting lcore busy > >> cycles in telemetry, which is then added in testpmd [1]. While looking > >> at the forward engines code, I saw way too much duplicated code. > >> > >> Warning: this is only compile tested. > >> > >> 1: > >> https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-rjarry@redhat.com/ > > > > Hi David, > > > > The code looks good to me. I have made some basic testing, it seems not > > to break obvious things. > > > > Reviewed-by: Robin Jarry > > > > Hi Robin, > > This set conflicts with your set which is merged [1], I guess your test > was before your patch merged. Can you please check again after rebase? > The rebase (that I will send later) needs some eyes indeed. -- David Marchand