From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FBFFA00C2; Fri, 1 Jul 2022 10:30:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CB2840A7B; Fri, 1 Jul 2022 10:30:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9DC9F40150 for ; Fri, 1 Jul 2022 10:30:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656664248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M7rOVVEdTNYVhHazjs0euo2z0piL0jY3BZxsee/uKRo=; b=Z+hwM+ZgRcwaNkf7zjiBJjL790O5r8nts5HjvbnWOp2ck5+dLMgH1VyWYEVJr7eBqZXrax ptYUJHVPSXCEWuWoUcmNa8VCPIj6qYki6jIypyqrrMA3bSyxvGOtgMKgt4CyDtsvGNm+Lj CSVwi0ExTgzC26HysMXUlsT8DM9bzaI= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-287-U_WG1XC8OjmAVH1jgrtN6g-1; Fri, 01 Jul 2022 04:30:46 -0400 X-MC-Unique: U_WG1XC8OjmAVH1jgrtN6g-1 Received: by mail-lf1-f72.google.com with SMTP id o22-20020a05651205d600b004810c974c17so819538lfo.23 for ; Fri, 01 Jul 2022 01:30:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M7rOVVEdTNYVhHazjs0euo2z0piL0jY3BZxsee/uKRo=; b=KFd/knqMwYnmguLRID8mQvv8pz2raMvH4Tyows/WT/j2W1ozPxuGMgl0P0QUOXp1pv t0QOdZMslJVS1bf9j9QyUzT8DySF8vnRzdtBHAb23dqbPsdw8OY2lE3gDJ4qoGETfRWj TtiNtYJMX4Dt1xmKwVOUCRwkeQEZ2On+qRttu0Im1jGshvhxhmsDPjSdGXqdXv1H17E5 i6dF8WMSdYUx1/4BBQqn1pudU+yNrhgwsBK6AU35hWDPBzX6ZDN2LdS1PDu+MiMkFGJa 65zfGJlo5H+Wpl38dqIB8t0g5Ex+8h5d9J2M5GrVnbhKkj5KIUIevAZtHgLna40Ac0js PkpA== X-Gm-Message-State: AJIora8uWvs6v7EEg01gHrkRyJBWVZ1oIxF6kau0SjVcnUX4LiOgUIWh kFUAHO094WJuc9ciV9e6skftODYKW6mTO/B3+fzcoJFMZgB1GICJQRQUNgoopkxghoB2pyM3E4N Iol6Ps6KGrM9j7s0pEbs= X-Received: by 2002:ac2:51a5:0:b0:47f:79a1:5c02 with SMTP id f5-20020ac251a5000000b0047f79a15c02mr8336372lfk.575.1656664245159; Fri, 01 Jul 2022 01:30:45 -0700 (PDT) X-Google-Smtp-Source: AGRyM1utyxeeZsWd0/e2xOolsCk38V2hsNUf24tbWp5IQCTg96cHoXrDsls+G9/D5E7tr+uVSCRoA8sOmUlizYAiLv8= X-Received: by 2002:ac2:51a5:0:b0:47f:79a1:5c02 with SMTP id f5-20020ac251a5000000b0047f79a15c02mr8336358lfk.575.1656664244966; Fri, 01 Jul 2022 01:30:44 -0700 (PDT) MIME-Version: 1.0 References: <20220620131044.1858049-1-david.marchand@redhat.com> In-Reply-To: <20220620131044.1858049-1-david.marchand@redhat.com> From: David Marchand Date: Fri, 1 Jul 2022 10:30:33 +0200 Message-ID: Subject: Re: [PATCH] vdpa/mlx5: fix leak on event thread creation To: Matan Azrad , Viacheslav Ovsiienko , Xueming Li Cc: dev , dpdk stable , Maxime Coquelin , Raslan Darawsheh Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 20, 2022 at 3:11 PM David Marchand wrote: > > As stated in the manual, pthread_attr_init return value should be > checked. > Besides, a pthread_attr_t should be destroyed once unused. > > In practice, we may have no leak (from what I read in glibc current code), > but this may change in the future. > Stick to a correct use of the API. > > Fixes: 5cf3fd3af4df ("vdpa/mlx5: add CPU core parameter to bind polling thread") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Review, please? -- David Marchand