From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97477A0350; Wed, 1 Jul 2020 11:11:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 737BD1C2B8; Wed, 1 Jul 2020 11:11:53 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 0DA921C2AA for ; Wed, 1 Jul 2020 11:11:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593594711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fi8cNyipLMTvV6xjti74eSJ3QGm4Gegxi6rj8Yel9/8=; b=JKwjBDMDPtE2Ni9e0tjEbX/28cL3HRn0kR7a2ROvgU/mOt5UGifo+qRv/oLhPNFOxCFVzP LVGObYohLRPchvtJXIQ7iDs72bAkeVtgCRFt0j1/7cG5EA68ck+zeW2lMsmWIOu2HJlyb7 AlmxsTzPJjeDpSmIg3lpVZo8iMs+d0w= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-kkYYZKKpMlaHshREVeP5fg-1; Wed, 01 Jul 2020 05:11:50 -0400 X-MC-Unique: kkYYZKKpMlaHshREVeP5fg-1 Received: by mail-vs1-f71.google.com with SMTP id p124so2281597vsp.4 for ; Wed, 01 Jul 2020 02:11:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fi8cNyipLMTvV6xjti74eSJ3QGm4Gegxi6rj8Yel9/8=; b=QJA43gSVThqKOsTA3iSR8ED45CD77FctrrWtG9qw8/NqsBffKz9SiypEOAMU1bXTSM 6Pf2yJPkrhDhInR0/wFk7NhVl1voKfkZJ3g2cdZhzi+yhxbXXBsuSI+TL9F4/UXtIrkk hO0G45163RSSjCk51WQ5aae9xFaTxaswNupgo51Ip3GpBIeq8uvWOTtNOjnNVpfaPacd nhsIzW0FU80LKVsp3kJHrYrDyjnkdiTpJ4uzw9X6lRttfJg9EzWhQUiJKw87R4EKwddZ aY1TdRu/0pcMd07lu2EzD+swj5AbECsSWFD5D+TvjWzk7VbgkTmeTRW5LWEMYeP7yGYt QYpA== X-Gm-Message-State: AOAM532eOcYZ7fvBp+fYoelJX8g2aLJOuSe2ryT9cYbxS1NHwtKjTuAh Yi3X3Pv6XbYZuNa/QN3wFKR0vVuL9Mv/QuU4AS48DrWpl1dzKX3qISqOhlyUmtWeeYc4bRR4rkw QGZOS3EjlUnKXYL0abiw= X-Received: by 2002:a67:c990:: with SMTP id y16mr18997634vsk.105.1593594709919; Wed, 01 Jul 2020 02:11:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxk/5z3LK5dRoDyQJ13mjPxY0E22gSyQ78PShCUnTnobKytIOpvrleSfh7ZRPxHurOypnOLU8RxwxOpow3WFrA= X-Received: by 2002:a67:c990:: with SMTP id y16mr18997527vsk.105.1593594707702; Wed, 01 Jul 2020 02:11:47 -0700 (PDT) MIME-Version: 1.0 References: <20200527145745.4060-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Wed, 1 Jul 2020 11:11:36 +0200 Message-ID: To: Bruce Richardson Cc: dev , "Pattan, Reshma" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] app/test: fix build with ring pmd but no bond pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 29, 2020 at 12:09 PM David Marchand wrote: > On Wed, May 27, 2020 at 4:58 PM Bruce Richardson > wrote: > > > > If the bonding pmd is disabled, all autotest associated with it should be > > disabled. However, some of those tests also depended upon the ring PMD so > > were placed in a block depending on that driver - and unfortunately that > > driver alone. This caused build failures if the ring PMD was enabled but > > the bonding PMD disabled, due to missing header files and driver libs. > > > > This error can be reproduced by configuring DPDK using e.g. > > > > meson configure -Ddisable_drivers=net/[!r]* build > > > > (which will disable all drivers not starting with "r"), and then building > > using ninja. > > > > Fix this by moving all link bonding autotests to the one block and putting > > a second conditional check within that block for those also requiring the > > ring PMD. > > > > Fixes: 7f6ef1664027 ("test/bonding: allow disabling driver") > > Fixes: 207b1c813f39 ("test: fix build without ring PMD") > > > > Signed-off-by: Bruce Richardson > Reviewed-by: David Marchand Applied, thanks. -- David Marchand