From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E942A32A2 for ; Thu, 24 Oct 2019 15:12:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49D641EA8E; Thu, 24 Oct 2019 15:12:38 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 480D21EA65 for ; Thu, 24 Oct 2019 15:12:36 +0200 (CEST) Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9BF6A369AC for ; Thu, 24 Oct 2019 13:12:35 +0000 (UTC) Received: by mail-vs1-f69.google.com with SMTP id c15so5276985vse.16 for ; Thu, 24 Oct 2019 06:12:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t46jrebigvzPlel6ZmyGzFpwSDfgNws+3aiSTmzQBoY=; b=BGUjurIY3JlJMedF4EECDI9g5tOGT8821U1gsUkHXF6k2ZdH1vMtJGN6v/q0DcN5UN BfZRF2JFYGNSx66HXqbouDFv9BA/etJiDLY0E5E0xCjI765uwG5xPaqiDLBHEIsZxfUY USwx4XutD7pFjeEiht2K2RsH8D7MUF7FwWsDX/wohttmCv/yRL60xz5Q1cDRq4caaKMq QXyL8uu1XWFSTDyZI0gmzxXNPloK9Ob9wDrZCTq28n67mcc/GMml0cL+3Asfcxymy/v3 axNJ9fzPCBNyHcmHaGwiGIifGeCwCAhgLZPOl49gO+jUe25k20QPZg8KfIXurP794exk FoZA== X-Gm-Message-State: APjAAAWmG0ScC8KQOWF8sxOjoC3hERVgmOhBWlWGN3KYiHivq2lrSjh5 Nxo+yZx5Li6t/Lt6LONObmu9j1l0SwnxWZXVquqSTbwayBaE+3r1/MMlBWi2jZQr1K/aZPf8vA3 kT5l/0NVZKg2Zvrtog6E= X-Received: by 2002:a67:fa99:: with SMTP id f25mr2030683vsq.141.1571922754748; Thu, 24 Oct 2019 06:12:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqzuk08u6AIHLaVlntCEmr3+FR1xT/GZBOKHfO8+ERfHPHtMM7WCOlOHpyWBNFXXtnmlUx4+/X3D3QvQVe3iyM8= X-Received: by 2002:a67:fa99:: with SMTP id f25mr2030653vsq.141.1571922754351; Thu, 24 Oct 2019 06:12:34 -0700 (PDT) MIME-Version: 1.0 References: <20191023172637.10410-1-pbhagavatula@marvell.com> In-Reply-To: <20191023172637.10410-1-pbhagavatula@marvell.com> From: David Marchand Date: Thu, 24 Oct 2019 15:12:23 +0200 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob Kollanukkaran , Aaron Conole , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] app/test: decrease iterations in reciprocal division test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 23, 2019 at 7:26 PM wrote: > > From: Pavan Nikhilesh > > Decrease max iterations in reciprocal division test to reduce the > runtime. > Update fast_test_names to include reciprocal division. > > Signed-off-by: Pavan Nikhilesh > --- > app/test/meson.build | 2 +- > app/test/test_reciprocal_division.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test/meson.build b/app/test/meson.build > index 2c23c6347..fa4945189 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -197,6 +197,7 @@ fast_test_names = [ > 'per_lcore_autotest', > 'prefetch_autotest', > 'rcu_qsbr_autotest', > + 'reciprocal_division', > 'red_autotest', > 'ring_autotest', > 'ring_pmd_autotest', > @@ -243,7 +244,6 @@ perf_test_names = [ > 'memcpy_perf_autotest', > 'hash_perf_autotest', > 'timer_perf_autotest', > - 'reciprocal_division', > 'reciprocal_division_perf', > 'lpm_perf_autotest', > 'red_all', > diff --git a/app/test/test_reciprocal_division.c b/app/test/test_reciprocal_division.c > index 8ea9b1d24..bea021972 100644 > --- a/app/test/test_reciprocal_division.c > +++ b/app/test/test_reciprocal_division.c > @@ -13,7 +13,7 @@ > #include > #include > > -#define MAX_ITERATIONS (1ULL << 32) > +#define MAX_ITERATIONS (1ULL << 16) > #define DIVIDE_ITER (100) > > static int > -- > 2.17.1 > Before patch: Started: Thu Oct 24 08:57:19 EDT 2019 RTE>>reciprocal_division Validating unsigned 32bit division. Validating unsigned 64bit division. Validating unsigned 64bit division with 32bit divisor. Division failed, 15093057378844257455/14466 = expected 1043346977661015 result 1043346977661016 Validating division by power of 2. Test Failed Ended: Thu Oct 24 09:01:51 EDT 2019 After patch: Started: Thu Oct 24 09:08:58 EDT 2019 RTE>>reciprocal_division Validating unsigned 32bit division. Validating unsigned 64bit division. Validating unsigned 64bit division with 32bit divisor. Validating division by power of 2. Test OK Ended: Thu Oct 24 09:08:58 EDT 2019 This is quicker, but if we don't have the right coverage, this is a -1 for me. -- David Marchand