From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, Eelco Chaudron <echaudro@redhat.com>,
Aaron Conole <aconole@redhat.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [RFC PATCH] app/testpmd: only lock text pages
Date: Tue, 10 Mar 2020 16:11:09 +0100 [thread overview]
Message-ID: <CAJFAV8z=mMhoE_0NaV2CMFA2zTEFLpwY7=JftKc944-V=1V9=g@mail.gmail.com> (raw)
In-Reply-To: <4388d10a-9f54-5a27-8d9d-4581ebeb283c@intel.com>
On Tue, Mar 10, 2020 at 4:08 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >> +1 to the idea, testpmd initialization was taking too lock without
> >> '--no-mlockall', but this code looks complex for the application level.
> >>
> >> We can do this for testpmd but does all applications need to do something
> >> similar? If so can we have a solution on eal level instead?
> >
> > I submitted a patch on the EAL side.
> > This makes mlockall way lighter, since it skips pages marked with PROT_NONE.
> > http://patchwork.dpdk.org/patch/66469/
> >
>
> Cool,
>
> With that patch timing improves a lot, in my system testpmd initialization
> reduced from 38s to 9s. (it was 6s with --no-mlockall).
>
> Do we still need this testpmd patch?
My intention is to drop this RFC once Anatoly gives a ACK on the EAL side.
--
David Marchand
prev parent reply other threads:[~2020-03-10 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 14:48 David Marchand
2020-03-10 14:48 ` Ferruh Yigit
2020-03-10 14:55 ` David Marchand
2020-03-10 15:08 ` Ferruh Yigit
2020-03-10 15:11 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z=mMhoE_0NaV2CMFA2zTEFLpwY7=JftKc944-V=1V9=g@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).