From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8D5542C54; Wed, 7 Jun 2023 22:21:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B01641611; Wed, 7 Jun 2023 22:21:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 99D8F410D0 for ; Wed, 7 Jun 2023 22:21:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686169295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OXBHKFQrEQIQPpPKZQ52RNQptQ6qSaTNzFFA/UytbYc=; b=jRZ1fXCpnWU39L2oYDts9x6ooDgaDjvzlD0IvHo7VxsYa53+8QofO2BeSXI6ppd8mkj40A 8PkWCu6H8Upk8NN43ileMMRGiu/3GgDh8t4hli839safDxR5KPHD60bYrVfJGLw+6loSf2 YmWcY4m+fOgA07dbF4MIJnS9P2czX9U= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-gP5Hj5RtO6axTGDpEbIkZA-1; Wed, 07 Jun 2023 16:21:33 -0400 X-MC-Unique: gP5Hj5RtO6axTGDpEbIkZA-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-256a43693e7so2493046a91.2 for ; Wed, 07 Jun 2023 13:21:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686169292; x=1688761292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OXBHKFQrEQIQPpPKZQ52RNQptQ6qSaTNzFFA/UytbYc=; b=NAXvt7o6JbmWaKcVwjHnpyguIt8x9ZdO/aJ9n7vD1/Jn8DPXuScIh0BJdKp2yHgUjV 5xpbbwPX+GUAKq3HPzHF+Kq/nI7NHkzu2TFg/mJTtu6G3L/2r9sLTgOVrd0gvi3sHqvY FpZmAgkPVSqTknYfDUhrapjfuOtSiOXM8zauHu5AqVcbCqjy8lxMP+4oPbO5yo6exekS KYXq8LKXHs4oqS5Y7BVALnWzSOSRo7tsjFE0YTwB11N7AWLpzmr604rxEG9NM0tJvVwe vkTn7/uYRqw7xv8aFSakBC9yTTAh7CO/5yVDAoNDubHc9ZuqWTN7ox6MNlLuNmLud8CX 489A== X-Gm-Message-State: AC+VfDx5gTDhf8hVAryt+QnK65oXtRC69WThBFBe7q1GboQZLslm0izw TYf+EJ6Apz4gjPR46xh4mQyD/on4gqqMy4RCttpZqmYT7VWV/Wc2lLjfq5/0TjSvFypNN0ZGQ3l bOl4bOYhs2rrp9W3kjpM= X-Received: by 2002:a17:90a:fa81:b0:259:aa8f:9f27 with SMTP id cu1-20020a17090afa8100b00259aa8f9f27mr2224441pjb.24.1686169292669; Wed, 07 Jun 2023 13:21:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4uIakv5MlQyhsmv4FABuOSYRAaBSfoFi0FB3yF2ebvzcjTVkHLt+9dZpSg27IDu6dxb8UQbJ39LlI0YTX28VU= X-Received: by 2002:a17:90a:fa81:b0:259:aa8f:9f27 with SMTP id cu1-20020a17090afa8100b00259aa8f9f27mr2224428pjb.24.1686169292358; Wed, 07 Jun 2023 13:21:32 -0700 (PDT) MIME-Version: 1.0 References: <20230531065506.63021-1-wangzhihong.wzh@bytedance.com> In-Reply-To: <20230531065506.63021-1-wangzhihong.wzh@bytedance.com> From: David Marchand Date: Wed, 7 Jun 2023 22:21:21 +0200 Message-ID: Subject: Re: [PATCH] eal/linux: register mp hotplug callback after memory init To: Zhihong Wang Cc: dev@dpdk.org, anatoly.burakov@intel.com, qi.z.zhang@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Zhihong, On Wed, May 31, 2023 at 8:55=E2=80=AFAM Zhihong Wang wrote: > > Secondary would crash if it tries to handle mp requests before memory > init, since globals such as eth_dev_shared_data_lock are not accessible > to it at this moment. Can you please resend this patch with a SoB ? Thanks. --=20 David Marchand