From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A017642661; Thu, 28 Sep 2023 14:50:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7854B40273; Thu, 28 Sep 2023 14:50:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 08A334021D for ; Thu, 28 Sep 2023 14:50:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695905425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dJQjaX5Yunh6CfBehNixcgSsqVvc4H3ORdLwuR1pMPY=; b=ZAH9mzVt2A8kDO/A3DSLdGYbVr7PMh2FVjTBapBDP1X9o7IOoTAX2l1Yt0MJye4lJ3FVXx q6cTBSBdzUiBfegCSBKJiTXpHNiU8O8Gja+EnEqX6JofrBYIDaV+CGu+q1Zz6rmnA9hKIe A+XZMzaHuXip1zYfZzoNsocnezKjD9k= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-6V5n3qriOXKzJULsIjp6aw-1; Thu, 28 Sep 2023 08:50:24 -0400 X-MC-Unique: 6V5n3qriOXKzJULsIjp6aw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c12c3e4595so180290441fa.1 for ; Thu, 28 Sep 2023 05:50:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695905423; x=1696510223; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dJQjaX5Yunh6CfBehNixcgSsqVvc4H3ORdLwuR1pMPY=; b=tn0UZizWxOOV3Fwa6ahdmgzn5z6LBb30RysYc2AY0yPQ5hFRkiLKNbv6Wf4PbFD3AQ mwmW4Zb9zbkv8eVFFutvj2ZzjvgLQ7a1drokTH5UPUB9qkjAaduZz+iAog+RXFUtz8qx oTpO46qIbK+6FSnMBEQBuBnnJkKFLKUe295lON3pPwTknZOusJZtobRxTwNL4p4iHqqo I0rN4n1etWtEJnoT5CVlcemDfSkuD+v4quBjZ51xAlkUDfvIfPUhaK5PMuAXXD9BgU1b eTkZlvbVyZIUKXPRabKsYRA9MHpQQnLzuJJdpGjLvAmkYDHxRNacoFhEoTfkw5YNDhbB PJRA== X-Gm-Message-State: AOJu0YzO7LZh30Wb/5OIVlvSDn19CwGbKVcN4l3IylzOyanlutvNZsKj OIVbvwNJgCeqbrbUcHUnZ8gG0lKsA5QV7vc1Zjvvuo3vIu3TX2IQLXr0qaGtuLaHwiUc1O3dDSP e/Afy62na4i5WrDj00xg= X-Received: by 2002:a2e:2419:0:b0:2b6:e2e4:7d9a with SMTP id k25-20020a2e2419000000b002b6e2e47d9amr1122374ljk.38.1695905422759; Thu, 28 Sep 2023 05:50:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCh3Bg8gaWehSJ1p3NonuMFE3oJvp6bxtXzFhWEJB/1QmNRmT225roBR4I5X+xHSYwwQcqkFJXztorJvHiE68= X-Received: by 2002:a2e:2419:0:b0:2b6:e2e4:7d9a with SMTP id k25-20020a2e2419000000b002b6e2e47d9amr1122361ljk.38.1695905422450; Thu, 28 Sep 2023 05:50:22 -0700 (PDT) MIME-Version: 1.0 References: <20230928092639.162449-1-bruce.richardson@intel.com> <20230928110450.862698-1-bruce.richardson@intel.com> In-Reply-To: <20230928110450.862698-1-bruce.richardson@intel.com> From: David Marchand Date: Thu, 28 Sep 2023 14:50:11 +0200 Message-ID: Subject: Re: [PATCH 1/2] app/test: add support for optional dependencies To: Bruce Richardson , gakhil@marvell.com Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 28, 2023 at 1:05=E2=80=AFPM Bruce Richardson wrote: > > Some tests make optionally use a component but don't require it for s/make // > building. If we include the dependency in the per-file lists, then tests > may be unnecessarily omitted, as the dependency is not required. > On the other hand, removing the optional dependency from the list can > cause build failures, as the test case may include the optional code, > but then fail to build as the build system won't have added the necessary > paths for header inclusion, or the necessary libraries for linking. > > Resolve this by explicitly providing a list of optional dependencies. > Any items in this list will be added to the dependency list if > available, but otherwise won't be involved in enable/disable of specific > tests. > > Signed-off-by: Bruce Richardson For the series, Reviewed-by: David Marchand Akhil can you confirm this series works for you? Thanks! --=20 David Marchand