From: David Marchand <david.marchand@redhat.com>
To: Apeksha Gupta <apeksha.gupta@nxp.com>
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 1/4] drivers/net/enetfec: Introduce NXP ENETFEC driver
Date: Fri, 2 Jul 2021 15:55:48 +0200 [thread overview]
Message-ID: <CAJFAV8zAu8N1XuRAjNqnq-Ze9D5HAKSsevvHOuZPSu2L5KE_6w@mail.gmail.com> (raw)
In-Reply-To: <a2338555-b9af-4c0b-3314-c9e8f294d268@oktetlabs.ru>
On Tue, Jun 8, 2021 at 3:10 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
> > +RTE_PMD_REGISTER_VDEV(ENETFEC_NAME_PMD, pmd_enetfec_drv);
> > +RTE_PMD_REGISTER_PARAM_STRING(ENETFEC_NAME_PMD, ENET_VDEV_GEM_ID_ARG "=<int>");
> > +
> > +RTE_INIT(enetfec_pmd_init_log)
> > +{
> > + enetfec_logtype_pmd = rte_log_register("pmd.net.enetfec");
> > + if (enetfec_logtype_pmd >= 0)
> > + rte_log_set_level(enetfec_logtype_pmd, RTE_LOG_NOTICE);
>
> rte_log_register_type_and_pick_level() should be used.
>
> > +}
Please prefer RTE_LOG_REGISTER_DEFAULT().
Thanks.
--
David Marchand
next prev parent reply other threads:[~2021-07-02 13:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 4:34 [dpdk-dev] [PATCH 0/4] drivers/net: add " Apeksha Gupta
2021-04-30 4:34 ` [dpdk-dev] [PATCH 1/4] drivers/net/enetfec: Introduce " Apeksha Gupta
2021-06-08 13:10 ` Andrew Rybchenko
2021-07-02 13:55 ` David Marchand [this message]
2021-07-04 2:57 ` Sachin Saxena (OSS)
2021-04-30 4:34 ` [dpdk-dev] [PATCH 2/4] drivers/net/enetfec: UIO support added Apeksha Gupta
2021-06-08 13:21 ` Andrew Rybchenko
2021-07-04 4:27 ` Sachin Saxena (OSS)
2021-04-30 4:34 ` [dpdk-dev] [PATCH 3/4] drivers/net/enetfec: queue configuration Apeksha Gupta
2021-06-08 13:38 ` Andrew Rybchenko
2021-07-04 6:46 ` Sachin Saxena (OSS)
2021-04-30 4:34 ` [dpdk-dev] [PATCH 4/4] drivers/net/enetfec: add enqueue and dequeue support Apeksha Gupta
2021-06-08 13:42 ` Andrew Rybchenko
2021-06-21 9:14 ` [dpdk-dev] [EXT] " Apeksha Gupta
2021-07-05 8:48 ` [dpdk-dev] " Sachin Saxena (OSS)
2021-05-04 15:40 ` [dpdk-dev] [PATCH 0/4] drivers/net: add NXP ENETFEC driver Ferruh Yigit
2021-07-04 2:55 ` Sachin Saxena (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zAu8N1XuRAjNqnq-Ze9D5HAKSsevvHOuZPSu2L5KE_6w@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=apeksha.gupta@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).