From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98BB645AE1; Tue, 8 Oct 2024 10:34:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 628E04021F; Tue, 8 Oct 2024 10:34:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 423974021E for ; Tue, 8 Oct 2024 10:34:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728376450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TDTLyA4fG79lUjvxGWjOgD1q1eNl3LMavR+kdMbf2lg=; b=PmDbZHhKRUN6q3IQz8vHmo8lRZD0VGB5KYfHSsucuUwek+pYn5FMWoaDmnGE8U+jWK7xLD TBJs7TUmS3TOdDSXO73sSIeecJxsFwWcTReawTAks8NASEoupvpIKC9L/UUQ9Myx4euPcX PlBsG8UTyakmqYPcE7lplQ91CgWIyss= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-49-PWHjX_uNMzioN11rxhoePA-1; Tue, 08 Oct 2024 04:34:09 -0400 X-MC-Unique: PWHjX_uNMzioN11rxhoePA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2fac69bee10so40458961fa.0 for ; Tue, 08 Oct 2024 01:34:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728376448; x=1728981248; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TDTLyA4fG79lUjvxGWjOgD1q1eNl3LMavR+kdMbf2lg=; b=OBVMsbAsy7tI9zmw1/3FTyw35DKEW3LcDW25x5xj/RGQluOysOZcnpGw3fDMx5lVfW Sqdt9ca6LH0MYW/mKiYfaN3wa5ivZq/ahWKCc/bMYONnHk6WYdwzFOWcJh0nki9eEY9n uYkY+EvZXDnllW5sxxRq5zIMMNnbzZcS7rOwgYV8JWuhJA/RzftqI0vbUVFlFY8BW5oD qM46vklwcrx1BmQ6g+GTNe7s8n+93kTFDpkuyvTs3n4Np7qAgjiplG7i8faY89VsuMlA er5TNx2xMCBEdC7yQeISP2mlYNcpnWCzO5E3coogwGC61H7L+l0q3+Yt7Bb9PZ6TSKiW 1ItA== X-Gm-Message-State: AOJu0YzqVR/LAdCACj1XPb4zmis7kxlPiNAjxKpyGsZX9aOM9fqIBqcq XwYPVO/EIknuzY/8AkjsGn6/u4gQirehzUho+UQoMBoQvFIAWIz3PgJVeS8xP29Mv0qYp0DUwYP Rxz3B6XJ+3biaaNKqNOQtdwEERKRyUonx8Kb4Myz8cE3o08K8v/5qIVV9CWh+j44poiLf1Dpr4I iBuv2FIUPM+myvCFQ= X-Received: by 2002:a05:651c:1549:b0:2fa:bd30:1928 with SMTP id 38308e7fff4ca-2faf3d98da0mr67084691fa.32.1728376447858; Tue, 08 Oct 2024 01:34:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxSnBvwmnwljRDM5pJkzv0lfU0WYfZPfyNy7/mPSjLsq/yKgecI73fUYWt+fBdenfXzpZUR7ES95K7rHlvA5I= X-Received: by 2002:a05:651c:1549:b0:2fa:bd30:1928 with SMTP id 38308e7fff4ca-2faf3d98da0mr67084541fa.32.1728376447451; Tue, 08 Oct 2024 01:34:07 -0700 (PDT) MIME-Version: 1.0 References: <20240920125737.1197969-1-bruce.richardson@intel.com> <20240920125737.1197969-4-bruce.richardson@intel.com> In-Reply-To: <20240920125737.1197969-4-bruce.richardson@intel.com> From: David Marchand Date: Tue, 8 Oct 2024 10:33:56 +0200 Message-ID: Subject: Re: [PATCH 3/5] build: remove unnecessary version checks To: Bruce Richardson Cc: dev@dpdk.org, mb@smartsharesystems.com, thomas@monjalon.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 20, 2024 at 2:58=E2=80=AFPM Bruce Richardson wrote: > > Since minimum meson version is now 0.57 we can remove all version checks > for versions lower than that. > > Signed-off-by: Bruce Richardson > --- > config/meson.build | 2 +- > doc/api/meson.build | 2 +- > drivers/meson.build | 3 --- > lib/meson.build | 6 ------ > 4 files changed, 2 insertions(+), 11 deletions(-) > > diff --git a/config/meson.build b/config/meson.build > index 8c8b019c25..913825b1ca 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -97,7 +97,7 @@ eal_pmd_path =3D join_paths(get_option('prefix'), drive= r_install_path) > if not is_windows > meson.add_install_script('../buildtools/symlink-drivers-solibs.sh', > get_option('libdir'), pmd_subdir_opt) > -elif meson.version().version_compare('>=3D0.55.0') > +else > # 0.55.0 is required to use external program with add_install_script Nit: this comment can be removed (I intend to do when applying). > meson.add_install_script(py3, > files('../buildtools/symlink-drivers-solibs.py'), --=20 David Marchand