DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	 Pallavi Kadam <pallavi.kadam@intel.com>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	 "Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
	Luc Pelletier <lucp.at.work@gmail.com>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values
Date: Mon, 12 Apr 2021 12:07:52 +0200	[thread overview]
Message-ID: <CAJFAV8zB4Eee7_DpU1izZiLh1X1qATcMr=Rn9mPk5kz2cqJeBg@mail.gmail.com> (raw)
In-Reply-To: <20210410195433.13416-1-talshn@nvidia.com>

On Sat, Apr 10, 2021 at 9:55 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
> The macro definitions of the following pthread functions
> return incorrect values from the inner function return code.
> while pthread_barrier_init, pthread_barrier_destroy and
> pthread_cancel return 0 in a case of success and non zero (errno) value
> otherwise the shimming functions InitializeSynchronizationBarrier,
> DeleteSynchronizationBarrier and TerminateThread return FALSE (0)
> in a case of failure and TRUE(1) in a case of success.
> This issue was undetected as none of the functions return codes was
> checked until such check was added in commit 34cc55cce6b1 ("eal: fix
> race in control thread creation") exposing the issue by failing
> pthread_barrier_init and rte_eal_init on Windows as a result.
> The fix aligned the return value of the 3 function with the expected
> pthread API return values.
> Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
> Fixes: 34cc55cce6b1 ("eal: fix race in control thread creation")

Only the first Fixes: makes sense.
The second commit you refer to relies on a working pthread implementation.

David Marchand

  parent reply	other threads:[~2021-04-12 10:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 19:54 Tal Shnaiderman
2021-04-11 21:00 ` Dmitry Kozlyuk
2021-04-12  7:59   ` Tal Shnaiderman
2021-04-12  8:25     ` Thomas Monjalon
2021-04-12 10:03     ` Dmitry Kozlyuk
2021-04-12 10:07 ` David Marchand [this message]
2021-04-12 10:26   ` Tal Shnaiderman
2021-04-12 10:37 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2021-04-12 20:38   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zB4Eee7_DpU1izZiLh1X1qATcMr=Rn9mPk5kz2cqJeBg@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=lucp.at.work@gmail.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=stable@dpdk.org \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).