From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] kni: fix build with Linux 6.3
Date: Tue, 28 Feb 2023 21:45:05 +0100 [thread overview]
Message-ID: <CAJFAV8zB91-L9X5UWgCO_Opv7+2kwAGfSa7m2e5gSR9yMkVsMA@mail.gmail.com> (raw)
In-Reply-To: <20230228172909.2054386-1-ferruh.yigit@amd.com>
On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH`
> flag, but `FOLL_TOUCH` is no more in public headers since v6.3,
> causing a build error.
Something looks strange with what kni was doing.
Looking at get_user_pages_remote implementation, I see it internally
passes FOLL_TOUCH in addition to passed gup_flags.
And looking at FOLL_TOUCH definition, it seems natural (to me) that
this flag would be handled internally.
Maybe it changed over time... but then the question is when did
passing FOLL_TOUCH become unneeded?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2023-02-28 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 17:29 Ferruh Yigit
2023-02-28 20:45 ` David Marchand [this message]
2023-03-20 12:10 ` David Marchand
2023-03-20 13:01 ` David Marchand
2023-03-24 3:04 ` [EXT] " Vamsi Krishna Attunuru
2023-04-13 7:22 ` David Marchand
2023-04-14 15:29 ` Ferruh Yigit
2023-04-14 15:25 ` [PATCH v2] " Ferruh Yigit
2023-04-17 7:32 ` David Marchand
2023-04-19 14:38 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zB91-L9X5UWgCO_Opv7+2kwAGfSa7m2e5gSR9yMkVsMA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).