From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A19841DA0; Tue, 28 Feb 2023 21:45:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3180440EE6; Tue, 28 Feb 2023 21:45:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 71BE64021F for ; Tue, 28 Feb 2023 21:45:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677617119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y0F2EtTBR1EG//tu11phOUysaDDusrDqoMAibtP14Ds=; b=ZyZPlTQknM1bS1GmkMhccoN/7VntRD4KVJyCFsAiqr2/UQ9JGo6kK1Q9TgrbjM/MZomE1e GaX80Br87fjzypW5ggNv9DYsFwjUuvebSFPaUC1avPItoGc9SPZAcKDg9bQHndjqwPuN+v d+4M3iUEnNaslJU9wsM12+47gNPXWnU= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-224-tmSKprcWMJeKh-zI6CZejQ-1; Tue, 28 Feb 2023 15:45:18 -0500 X-MC-Unique: tmSKprcWMJeKh-zI6CZejQ-1 Received: by mail-pl1-f198.google.com with SMTP id a9-20020a170902b58900b0019e2eafafddso1774387pls.7 for ; Tue, 28 Feb 2023 12:45:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677617117; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y0F2EtTBR1EG//tu11phOUysaDDusrDqoMAibtP14Ds=; b=JW0HrcPwS7iLpWajYDthl8zOYL71qXUHECiS4G/JnVuAX2rrYJgW8Q4Fvx3nW47BqU LrlSmqtWH0s0p3tTw3mQPPvPRB1NY2bb9knPM7bhfjx8yLK3F7uJHAEXUgVS4/m3o14C V96LaTbvupI4/up8ASpTQXvlukiTnEnmGyGhFKbiipa8sMGxysa6CXStJmSSjYTM8wcP ATb+jMFU+JxzhbY4BgV6al7aDEzrGeCPTB7mp2A17QnHNPKZXZjW+iy1cf1qNfIzSf7a NnvCTrkIURaR2r3wHsEF3C/SdxYcNWw9zlgm6Vo4NaEha78YaT31isZLmVYOYx21ZxaR 8gBA== X-Gm-Message-State: AO0yUKXfmc04dv31tJp7ces7lXIEjaMy/dA7wd7670TJnxRuf9UzGSB4 87xOx7mh/uH0DrSkR7hOWz5WfeUdQSPPpbPgLRYUh8vn9kcMC9luo34BpHdEE8LROhfZLoiIbCs Y6ZA4Cndk3s58XVAnQB0= X-Received: by 2002:a05:6a00:1647:b0:5f1:b1:6dc4 with SMTP id m7-20020a056a00164700b005f100b16dc4mr1537302pfc.3.1677617117271; Tue, 28 Feb 2023 12:45:17 -0800 (PST) X-Google-Smtp-Source: AK7set8tbpqnJQOWO1P+bG1zIVeg1cOyPctYDFLJ2kP7EAljn6lH9bS2De3pPCY/umjQMUzVj+hfDNIDb6U8MGuPV/c= X-Received: by 2002:a05:6a00:1647:b0:5f1:b1:6dc4 with SMTP id m7-20020a056a00164700b005f100b16dc4mr1537291pfc.3.1677617116936; Tue, 28 Feb 2023 12:45:16 -0800 (PST) MIME-Version: 1.0 References: <20230228172909.2054386-1-ferruh.yigit@amd.com> In-Reply-To: <20230228172909.2054386-1-ferruh.yigit@amd.com> From: David Marchand Date: Tue, 28 Feb 2023 21:45:05 +0100 Message-ID: Subject: Re: [PATCH] kni: fix build with Linux 6.3 To: Ferruh Yigit Cc: dev@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote: > > KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` > flag, but `FOLL_TOUCH` is no more in public headers since v6.3, > causing a build error. Something looks strange with what kni was doing. Looking at get_user_pages_remote implementation, I see it internally passes FOLL_TOUCH in addition to passed gup_flags. And looking at FOLL_TOUCH definition, it seems natural (to me) that this flag would be handled internally. Maybe it changed over time... but then the question is when did passing FOLL_TOUCH become unneeded? Thanks. -- David Marchand