From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03902A0524; Thu, 4 Feb 2021 15:48:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BEB7E240602; Thu, 4 Feb 2021 15:48:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id A98B92405F4 for ; Thu, 4 Feb 2021 15:48:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612450126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FJFKyhZtqwAkDUFiOgniYfOdKtQAjdOAQG4O+415Cew=; b=RQSf5Yw3mNb8q0PYSU0D+zqeISqzvz5bQdnleZRu1ZpYafwy46xAMCrPR2KtkvQeK1e+Fn Eqbr0btzyV31ZdnONtJ78gLs7G7/nurmynfdY3t6cZ9j86Mw6pnvVaX+BD9u8/8NWaO7Jf DlADdTrNerSfmiO04oM3a8XQdo7Qi6E= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-yUfhcI1SNwCVD-Tqoe9G1w-1; Thu, 04 Feb 2021 09:48:45 -0500 X-MC-Unique: yUfhcI1SNwCVD-Tqoe9G1w-1 Received: by mail-vk1-f197.google.com with SMTP id h25so1008036vkn.1 for ; Thu, 04 Feb 2021 06:48:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FJFKyhZtqwAkDUFiOgniYfOdKtQAjdOAQG4O+415Cew=; b=dUpZ9nED6TOkNnOKf/YoRBp6PUPQelD9FkEeXcCNXOX0zWMYnC79bJx4+PDcJ+gKlT fH82fet1AiheTX1dUvJBV5btT+OLiRDYf3TIctZKXKPWSM+TCI351NntOz0xwdDcccL/ 2T+z3oeRa0iadBpXyf2G44Wk0o3RBojheHNOwGNVO4SyP2AUhD+bEdhZF65sSgxcOac0 nWxE6H3ly/xTHZU25degfx45rvwwSqShTL3FAMQKVSkr6RuPjhEhvEHDn8Qaw7xS8lc7 24F2Zwuud9rPiQaUNSWTJBmbdq71+ZLeqtjflyfcAIr9HhXfSEFoWS/o7V1o6NWXtSRe UmaA== X-Gm-Message-State: AOAM530U/MNJWABOoqtsK+0n3MAv6Jx6ZH1+t18IU/+FHxMM6NLSHdcJ tQ214ZeU+N4AfNqtDU5+FmsugSsmkGWtMyq0NCOLWqlYJEzqHaxUCkBXZWVZ+j4bxI6KJVM+yNl T/wBbUVyGP9FZ5dvP7eE= X-Received: by 2002:ab0:7355:: with SMTP id k21mr923616uap.41.1612450124830; Thu, 04 Feb 2021 06:48:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJykrxOhup5R4KRQrKzZJ8H73OREFFRFpxObdlExWVEnHJbM21LbxgxJr+uDVSKZeiZq9ItrIPL9STmuSPFbcno= X-Received: by 2002:ab0:7355:: with SMTP id k21mr923587uap.41.1612450124516; Thu, 04 Feb 2021 06:48:44 -0800 (PST) MIME-Version: 1.0 References: <20210204133435.3117-1-david.marchand@redhat.com> <10271511.8fBPl8u87h@thomas> In-Reply-To: <10271511.8fBPl8u87h@thomas> From: David Marchand Date: Thu, 4 Feb 2021 15:48:33 +0100 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] devtools: select targets in build test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 4, 2021 at 2:59 PM Thomas Monjalon wrote: > > 04/02/2021 14:34, David Marchand: > > When a target compilation is broken, one way to skip the target is to > > uninstall the associated toolchain. > > But it is not always possible and you end up with hacking the script to > > avoid this target until a fix is ready. > > > > It is also often quicker to check a fix on a failing target before > > checking compilation on all targets. > > > > Introduce a variable to select targets. > > > > Example: > > $ DPDK_BUILD_TEST_TARGETS=build-x86-mingw \ > > ./devtools/test-meson-builds.sh > > With this solution, you need to list all targets you want to compile. To fill the list, it is easy, with no understand of the script internals: $ ls $HOME/builds build-32b build-arm64-dpaa build-arm64-octeontx2 build-clang-static build-gcc-static build-x86-default build-arm64-bluefield build-arm64-host-clang build-clang-shared build-gcc-shared build-ppc64le-power8 build-x86-mingw > > An alternative could be to disable a target in the config file > based on the variable DPDK_TARGET set by load_env. > One hack, which does not need any change in the script I think, > is to set targetcc=disabled. > Or we could check a well defined variable after calling load-devel-config. A bit fragile since you are bound to this internal shell variable. Putting logic in ~/.config/dpdk/devel.build is undocumented and more tedious than passing an environment variable when running the script. > > [...] > > +target_is_selected build-x86-default || exit 0 > > Why this line? If the build-x86-default was not compiled in this run because you did not select it, the call to the install target after this check triggers a compilation of this target. This is not wanted from my pov, or at best confusing, because you don't see anything with the default verbose: $ DPDK_BUILD_TEST_TARGETS=build-x86-mingw ./devtools/test-meson-builds.sh ninja: Entering directory `/home/dmarchan/builds/build-x86-mingw' [...] Found ninja-1.10.1 at /usr/bin/ninja [19/19] Linking target examples/dpdk-helloworld.exe ^^ for some time you get no output, you have the impression the script is stuck, while it is actually compiling the build-x86-default target. Then, ## Building cmdline ## Building helloworld ## Building l2fwd ## Building l3fwd ## Building multi_process ## Building skeleton ## Building timer Compiling those examples had nothing to do with the build-x86-mingw target I was expecting. -- David Marchand