From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 499A343018; Wed, 9 Aug 2023 14:24:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D80CA40691; Wed, 9 Aug 2023 14:24:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EB7D4400D6 for ; Wed, 9 Aug 2023 14:24:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691583864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oWLHgVFtZPobhKcZK6ueK7DUS/HVnv8gGd1GIESNt0M=; b=O282ROOaA9SXqvtl6fLir2LDdAc5p7RaNOxEr0H7bbiYgGwuOwKJ2LDWO/DO2D/NNIW6hc 2ypnPh0XGsyW7faYlMYkFpkntNgq/5qahNKAtsEJ3k9LI2Pgd7XOYLkPibH6ZKHrGnehsa BGpOAf9XlMx1iqu4hGrqpBS8AWb0/Lw= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-ywE0lV3SNnCdZM5fAn1q0w-1; Wed, 09 Aug 2023 08:24:22 -0400 X-MC-Unique: ywE0lV3SNnCdZM5fAn1q0w-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4fe32caefd8so6476312e87.3 for ; Wed, 09 Aug 2023 05:24:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691583861; x=1692188661; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oWLHgVFtZPobhKcZK6ueK7DUS/HVnv8gGd1GIESNt0M=; b=l3YaZ1ft1cq5xXXYPwohMcLXEJNZdDNJ1bJagBBP4T86T5GSXR01lYaMt/dYsZBz7t 0cgOizjGKDqxWiYPCWZ5ObQk+U9OgHmWqSEthiKXPSadORy+VBoUv/1o4p5QzwJXOtpB 53AAYH8PbgoRhizaPZVqucTHyQY/c2qMSCNKI6Leg1+RQm3WxiA7Me4Krvp60dMh9NWd y1Rg7P3HAvsLJuBp6aWHqdVyFMgEWI/PSu9H3uKkxFX7SkRztFVdoW00fxpxe/iJkCFF QISwPiitMSWM9JVf15abXQjgGrfoqjDpqf/dI7sGmpdpWZ6spsLgOSzXVh/QRk6JxD5X Z5Uw== X-Gm-Message-State: AOJu0Yx+pHz/fis32MKOCSgOla8JqYPDt6bCuZKaT7XVbF//JQroHdOt w61pZ3zfvaDun3rqZgtZP61T2WAfTC8GL1udDIqPb0Bo/xwKrkawO9HQhpckqDvVleXq9HVmV3M 5o0nr8uQ0d6aYuRnLkOo= X-Received: by 2002:a19:4346:0:b0:4fe:c4e:709f with SMTP id m6-20020a194346000000b004fe0c4e709fmr1624998lfj.20.1691583861473; Wed, 09 Aug 2023 05:24:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPYZOmri03kNQYEZbYovLVAx5q7kXPeSA6qitxXNPDd0C1gOGa6Ppgowyrp9g5fED4usqPOKtPCGfznrEHq44= X-Received: by 2002:a19:4346:0:b0:4fe:c4e:709f with SMTP id m6-20020a194346000000b004fe0c4e709fmr1624985lfj.20.1691583861172; Wed, 09 Aug 2023 05:24:21 -0700 (PDT) MIME-Version: 1.0 References: <20220829151901.376754-1-bruce.richardson@intel.com> <20230731153902.2350026-1-bruce.richardson@intel.com> <20230731153902.2350026-3-bruce.richardson@intel.com> In-Reply-To: <20230731153902.2350026-3-bruce.richardson@intel.com> From: David Marchand Date: Wed, 9 Aug 2023 14:24:09 +0200 Message-ID: Subject: Re: [PATCH v7 2/3] log: separate logging functions out of EAL To: Bruce Richardson Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Tyler Retzlaff X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sorry, two additional comments after running more checks. lib/log files are not referenced in MAINTAINERS, can you add a new block? > diff --git a/lib/log/meson.build b/lib/log/meson.build > new file mode 100644 > index 0000000000..6baff83ee5 > --- /dev/null > +++ b/lib/log/meson.build > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2022 Intel Corporation > + > +includes += global_inc > +sources = files( > + 'log.c', > + 'log_' + exec_env + '.c' > +) Missing a , (reported by check-meson.py). > +headers = files('rte_log.h') -- David Marchand