From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00A33A0519; Fri, 3 Jul 2020 11:08:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 873D31DA76; Fri, 3 Jul 2020 11:08:21 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 70C201DA71 for ; Fri, 3 Jul 2020 11:08:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593767299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PRYlRWVnzXmIbRsitLlPi/oqXYqN132YMwHLeL/DpYI=; b=LxgiitRro9WETgQ1FytB0r6lZtf3iBepptlZtJpVafUF4UjetTa/3BiDsH6Jnevjpq8vHG pSMaB655aC40g+ijuSgvyGCpF0C3wIRtumW2J0LJrQTuXUrRfvC/NsHRpkSAQBl4yKbx8K mWBzOeoBVhUsKZ4TIS8Yj35R9yFFOd0= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-osMMxHaXPE-0pkBx-EicXA-1; Fri, 03 Jul 2020 05:08:16 -0400 X-MC-Unique: osMMxHaXPE-0pkBx-EicXA-1 Received: by mail-vk1-f198.google.com with SMTP id v62so3154252vkb.13 for ; Fri, 03 Jul 2020 02:08:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PRYlRWVnzXmIbRsitLlPi/oqXYqN132YMwHLeL/DpYI=; b=Iw9jGh3/8ChwWz1q3mnTn8KThBz79B3GptiNcWRGuUb+qi27M5/wi2CzGfOe3Ozemz +pcZfSsSFelda37TPKcdSuSKPpsq8NYEqPRT9995sd8FVcT0bq8pqsfQL/n1WZaIXZc6 S0Hdfzmst3wZ/WrhdPAsYG1AGtzXDjOpDpLs2svxebzysjzPceK/vW51YwWvjPDM87rJ lE3NG1okACJhjPEI+55h0CIjF4ETXlAAOQvePeMMkgq15MAma2oZ1+FxDmSVF5SQweb2 qTG4i+qFR/iA5iGVkjxttXFDwDr0fQktqeKqLgf/OwCm7kSjWiCXfBSqmuIOf4MZfrCp JVrg== X-Gm-Message-State: AOAM533j89NNkLhzA3ZiX9MV+9H3sbT1B1u8H+OlmZ+JJYn6ccqr2wtB Ngh8VAcFOFNNXMHitWMuCvF3hLonxgz8i3d5UNvLhskAk38+xveV8ad/A7zzP+q2lSDrIhwC1Mz 61FQ71dg7imAEbRNTne4= X-Received: by 2002:a1f:8c55:: with SMTP id o82mr8513545vkd.18.1593767296168; Fri, 03 Jul 2020 02:08:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxl9ai6tYrE+KGNYCTlhPL4ewb4JV66BrZ9TzkLTEYcrZhJ1974sNpF/htck4Wb4vJcK7MmoWecuIQimGn1/Ac= X-Received: by 2002:a1f:8c55:: with SMTP id o82mr8513525vkd.18.1593767295949; Fri, 03 Jul 2020 02:08:15 -0700 (PDT) MIME-Version: 1.0 References: <20200217222654.2218926-1-thomas@monjalon.net> <20200524173007.1653549-1-thomas@monjalon.net> In-Reply-To: From: David Marchand Date: Fri, 3 Jul 2020 11:08:04 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson , John McNamara , Marko Kovacevic , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Gagandeep Singh , Hemant Agrawal , Sachin Saxena , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] devtools: forbid variable declaration inside for X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 28, 2020 at 2:30 PM David Marchand wrote: > On Sun, May 24, 2020 at 7:30 PM Thomas Monjalon wrote: > > > > Some compilers raise an error when declaring a variable > > in the middle of a function. This is a C99 allowance. > > Even if DPDK switches globally to C99 or C11 standard, > > the coding rules are for declarations at the beginning > > of a block: > > http://doc.dpdk.org/guides/contributing/coding_style.html#local-variables > > > > This coding style is enforced by adding a check of > > the common patterns like "for (int i;" > > > > The occurrences of the checked pattern are fixed: > > 'for *(\(char\|u\?int\|unsigned\|s\?size_t\)' > > In the file dpaa2_sparser.c, the fix is to remove the unused macros. > > > > Signed-off-by: Thomas Monjalon > Acked-by: David Marchand Discarded the (now obsolete) change on windows/eal.c and applied. -- David Marchand