DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] ci: point at GitHub mirror.
@ 2025-03-04 15:50 David Marchand
  2025-03-04 21:57 ` Patrick Robb
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: David Marchand @ 2025-03-04 15:50 UTC (permalink / raw)
  To: dev; +Cc: stable, Aaron Conole, Michael Santana

We face some random failures accessing dpdk.org git when running GHA.
Point at GitHub hosted mirror.

Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 183b0b1999..e98a60a852 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -11,7 +11,7 @@ defaults:
 
 env:
   REF_GIT_BRANCH: main
-  REF_GIT_REPO: https://dpdk.org/git/dpdk
+  REF_GIT_REPO: https://github.com/DPDK/dpdk
   REF_GIT_TAG: v24.11
 
 jobs:
-- 
2.48.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ci: point at GitHub mirror.
  2025-03-04 15:50 [PATCH] ci: point at GitHub mirror David Marchand
@ 2025-03-04 21:57 ` Patrick Robb
  2025-03-05 14:59 ` Aaron Conole
  2025-03-06 17:08 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: Patrick Robb @ 2025-03-04 21:57 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, stable, Aaron Conole, Michael Santana

[-- Attachment #1: Type: text/plain, Size: 2157 bytes --]

I see a spurious dpdk-test fail for this, on per_lcore_autotest, it
remotely launches an lcore which is running though it should not be able
to. I threw the relevant blurbs below - I will bring this to Bugzilla since
obviously your patch is unrelated.

We can do a retest if you want - otherwise I think you are safe to ignore
this fail.

 78/119 DPDK:fast-tests / per_lcore_autotest             FAIL
1.14s   (exit status 255 or signal 127 SIGinvalid)
16:49:56 DPDK_TEST=per_lcore_autotest MALLOC_PERTURB_=178
/root/workspace/Generic-Unit-Test-DPDK/dpdk/build/app/dpdk-test --no-huge
-m 2048
----------------------------------- output
-----------------------------------
stdout:
RTE>>per_lcore_autotest
on socket 0, on core 1, variable is 1
wait 100ms on lcore 1
It does remote launch successfully but it should not at this time
Test Failed
RTE>>wait 100ms on lcore 1
stderr:
EAL: Detected CPU lcores: 16
EAL: Detected NUMA nodes: 2
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: VFIO support initialized
APP: HPET is not enabled, using TSC as default timer
------------------------------------------------------------------------------

The test:

```
test_per_lcore(void)
{
unsigned lcore_id;
int ret;

rte_eal_mp_remote_launch(assign_vars, NULL, SKIP_MAIN);
RTE_LCORE_FOREACH_WORKER(lcore_id) {
if (rte_eal_wait_lcore(lcore_id) < 0)
return -1;
}

rte_eal_mp_remote_launch(display_vars, NULL, SKIP_MAIN);
RTE_LCORE_FOREACH_WORKER(lcore_id) {
if (rte_eal_wait_lcore(lcore_id) < 0)
return -1;
}

/* test if it could do remote launch twice at the same time or not */
ret = rte_eal_mp_remote_launch(test_per_lcore_delay, NULL, SKIP_MAIN);
if (ret < 0) {
printf("It fails to do remote launch but it should able to do\n");
return -1;
}
/* it should not be able to launch a lcore which is running */
ret = rte_eal_mp_remote_launch(test_per_lcore_delay, NULL, SKIP_MAIN);
if (ret == 0) {
printf("It does remote launch successfully but it should not at this
time\n");
return -1;
}
RTE_LCORE_FOREACH_WORKER(lcore_id) {
if (rte_eal_wait_lcore(lcore_id) < 0)
return -1;
}

return 0;
}
```

[-- Attachment #2: Type: text/html, Size: 2586 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ci: point at GitHub mirror.
  2025-03-04 15:50 [PATCH] ci: point at GitHub mirror David Marchand
  2025-03-04 21:57 ` Patrick Robb
@ 2025-03-05 14:59 ` Aaron Conole
  2025-03-06 17:08 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: Aaron Conole @ 2025-03-05 14:59 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, stable, Michael Santana

David Marchand <david.marchand@redhat.com> writes:

> We face some random failures accessing dpdk.org git when running GHA.
> Point at GitHub hosted mirror.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Thanks - this change makes a lot of sense to me.  I was going to say we
can use the ``GITHUB_REPOSITORY`` variable, but the problem with that is
that it will pull references to the local users repo instead.  I guess
there isn't actually a good reference to a 'source of truth' that is
predefined.

Acked-by: Aaron Conole <aconole@redhat.com>

>  .github/workflows/build.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
> index 183b0b1999..e98a60a852 100644
> --- a/.github/workflows/build.yml
> +++ b/.github/workflows/build.yml
> @@ -11,7 +11,7 @@ defaults:
>  
>  env:
>    REF_GIT_BRANCH: main
> -  REF_GIT_REPO: https://dpdk.org/git/dpdk
> +  REF_GIT_REPO: https://github.com/DPDK/dpdk
>    REF_GIT_TAG: v24.11
>  
>  jobs:


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ci: point at GitHub mirror.
  2025-03-04 15:50 [PATCH] ci: point at GitHub mirror David Marchand
  2025-03-04 21:57 ` Patrick Robb
  2025-03-05 14:59 ` Aaron Conole
@ 2025-03-06 17:08 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2025-03-06 17:08 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, stable, Aaron Conole, Michael Santana

On Tue, Mar 4, 2025 at 4:51 PM David Marchand <david.marchand@redhat.com> wrote:
>
> We face some random failures accessing dpdk.org git when running GHA.
> Point at GitHub hosted mirror.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-03-06 17:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-04 15:50 [PATCH] ci: point at GitHub mirror David Marchand
2025-03-04 21:57 ` Patrick Robb
2025-03-05 14:59 ` Aaron Conole
2025-03-06 17:08 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).