From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E7084240D; Wed, 18 Jan 2023 15:52:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F384400D6; Wed, 18 Jan 2023 15:52:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 77DD94003F for ; Wed, 18 Jan 2023 15:51:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674053518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bGS2Dz1Yy9BpQvTclm9iUEz03iCgE41pF+0YKnxN7nY=; b=DGTXFUcMh1M1LDbjHyOEdNiosE7zQOJ+7rK4ZHzLea3/sG3V0Tb5uHpSR25ilkRoERZKWs BixMtH6hs8TW5Nyvl4ehA3VWaeK2h2/GsIO3w3eOKQo881PDOWFr5j/JSiVcrnA8atPIEt 4LaJ36zzcMrMw5XZWBs2u9lZEzR4iE8= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-76-KjowP2NfONypjn4gfY6BHg-1; Wed, 18 Jan 2023 09:51:56 -0500 X-MC-Unique: KjowP2NfONypjn4gfY6BHg-1 Received: by mail-pf1-f200.google.com with SMTP id f15-20020a62380f000000b0058db55a8d7aso3838634pfa.21 for ; Wed, 18 Jan 2023 06:51:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bGS2Dz1Yy9BpQvTclm9iUEz03iCgE41pF+0YKnxN7nY=; b=ShS/1KSYm2wWwGYtI8O3nhIpdKKvkl6B6BqJtrGXSDmNPZXzpHJsFvt4EmcWsz0WZx lhwg5dQnYFs7M100L+3f3Dq4+ytyzFK/+3n73vfxxocNlmo2b7x2ZuQ3vkDLijdAxpYb SU/n3xqtimSd2u40MEGIdYvU3T7PmJkWKDUxphDwH1dastYxCnu4tTQZ9fPdpQJxem/e XcLRV90Apo8Vuc60iVZhLh/tpifMhdDoTaku4akx/xbmJClixSE19OFPSYuErid9rYIM btTLDNcHRA7QwqxB5HVDQ0hoPlsgrGw/qU53oLgS3sv3CrPFDUCipHCiVp2xnDl3eJxi qFtA== X-Gm-Message-State: AFqh2kqnkk6nth53LwDUrRJDy3CqeYRAK70ywfwUzJO9Qhsi80iZsd3h C8zHsg6P6NI//F/enHCDxrM6/Nvdo57XgHrro+gjj1bvUPyZ86kd0noSlPQV9cDPpH36Hwvb02/ BkoCyF1QplxFilw8UlW8= X-Received: by 2002:a05:6a00:1755:b0:58d:a132:af23 with SMTP id j21-20020a056a00175500b0058da132af23mr660368pfc.76.1674053515693; Wed, 18 Jan 2023 06:51:55 -0800 (PST) X-Google-Smtp-Source: AMrXdXufwOsWMn6JxWKjPNONe4HL7BxAEVtrP2EiQucq4G2Chf6y5GtpdHNTplNk7nMI4lkSfF9SSDIzhT37a8NBMKA= X-Received: by 2002:a05:6a00:1755:b0:58d:a132:af23 with SMTP id j21-20020a056a00175500b0058da132af23mr660364pfc.76.1674053515432; Wed, 18 Jan 2023 06:51:55 -0800 (PST) MIME-Version: 1.0 References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1673979709-8613-1-git-send-email-roretzla@linux.microsoft.com> <1673979709-8613-3-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1673979709-8613-3-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Wed, 18 Jan 2023 15:51:43 +0100 Message-ID: Subject: Re: [PATCH v5 2/4] eal: remove thread getname API To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, mb@smartsharesystems.com, jerinjacobk@gmail.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 17, 2023 at 7:22 PM Tyler Retzlaff wrote: > > Remove the rte_thread_getname API. The API is __rte_experimental and > requires no deprecation notice. > > Fold the platform specific variants into the one place it is used as a > special case to retain the functionality for linux only. > > Adjust the function as follows. > * limit use of this very platform glibc specific function to the single > place it is used. > * change the return type to void since the single use cannot > meaningfully check for failure given the platform defined behavior. > * change the thread id type to be rte_thread_t. > * rename the function rte_thread_get_name to be consistent with the > exported rte_thread_set_name. This comment is not relevant anymore. > > Signed-off-by: Tyler Retzlaff -- David Marchand