From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC6DBA0032; Fri, 1 Oct 2021 08:47:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E65B94067E; Fri, 1 Oct 2021 08:47:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 9636D40040 for ; Fri, 1 Oct 2021 08:47:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633070872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K2jl5QVApKjf0iR6N6W001qytCWu8z+wugZpJw0ZHBs=; b=KZIAHpqYd7YiFIZJQqegyKWR9qsV5aiIKStb+h2lItZIEkvbN+A0C/xFHDljcUBf8FTfe9 syuPZ7LaHDGsCUFCCTpGEyHY1tN+Jv8bmwsvB2XAZVnvEaPboMqPDqbAvg1Am4LVmDtEF9 6t6aMpwRDps+yHD73WOcJebNYXUcHOA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-5GqNKaCdMv692IexHl8uSA-1; Fri, 01 Oct 2021 02:47:51 -0400 X-MC-Unique: 5GqNKaCdMv692IexHl8uSA-1 Received: by mail-lf1-f70.google.com with SMTP id d16-20020a056512369000b003fca9e038ddso8062513lfs.3 for ; Thu, 30 Sep 2021 23:47:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=K2jl5QVApKjf0iR6N6W001qytCWu8z+wugZpJw0ZHBs=; b=JAQMkcrP2P13j+QTpSa4n/F5ESEgN9z3ikuqRIe9TS8qRbQCv5KWT/GCXKPglwM6Qm OJxssWu3KdcJ1Sf9Jq4zkpAhjMPo0tyHUo+KEJCULhRA9fjJrasQFEirekL988mXsQfR bclpwVNeTgc4DMTCTN5wJn0ziPz3FDorTxcKNzy/qEwDzlp3ABedt1en0aA7A7sYkQJ4 cAGiKwe2bQ7kkUuBHBEyfq49T1n2vlmPRjjl0rdLUtc+lztOiGREfLla4Dv8UL6ZuZcZ 2aBRKerEbwyEBFtl58qoegNLOQ6ps1YlzLFDcNznYDnn0NpJzs1iSmX+y3OmIWVExwu5 MmpQ== X-Gm-Message-State: AOAM530cmuGGPpOl6hvIuJ2esxkRI1fbmWLkQBZzrsr0ygtpg3bCKoeT bmt4c1cKyxJXcWAPU3pvzPfcs87xmhgDmg3LXdstaFpd039k77/dQM0DsUQPxMYA0XstJIF8n5T fEvtbN47fp+Wn9BcMLyE= X-Received: by 2002:a2e:9a98:: with SMTP id p24mr10395852lji.55.1633070869557; Thu, 30 Sep 2021 23:47:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyba8WnEAhSIAj7usKokyaYunwnm9wSlLD9Y11J9b++ZGViNNUY5s13WuILv4tfBAYZZazzRc6pgMOvQrufn10= X-Received: by 2002:a2e:9a98:: with SMTP id p24mr10395825lji.55.1633070869290; Thu, 30 Sep 2021 23:47:49 -0700 (PDT) MIME-Version: 1.0 References: <20210917082313.21934-1-david.marchand@redhat.com> <20210917082313.21934-2-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 1 Oct 2021 08:47:38 +0200 Message-ID: To: Long Li Cc: "dev@dpdk.org" , "aconole@redhat.com" , "zhihongx.peng@intel.com" , "stable@dpdk.org" , Stephen Hemminger Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/3] bus/vmbus: fix leak on device scan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 30, 2021 at 9:14 PM Long Li wrote: > > rte_device name only points at some location where the name is stored. > > In general this storage is in the bus object or (in some buses) the dev= arg that > > resulted in the rte_device object creation. > > > > If we won't store the name in the bus object, then we lose the ability = to > > release the name later. > > This is probably fine as long as we never release rte_vmbus_device obje= cts > > which is the case atm. > > But I don't understand why vmbus should be an exception when comparing > > to other buses. > > I don=E2=80=99t understand why you want to put a name there if it's never= used outside vmbus_scan_one(). Since you don't care about releasing rte_vmbus_device objects, I'll rework as you suggest. --=20 David Marchand